Rarity

Table of Contents

Due to a Blizzard change in 7.0.3, Rarity no longer tracks AOE looting.

Any mobs that drop something will be counted, but mobs that drop nothing or drop only money will not be counted. This primarily affects items such as Skyshard.

Rarity tracks how many times you've tried to obtain various rare items like mounts, battle pets, and toys. It will tell you how likely you are to obtain the item, track how long you've been farming for it, and tell you how lucky you've been so far. Although it's mostly used for mounts, battle pets, and toys, it supports pretty much any item, including profession patterns, archaeology projects, and more.

Looking for Rarity Item Packs? Scroll down.

Out of the box, Rarity includes support for every single mount, battle pet, and toy in the game which require some time to farm. It also includes support for some mount-related items like Skyshard, Primal Egg, and Giant Dinosaur Bone. It'll even notice if you mouseover a Mysterious Camel Figurine, plus lots of other stuff. Rarity factors in the size of a typical group when determining probabilities, and can also tell you if you've killed various bosses this week (or day). Holiday just started, and you didn't notice? Rarity will give you a helpful reminder to run those holiday dungeons or daily quests if you still need an item from them.

If Rarity doesn't track something you want to track, you can add it yourself! Just about everything is user configurable.

Curious what math is going on behind the scenes? The author of Bunny Hunter created the original algorithms. He wrote an article about it here. Your chance to obtain an item doesn't increase as you farm it; Rarity is just telling you how lucky you've been so far. It can be remarkably cathartic to see a progress bar move up as you spend hours upon hours trying for that Disgusting Oozeling.

Main features

Rarity is primarily an LDB feed with a large tooltip. It can function as either a mini-map icon (you have to turn this on in the options), or as a standard LDB feed (use a display like Fortress, Button Bin, Titan Panel, or Chocolate Bar).
Provides a progress bar, which you can toggle by clicking the icon or feed label.
Adds info to NPC and item tooltips, showing you if it drops or contains something that Rarity tracks. Rare mobs with a guaranteed drop show which item they drop and if you've defeated them yet.
Includes full source info, telling you how to obtain everything Rarity tracks.

Other features

Share packs of items with other users
Can automatically add waypoints to TomTom for certain items
Uses statistics whenever possible to keep track of attempts
Breaks your farming down by session, day, week, and month
Looks at your instance locks to see if you've defeated various bosses recently
Reminds you if you need to farm a holiday dungeon or daily quest, and hides holiday items that aren't available right now
Supports bonus coin rolls
Automatically screenshots when you obtain an item
Keeps track of rare achievements like Frostbitten and Glorious
You can add your own items to track
Lets you modify your attempt count without having to edit saved variables
Automatically imports data from Bunny Hunter if you're switching

Comments, bug reports, discussion

Help translate Rarity

Click here to help translate Rarity into your language.

Frequently Asked Questions

Click here to read the Frequently Asked Questions. Please read this before requesting support.

Rarity Item Packs

These are item packs contributed by other users which contain items not included in Rarity by default. To import them, copy the string below (make sure to get the entire thing). Then navigate to the Rarity Options screen and choose the Import/Export tab. Follow the instructions there.

Weapon Illusions (20 items)—contributed by Zanthix

A0D5Gf8CJ1IIt0iB6hcpUIaR6pjAMgXPlDIN4BqgbSL5JinjFDqnpHVK1D1SiA5KlYUgD0kBTSRFXZRUbSQFMpIUSidFrCSF4iUpJDdJyU6Vn0owlBRSR5XIUknlKTFVKltJQfSVFOAsKUjWkoLUXjRYFIchiwU9BposcZlqsyh9JkVGK9VpodWkoLwmpWYrui1lt6rfUMNBLZfkOcl0ynVRbScF4TspVOOV0Hmpaj0pqPaL1AzYUaJ5U+x4ATuKL8K4MkKUiZT1zLzBpng65WFQseMFvG1Y9RRv4G3DCP8C8jbetm1AnQfgbcOYAtIo4I4edB5QpyAzb7Apnk7xR+H0QohifdgpSVevRWluOy4UaEGEogxZVBbBpLDjBbxt/wKOvIE3jLWVt/G2AZjiAXjb/wKs0SixwbgyhpRo3pLCC7Zx1HVKFudfGFIeNackc+Yq4l9OZ6CJiqczGoCqQtnxjAX167zFL14RosRXhh50zTGbjWA+Lbpix0sx5AEI0Sg4NBTfy1LuypLCAwzjCqT4o3B67x/nD3rzN0WIxhvYUXwRxpURokykrGfmDTbF0ykTg9oQVupQc4qGwpo0aXBBFX7Kw6Bixwt42zaMI40C7uhB5wF1SjRvSeEF2zjqAcUfhdMLIYoyZFFZBJPCjhfwhnHcaBR/FE7v/eP8QW/+pghRHjWnJHPmKuJfTmegiXFJZzRXKH58TZTYYFwZQwoy8wab4umULM6/MKTEV4YedM0xm41gPi26YscDEKJRdjxjQf06b/GLV4Qo1oedknT1WhQcGorvZSl3ZUnhAYZxTVGa244LBVoQofE2dhRfhHFlhCgTKeuZeYNN8XTKxKA2hJU61JyigXuFHzdkEUxneo8bmn3Kw6Bixwt4gQ7/AgRAGgXc0YPOA+oUZOYNNsXTKf4onF4IUawPOyXp6rUozW3HhQItiFBig3FlDCn+KJze+8f5g978TRGiZHH+hSHlUXNKMmeuIv7ldEYD9wo/VpRo3pLCC7ZxHEbKjmcsqF/nLX7xihAFh4bie1nKXVlSeIBh3UaKMmRRWQSTwo4X8AJ9BaR4Ay/QV/8CgLfxAn0F/wJ5/wJeoK+AGo3GA7Cj+CKMKyNEmUhZz8wbbIqnUyYGtSGs1KHmFA2Ic6YzOJvO2O7pTH2DvcIV5WFQseMFvJQO0HUaBdzRg84D6pRo3pLCC7Zx1AEUfxROL4Qo1oedknT1WhR/FE7v/eP8QW/+pghR4itDD7rmmM1GMJ8WXbHjpQjxAiBD3kaIByDEAxLiBf8ChjRKbDCujCEFmXmDTfF0ShbnXxhSHjWnJHPmKuJfTmc0EE+sVK4oO56xoH6dt/jFK0IUZciisggmhR0v4KVGXecNvFRtXXkbr7YONR6AV1uHFI2CQ0PxvSzlriwpPMCw6gOlue24UKAFERoPyI7iizCujBBlImU9M2+wKZ5OmRjU1py/JsefFN4wpigPg4odL+ANwBpAp1HAHT3oPKBOieYtKbxgG8dtpPijcHohRFGGLCqLYFLY0Sj+KJze+8f5g978TRGiNLcdFwq0IEKJDcaVMaQgM2+wKZ5OyeL8C0NKfGXoQdccs9kI5tOiK3a8YCVEo+x4xoL6dd7iF68IUR41pyRz5iriX05nNDuyPVthZRQcGorvZSl3ZUnhAYYVMFKsDzsl6eq1aLwUO4ovwrgyQpSJlPXMvMGmeDplYlAbwkodak7RkGhG26uI0hnNlaOmcTS1vaI8DCp2vIC3pWrjSqOAO3rQeUCdEs1bUnjBNo7bQPFH4fRCiGJ92ClJV69F8Ufh9N4/zh/05m+KEKW57bhQoAURSmwwrowhJb4y9KBrjtlsBPNp0RU7XooQD0CIRsni/AtDyqPmlGTOXEX8y+lMPapsn1FDxNdE2fGMBfXrvMUvXhGiIDNvsCmeTsGhofhelnJXlhQeYFgBAUUZsqgsgklhxwt4gFQtxRt4gFQNSKPxauwovgjjyghRJlLWM/MGm+LpFIvNeQHlYVCx4wW8IP8C6gONUpC5Yscb9CCl14aVHcVic15Ao1GQmTfYFE+n+KNweiFEUYYsKotgUtjxAl6gryuN4o/C6b1/nD/ozd8UIQq4owedB9QpscG4MoYU68NOSbp6LUoW518YUh41pyRz5iriX05nNGii5oZfU+6UHc9YUL/OW/ziFSFKNG9J4QXbOG4bBYeG4ntZyl1ZUniAYQUMlOa240KBFkRovJEdxRdhXBkhykTKembeYFM8nTIxqA1hpQ41p8iO0hmcTWc0yFFFeRhU7HgBL6Wv60qjgDt60HlAnRLNW1J4wTaOOpDij8LphRDF+rBTkq5ei+KPwum9f5w/6M3fFCFKc9txoUALIpTYYFwZQ0p8ZehB1xyz2Qjm06IrdryNEC9FiAcgxAMSolGyOP8BwpDyqDklmTNXEf8BcjqjMah4OiNwrKJRdjxjQf06b/GLV4QoyMwbbIqnU3BoKL6XpdyVJYUHGFY9RVGGLCqLYFLY8QJeahx03sBLjcHK23i1tTbw/wK82loLaDTeyo7iizCujBBlImU9M2+wKZ5OmRjUhrBSh5pToIlA7R19oTwMKna8gFerbQOQRgF39KDzgDolmrek8IJtHPWV4o/C6YUQRRmyqCyCSWHHC3jrlgLwBt66pYC8jbduqY0H4K1baqBR/FE4vfeP8we9+ZsiRGluOy4UaEGEEhuMK2NIedScksyZq4h/OZ3RQpV2OoOz6Qw0EahdYVCbksX5F4aU+MrQg645ZrMRzKdFV+x4AYAhL0gx5AVAhrygxpBG2fGMBfXrvMUvXhGiIDNvsCmeTsGhofhelnJXlhQeYFgDnWJ92ClJV69F4wU6O4ovwrgyQpSJlPXMvMGmeDplYlAbwkodak45rzRCw/d8Uh4GFTtewKul/wJ6jUYBd/Sg84A6BZl5g03xdIo/CqcXQhRlyKKyCCaFHS/grUMNwBt4gR6sI2/jrUNto1Ga244LBVoQocQG48oYUvxROL33j/MHvfmbIkTJ4vwLQ8qj5pRkzlxF/MvpjBaqtNMZnE1nZEcFa7xh/BTrw05Junotyo5nLKhf5y1+8YoQBYeG4ntZyl1ZUniAYdVrlGjeksILtnHUUzReELCj+CKMKyNEmUhZz8wbbIqnUyYGtSGs1KHmFI2Ks8KaNKUzmh0V7zvlYVCx4wW8Vd9qI40C7uhB5wF1CjLzBpvi6RR/FE4vhCjKkEVlEUwKO17AC/QhWHkDL9CHQedtvEAfgpEH4AX6ENRolOa240KBFkQoscG4MoYUfxRO7/3j/EFv/qYIUbI4/wHCkPKoOSWZM1cR/wFyOqOFKu10BmfTGds9nYGme4mvKZ3RWDwn1jjF+rBTkq5ei7LjGQvq13mLX7wiRMGhofhelnJXlhQeYFj1lRLNW1J4wTaO+kjjBQM7ii/CuDJClImU9cy8waZ4OmViUBvCSh1qTtEoVGlCtqcz0ETFs1EZ5WFQseMFvNpYC/8CNAq4owedB9QpyMwbbIqnU/xROL0QoihDFpVFMCnseAFvHUb/Am/grcMI5G28dRgHHoC3DqNOozS3HRcKtCBCiQ3GlTGk+KNweu8f5w968zdFiJLF+ReGlEfNKcmcuYr4l9MZLVRppzM4m87Y7umM7MjMKy/pjMaiLxTrw05Junotyo5nLKhf5y1+8YoQBYeG4ntZyl1ZUniAYdVHSjRvSeEF2zjqNRov2NhRfBHGlRGiTKSsZ+YNNsXTKROD2hBW6lBzihausCvKw6Bixwt4ATA11mgUcEcPOg+oU5CZN9gUT6f4o3B6IUSxPuyUpKvXojS3HRcKtCBCiQ3GlTGkZHH+hSHlUXNKMmeuIv7ldEYLvyaMlVOieUsKL9jG2lqj+KNweu8f5w968zdFiIJDQ/G9LOWuLCk8wDCuA2XHMxbUr/MWv3hFiMYL/wLsKL4I48oIUSZS1jPzBpvi6ZSHQcWOF/ACfaulVhoF3NGDzgPqFGTmDTbF0yn+KJxeCFGsDzsl6eq1KM1tx4UCLYhQYoNxZQwp0bwlhRds4zjUKFmcf2FIedScksyZq4h/OZ25qGm3hiqnKEMWlUUwKex4AS/Q123kDbxAX7eVt/ECfd1qPP8CL9DXLUWj+KNweu8f5w968zdFiIJDQ/G9LOWuLCk8wLBu/wLKjmcsqF/nLX7xihCNF/8C2VF8EcaVEaJMpKxn5g02xdMpE4PaEFbqUHPKeRZVET3lYVCx4wU8QLDVUjQKuKMHnQfUKcjMG2yKp1P8UTi9EKJYH3ZK0tVrUZrbjgsFWhChxAbjyhhS/FE4vfeP8we9+ZsiRMni/AtDyqPmlGTOXEX8y+mMRmONe5XOdLiq/I0SzVtSeME2jvpA2fGMBfXrvMUvXhGi4NBQfC9LuStLCg8wjOtIUYYsKotgUtjxAh4QmALyBh4QmErRaLwgxY7iizCujBBlImU9M2+wKZ5OmRjUhrBSh5pTOgctV5SHQcWOF/Bq4woYaRRwRw86D6hTkJk32BRPp/ijcHohRFGGLCqLYFLY8QLeOqwbb+Ctwwrgbbx1WAcegLcOq06jNLcdFwq0IEKJDcaVMaT4o3B67x/nD3rzN0WIksX5F4aUR80pyZy5iviX05k6DGqH0byiWB92StLVa1F2PGNB/Tpv8YtXhCg4NBTfy1LuypLCAwwr/wJAieYtKbxgG8cNSOMFNXYUX4RxZYQoEynrmXmDTfF0ysOgYscLeFsKuNZoFHBHDzoPqFOQmTfYFE+n+KNweiFEsT7slKSr16I0tx0XCrQgQokNxpUxpETzlhResI0rEEjJ4vwLQ8qj5pRkzlxF/MvpTF3+ns7gbDpThzQcVxF0ijJkUVkEk8KOF/D/AqkxxRt4gNQ48jYeIAXceP8CHiA11mgUfxRO7/3j/EFv/qYIUXBoKL6XpdyVJYUHGNbaRtnxjAX167zFL14RovGCkR3FF2FcGSHKRMp6Zt5gUzydMjGoDWGlDjWndF65sog+nUnm3DHOUh4GFTtewAuAqXGkUcAdPeg8oE5BZt5gUzyd4o/C6YUQxfqwU5KuXovS3HZcKNCCCCU2GFfGkJLF+ReGlEfNKcmcuYr4l9MZwfnMVlgZJZq3pPCCbaytK8UfhdN7/wE4f9CbvylCFBwaiu9lKXdlSeEBhnEFUHY8Y0H9Om/xi1eEaLxgZUfxRRhXRogykbKemTfYFE+nTAxqQ1ipQ80psqPi6QzOpjO9Cj3lYVCx4wW8IAUc/wI0CrijB50H1CnIzBtsiqdT/FE4vRCiWB92StLVa1Ga244LBVoQocQG48oYUrI4/wHCkPKoOSWZM1cR/wFyOiP5Z2PllGjeksILtrG2jhR/FE7v/eP8QW/+pghRcGgovpel3JUlhQcYxnWj7HjGgvp13uIXrwjReIPOjuKLMK6MEGUiZT0zb7Apnk6ZGNSGsFKHmlN6UyN62rGiPAwqdryAB0jVgBuNAu7oQecBdQoy8wab4ukUfxROL4QoypBFZRFMCjtewAMCazXewAMCaykapbntuFCgBRFKbDCujCHFH4XTe/8BOH/Qm78pQpQszr8wpDxqTknmzFXEv5zOaED8ks2rPsX6sFOSrl6LsuMZC+rXeYtfvCJEwaGh+F6WcleWFB5gWAFASjRvSeEF2zhuKRqNoqKmR5ZXTqnToGTQaM3/Ag1b0DCN0e9NU/KgBtPQPY3USEqYx1l4QCCQRgI=

Comments

Lilyoptra
- Join Date: 2/3/2017
- Posts: 1
- Member Details
#159 Lilyoptra

View User Profile

Send Message

Posted Jun 4, 2017
Thanks for all your efforts with this addon - It is truly one of my favorites. It seems you have done some work recently to update and was wondering if you could also add the Albino Buzzard from Crysa's Torn Sack of Pet Supplies and the 3 pets from the new Pet Dungeon, Wailing Caverns, that come from the reward at the end, Damp Pet Supplies: Cavern Moccasin, Everliving Spore, and Young Venomfang. Again, thank you and all other contributors for this wonderful addon.

Rollback Post to Revision RollBack
padore
Curse Premium
- Join Date: 1/30/2017
- Posts: 2
- Member Details
#155 padore

View User Profile

Send Message

Posted May 31, 2017
Rarity seems to have stopped working

error message

Date: 2017-05-31 22:21:40
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Rarity\Locales.lua line 1091:
   '=' expected near 'zone'
Debug:
   [C]: ?
Locals:

AddOns:
MoncaiCompare, v7.2.0
Swatter, v7.4.5714 (TasmanianThylacine)
ACP, v3.4.30
Altoholic, vr179
Babylonian, v5.1.DEV.332(/embedded)
BagBrother, v
Bagnon, v7.2.5
BattlePetDailyTamer, v2.1.4
BattlePetBreedID, vr148
BeanCounter, v7.4.5714 (TasmanianThylacine)
CloudyPetCollected, v1.7
Configator, v5.1.DEV.406(/embedded)
DataStore, vr63
DataStoreAchievements, vr45
DataStoreAgenda, vr25
DataStoreAuctions, vr48
DataStoreCharacters, vr39
DataStoreContainers, vr56
DataStoreCrafts, vr77
DataStoreCurrencies, vr35
DataStoreGarrisons, vr21
DataStoreInventory, vr49
DataStoreMails, vr49
DataStorePets, vr42
DataStoreQuests, vr41
DataStoreReputations, vr40
DataStoreSpells, vr30
DataStoreStats, vr29
DataStoreTalents, vr59
DBMCore, v7.2.7
DBMDefaultSkin, v
DBMStatusBarTimers, v
DebugLib, v5.1.DEV.337(/embedded)
Decursive, v2.7.5.2
Dominos, v7.2.2
DominosCast, v
DominosEncounter, v
DominosProgress, v
DominosRoll, v
FamilyFamiliarHelper, v1.0.4
FramesResized, v2.7.0-63
GTFO, v4.42.14
HandyNotes, vv1.4.13
HandyNotesDraenorTreasures, v1.20a
HandyNotesDungeonLocations, v1.20a
HandyNotesLegionMagePortals, v1.1
HandyNotesLegionRaresTreasures, v1.01b
HandyNotesLegionTreasures, v1
HandyNotesSpecialNPCsEtc, v1.1.1-Beta
HandyNotesTimelessIsleRareElites, v2.32
LibExtraTip, v5.12.DEV.423(/embedded)
Molinari, v70200.49-Release
MoveAnything, v16.1.9
Omen, v3.1.12
Paste, v1.4.10
PetTracker, v7.1.4
PetTrackerBreeds, v7.1.4
PetTrackerSwitcher, v7.1.4
PetTrackerUpgrades, v7.1.4
Postal, vv3.5.8
Prat30, vr1054
Prat30Libraries, v
Quartz, v3.3.4
RareScanner, v2.4.2
Rarity, v1.0
SlideBar, v7.4.5714 (TasmanianThylacine)
Stubby, v7.4.5714 (TasmanianThylacine)
TipHelper, v5.12.DEV.405(/embedded)
BlizRuntimeLib_enUS v7.2.0.70200 <none>
(ck=744)

Rollback Post to Revision RollBack
Allara
Curse Premium
- Location: San Francisco
- Join Date: 2/18/2005
- Posts: 358
- Member Details
#156 Allara

View User Profile

Send Message

Posted May 31, 2017
In reply to padore:

This is Curse's fault. And their source control is down, so I can't commit anything to fix it. Please contact Curse for further information.

Rollback Post to Revision RollBack
padore
Curse Premium
- Join Date: 1/30/2017
- Posts: 2
- Member Details
#157 padore

View User Profile

Send Message

Posted May 31, 2017
In reply to Allara:

Ahh, thank you for the quick response, love this addon and would hate not to have it anymore.

Rollback Post to Revision RollBack
Allara
Curse Premium
- Location: San Francisco
- Join Date: 2/18/2005
- Posts: 358
- Member Details
#158 Allara

View User Profile

Send Message

Posted May 31, 2017
In reply to padore:

Oh I should have added: install the latest "RELEASE" version (not "alpha") and it will work.

Rollback Post to Revision RollBack
Faffers
- Join Date: 4/26/2017
- Posts: 1
- Member Details
#141 Faffers

View User Profile

Send Message

Posted Apr 26, 2017
I love this add on but I am having a slight issue. My attempts to get a pet to drop is not showing in my chat when I loot a mob. I have found that I should be able to shift click on the pet in the interface but this is greyed out and won't work. Am I doing something wrong? Please help 😊 Thanks

Rollback Post to Revision RollBack
malfunktionv2
- Join Date: 5/31/2011
- Posts: 2
- Member Details
#138 malfunktionv2

View User Profile

Send Message

Posted Feb 9, 2017
Trying to track my my fishing attempts for Shard of Darkness for the Ashbringer skin, but its not tracking. Can you tell me what I'm doing wrong?

AV4xXlReU2l0ZW1zXlReTjFeVF5Tem9uZXNeVF5OMV5TMjheTjJeUzEzOV50XlN0eXBlXlNJVEVNXlNtZXRob2ReU0ZJU0hJTkdeU2xhc3RBdHRlbXB0c15OMF5TZGlzYWJsZUZvckNsYXNzXlReU1BBTEFESU5eQl50XlNpdGVtSWReTjEzOTYyNF5TbmFtZV5TMTM5NjI0XlNleHBvcnReQl5TY2hhbmNlXk4xMDAwXlNpbnN0YW5jZURpZmZpY3VsdGllc15UXk4wXmJedF5TYXR0ZW1wdHNeTjRedF50XlNzaWduYXR1cmVeU1JGSTJQRDRqT2pKME5udGdJbmMvWkE9PV5TYnVpbGReTjU4NV50Xl4=

Rollback Post to Revision RollBack
Allara
Curse Premium
- Location: San Francisco
- Join Date: 2/18/2005
- Posts: 358
- Member Details
#139 Allara

View User Profile

Send Message

Posted Feb 10, 2017
I no longer have an active WoW account, so I can't import your string. I can try to help if you describe what you did, or another user can help.

Rollback Post to Revision RollBack

Cakechart

Curse Premium

Join Date: 9/7/2012
Posts: 7
Member Details

#140 Posted Apr 8, 2017

In reply to malfunktionv2:

Probably way too late, but... for posterity:

AzlxA/8CahRYjxTahaJeI0Vmo5KbKsgvFdRtKjuh9pLdkOwXoZ9IFcMov1HkNEpDUdBgVGo4qg6iUJdVHVM6J1iIVGopUspipMJyFXqsAk8VyyTPpUxEqpqKZLJIpoOLSMF5pKRnVF0XkY0q2gaxGVKfRdRHpJKvSIlpQuNUGolU6RtitAjGI6U6KVK3UHFN1D0UshIpai1S0WGp1orSsPCuiRKuLEpDIxPqmyjh1dDyDf6ISuRmyNWTk56ro1JNoAFa+dekKRoOadxDAlNKc6aH3jSmS8PVGzAGeMdDEzYNqrvXTEI/phK5mdCJ3PT7kSbUt6Zh4V06Jbw+IBU1wLrXSfZGn31GFkGIvyU0x19NqsM3UcJlS8xbEKUB1r3OjFxPyMa6m0MMJTQnRk0HeMdDE64sEC5bYutXlAZY98J7r2euCpoO8I6HJrxmAuGyJVYVRWmAda/zWvShCtlcFi/iheZE03SAdzw04VhBIFy2xLytKA2w7nVmxHxEvIV7c8hLhOZEoun/Au94aMJeIFy2xKqIKA2w7oXL58i8WyGEEELQdIB3PDThHK9AuGyJVV1RGmDd67yeBDMLt0goYis0J5qmA7zjoQmvlUC4bIl5y6I0wLrXma8ZQW4hGyNBSBCaE72mA7zjoQlHIhAuW2LeEFEaYN0L+/XMlZEQQgiBZE0HeMdDE64sEC5bYmUlSgOse53ExyWRmG1YJO4KzYlZ0wHe8dCENwuEy5aYNyJKA6x7YYQgzDeYmZnZek0HeMdDE84mEC5bYlVZlAZY9zpzrS+E+K0bzCNXaE40TQd4x0MT9rUCgeYgoaMOXrjMTPO080xHEN2aDvCOhya8SDaBQNPYZFSHpONraDvTxZB+ZEAPA5oNoyA5jTo4TCdjRow0dCSxXCnhTIhAAg==

malfunktionv2
- Join Date: 5/31/2011
- Posts: 2
- Member Details
#142 malfunktionv2

View User Profile

Send Message

Posted May 21, 2017
In reply to Cakechart:

Just tried this import but Rarity kicked it back as invalid

Rollback Post to Revision RollBack
Cakechart
Curse Premium
- Join Date: 9/7/2012
- Posts: 7
- Member Details
#143 Cakechart

View User Profile

Send Message

Posted May 23, 2017
In reply to malfunktionv2:

Indeed! In my naivety I (wrongly) assumed that importing would be straight-forward. However, after some serious investigation into the intricacies of the import/export encoding, I can safely say that the feature is either broken, or can be considered as having a huge conceptual flaw or two at the very least.

In this case, you can't import the string because it stores the custom item ID from MY local copy (which is 25), and then fails to validate the string because it's not the first item (index 1).

I'm not sure what to make of it, but I doubt it will be changed/fixed for obvious reasons :P Anyway, as for your problem: Since I don't want to delete all my custom items, I can offer the following hack (it's the best I can do here):

1. Go to Interface\Addons\Rarity_Options\
2. Create a backup of Options.lua, then open it and
3. On line 1085, replace the entire line, that is

if type(e) == "table" and e.items and type(e.items) == "table" and #e.items > 0 and e.build and tonumber(e.build) > 0 and e.signature and e.signature == IMPORTEXPORT_SIGNATURE then

with

if type(e) == "table" and e.items and type(e.items) == "table" and (#e.items > 0 or e.items[25]) and e.build and tonumber(e.build) > 0 and e.signature and e.signature == IMPORTEXPORT_SIGNATURE then

This will allow my export string to be recognized as valid, and have no adverse effects, but you should still change it back afterwards just to be sure (or don't).

Now, export this string:

AV4xXlReU2l0ZW1zXlReTjI1XlReU3pvbmVzXlReTjFeU1dlc3Rlcm5+YFBsYWd1ZWxhbmRzXnReU2V4cG9ydF5CXlNtZXRob2ReU0ZJU0hJTkdeU2NoYW5jZV5OMjAwMF5TbmFtZV5TU2hhcmR+YG9mfmBEYXJrbmVzc15TdHlwZV5TSVRFTV5TaXRlbUlkXk4xMzk2MjRedF50XlNzaWduYXR1cmVeU1JGSTJQRDRqT2pKME5udGdJbmMvWkE9PV5TYnVpbGReTjU3N150Xl4=

It's a different one because I removed all unnecessary data (my attempts etc), which also makes it a lot shorter.
Rollback Post to Revision RollBack
Cakechart
Curse Premium
- Join Date: 9/7/2012
- Posts: 7
- Member Details
#144 Cakechart

View User Profile

Send Message

Posted May 23, 2017
In reply to malfunktionv2:

Oh, and an addendum to solve your original problem:

Your string differs from mine in that it uses zone IDs, and restricts it to only consider Paladins. I don't know if that makes much of a difference, but since you're extremely unlikely to go fishing anywhere else in Western Plaguelands, with any character, I just set it to be more forgiving.

That said, your map IDs are wrong. /dump GetMapNameByID(28) returns "Searing Gorge", and 139 is entirely invalid. You probably took them from wowhead, but their zone IDs are different from those used by the game. Western Plaguelands is actually 23, and Eastern Plaguelands has 22 - although it only drops on the western shore so I'd remove that.

Additionally, the chance is apparently closer to 1/2000 than 1/1000. I arrived at this conclusion from wowhead's aggregated comment data, which averaged out to some 1.9k attempts (for what it's worth) :)

In retrospect, this will be much easier for you to change than the LUA file + import. If it still doesn't work, you can always fall back to using that option.

Last edited by Cakechart: May 23, 2017

Rollback Post to Revision RollBack
Allara
Curse Premium
- Location: San Francisco
- Join Date: 2/18/2005
- Posts: 358
- Member Details
#145 Allara

View User Profile

Send Message

Posted May 29, 2017
In reply to Cakechart:

Hey Cakechart, if you see this. I'm going to try to come back at least with a Starter Edition account to get Rarity working in 7.2. I saw your comments about the Import/Export system being fundamentally broken and I think I sort of understand what you're saying. Based on your fix it looks like yet another failure of the # operator in Lua. This is an easy fix. Rarity doesn't actually care what table index anything is at in the import.

Rollback Post to Revision RollBack
Cakechart
Curse Premium
- Join Date: 9/7/2012
- Posts: 7
- Member Details
#146 Cakechart

View User Profile

Send Message

Posted May 30, 2017
In reply to Allara:

I'm glad to hear it. Yes, it is not a difficult thing to fix, what I proposed was merely a workaround for this particular import string, because I didn't want to make things even more complicated [for other users]. I did notice the index matters little and so I'd simply replace that check with a version that doesn't break if indices are missing, but still returns whether or not the table is empty.

That isn't exactly a failure, I believe it's "working as intended". From the Lua manual:

The length of a table t is defined to be any integer index n such that t[n] is not nil and t[n+1] is nil; moreover, if t[1] is nil, n can be zero. For a regular array, with non-nil values from 1 to a given n, its length is exactly that n, the index of its last value. If the array has "holes" (that is, nil values between other non-nil values), then #t can be any of the indices that directly precedes a nil value (that is, it may consider any such nil value as the end of the array).

That is pretty much all that went wrong; there are "holes" in it and so it won't count the entries correctly. With "fundamentally broken" I meant that it generally won't work, only in the special case of exporting N entries from the start (where N can be all of them, if none are missing "in between").

Disclaimer: I haven't tested this with different types of exports, but it's what I got from looking at the respective lines in the code.

Last edited by Cakechart: May 30, 2017

Rollback Post to Revision RollBack
Allara
Curse Premium
- Location: San Francisco
- Join Date: 2/18/2005
- Posts: 358
- Member Details
#147 Allara

View User Profile

Send Message

Posted May 30, 2017
In reply to Cakechart:

Yeah basically what I mean is # is generally useless. It would be useful if it returned the number of things in an array. I'm not sure why it even exists in its current form. I try never to use it.

I did test the feature as well as I could on my own and it generally works. I'll just change it to iterate using pairs and count that way (which is what I usually do).

Rollback Post to Revision RollBack
Cakechart
Curse Premium
- Join Date: 9/7/2012
- Posts: 7
- Member Details
#148 Cakechart

View User Profile

Send Message

Posted May 30, 2017
In reply to Allara:

From how I understand it, that isn't quite right. In this case it doesn't matter, but it is "generally" much faster than iterating if all you want to do is count a regular, properly numbered array. luaH_getn (= #) operates in constant time while i/pairs obviously do not (as they iterate over each element = linear time), so I'd always use it whenever possible even if I highly doubt someone wants to import millions of entries into Rarity :P

That performance was apparently achieved by highly optimizing the algorithm for the kinds of tables Lua uses as well as the most common use case where efficient counting would be of interest (sequences, table length of 2^x). I'd suspect counting other types of arrays isn't possible with this approach without giving up that advantage.

As for the import feature, you could simply table.insert / tinsert the entries. The table with key [25] would become [1] in my example, discarding the key Rarity doesn't care about anyway and continue to use # with no drawbacks, as you already iterate through them before compressing and serializing them:

e.items[itemkey] = item

in line 1224 could become

table.insert(e.items, item)

or, in fact,

e.items[#e.items+1] = item

- which is faster, although not by entire orders of magnitude. This way, the validation shouldn't need any changes at all.

And there we have another example for using # that justifies its current form. If it wasn't as fast, using this shortcut would be a terrible idea :)
Last edited by Cakechart: May 30, 2017

Rollback Post to Revision RollBack
Allara
Curse Premium
- Location: San Francisco
- Join Date: 2/18/2005
- Posts: 358
- Member Details
#149 Allara

View User Profile

Send Message

Posted May 30, 2017
In reply to Cakechart:

r589 should fix that validation issue.

I don't really care to continue debating Lua at the moment :), but this isn't code that needs to be performant. And you'll see I in fact did an early exit on the iterator, so it only goes through one item anyway. In my world of WoW add-ons, the number of consecutively-numbered tables I utilize is close to zero, so the # operator is pretty useless for me. Also it is far less risky to change the validator than to change the exporter in my opinion.

We never iterate on tables in any performant sections of Rarity. It's all hash lookups using the indexer. In fact I put a lot of work into ensuring this was the case.

Anyways, I wasn't able to find any other issues with Rarity in 7.2. I'm aware that all the Calendar functions are deprecated, but it's easier to wait until they actually go away before fixing them. Anything else I missed?

Rollback Post to Revision RollBack
Cakechart
Curse Premium
- Join Date: 9/7/2012
- Posts: 7
- Member Details
#150 Cakechart

View User Profile

Send Message

Posted May 31, 2017
In reply to Allara:

Oh, yeah. As I said, it doesn't matter in this case but I figured it's not ENTIRELY useless :) Sorry if I got carried away a little.

That proposed change doesn't change the workings at all, as it merely rewrites the index to always be in order. In any event, any solution is fine for this minor issue.

Otherwise, there's only a few things that I can think of, gathered from the comments:

7.2 mounts from the Paragon caches aren't tracked

Midnight's Eternal Reins (Return to Karazhan) is missing (?)

The Group Finder API (Search() as used by the checkbox) is now protected after the Anti-WQGF hotfix

For the most part, everything is still working as expected. Thanks for all the work you put into this addon, by the way!
Rollback Post to Revision RollBack
Allara
Curse Premium
- Location: San Francisco
- Join Date: 2/18/2005
- Posts: 358
- Member Details
#151 Allara

View User Profile

Send Message

Posted May 31, 2017
In reply to Cakechart:

Oh yeah forgot about group finder. When I put that feature in I knew it was only a matter of time before it caused server stress. Took longer than I thought it would haha!

Thank you for your help. :)

(Oh and the other problem with changing the exporter as the fix means any existing strings floating around still wouldn't work. So I preferred to fix it so those strings started working.)

Rollback Post to Revision RollBack
Cakechart
Curse Premium
- Join Date: 9/7/2012
- Posts: 7
- Member Details
#152 Cakechart

View User Profile

Send Message

Posted May 31, 2017
In reply to Allara:

I don't think many people were using that feature, at least not enough to prompt a hotfix. From what I understand World Quest Group Finder was spamming the servers with its various features and that did indeed cause problems for some players, seeing how it is widely used and probably more taxing than Rarity. The auto-refreshing checkbox was nice, but it's probably not a huge loss to remove it.

There's an issue apparent in the newest alpha release, which is caused by the packager; handle-unlocalized doesn't default to "ignore" even though the documentation says it should, according to this post. That's why people are reporting Lua errors on Curse already.

(Good point, indeed.)

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.