WowAce

I noticed that a nameplate will still show red for tapped mobs even though unit frames show it tapped (gray). When questing in particular I don't want to engage mobs tapped by other faction if I don't have to, however it's a bit slow to target each mob to see if it's tapped. I think if a unit is tapped, that should override threat colors unless you are tanking it. Basically I think that behavior should be

tapped and not tanking - gray
tapped but managed to pull aggro - red (dps) green (tank)

So the color should warn you that mob is ON You still but if it's not on you then it should definitely be gray and not the "non threat" color.

Give it a try with this updated function in TidyPlates_Threat/Functions/healthbatcolor.lua

local function GetThreatColor(unit, style)
	local db = TidyPlatesThreat.db.profile
	local c
	local isThreatColored = false

	if db.threat.ON and db.threat.useHPColor and InCombatLockdown() and (style == "dps" or style == "tank") then
		local nonCombatOverride = not (db.threat.toggle.nonCombat or unit.isInCombat)
		local tappedOverride = unit.isTapped and unit.threatValue < 3
		if nonCombatOverride or tappedOverride then
			c = GetClassColor(unit)
		else
			local threatSituation = unit.threatSituation
			if unit.threatValue < 3 and TidyPlatesWidgets.IsEnemyTanked(unit) and style == "tank" then
				threatSituation = "OTHERTANK"
			end
			c = db.settings[style].threatcolor[threatSituation]
			isThreatColored = true
		end
	else
		c = GetClassColor(unit)
	end

	return c, isThreatColored
end

I'm actually thinking the tapped color should be on all the time, even when you have aggro. The aggro would stil be visible from scale, alpha and border modifiers.

Scale is a valid point.

I found there was already an option for this in Threat System -> General Settings -> Show Tapped Threat

Sorry late reply

I checked and that was ALREADY checked so it must be broken somewhere.

Checked means it uses threat settings for tapped targets. So you want to uncheck it.

I tired, both it didn't do anything, the checkbox is useless. it ALWAYS showed threat color either way on tapped units.

it's possible the wrong tapped API is being used. I didn't actually check code.

EDIT I looked voer threatplates code and honestly it has options for tapped but literally uses them no where anywhere in addon. nor does it ever check anywhere in mod if it's tapped (or use tidyplates core .istapped on a unit)

basically the options don't do a thing because it doesn't actually support tapped units yet from what I can see.

go ahead and search ENTIRE mod for "TAPPED" and you'll see that it has options all over place, and even has a reference for it as well as color assignment for it, and even has a tapped return in GetGeneral...but that's all you'll find. nothing to actually set color or even check the tapped checkbox options. I'm going ot guess that kat never actually finished rewriting it.

The unit variable comes from TidyPlates already set with various information. It has unit.reaction and unit.isTapped.

My problem is that I play on PVP server. And after launch I can't find enemy players on beta / PTR realms to test.

Yeah I know unit.isTapped is set in tidyplates core

i'm saying i searched EVERY file of threat and it's never once checked/referenced anywhere. It literally has options that are hooked up to NOTHING. it's not implemented yet

It uses unit.reaction in Styles.lua.

And then based on threat.toggle['Tapped'] it sets style to normal or tank/dps. Theoretically it should work.

Something tells me using unit.reaction in legion isn't going to work. tapped is kind of special now. all mobs are now shared tap to faction except quest mobs which are shared tap for all. Probably have to use .istapped which uses proper check in tidyplates core.

That's what I wanted to test for the last 2 days, but didn't get a chance. Could you log on the beta realm for a quick test? my tag is Chip#2344

wish I could but my beta isn't even patched up right now.I pretty much abandoned it soon as they ended raid testing and pushed pre patch. I'll update it when i go to bed (slow internet) so it's ready for tomorrow.

should be fixed in v1.17

Make sure to uncheck Show Tapped Threat so threat colors won't override it during combat.

plz fix! the hp bars the enemy target don't show color class! in 1.16 its will be ik working! 1.17 dont working! I download 1.16 to play