PitBull Unit Frames 4.0

957 - [Patch] Basic boss frames.

This should enable PitBull to create frames for bosses, just like it does for target and focus. I haven't noticed any bugs with it so far.

In PitBull4/Utils.lua . . .

Below this:

	local valid_singleton_unit_ids = {
		player = true,
		pet = true,
		mouseover = true,
		focus = true,
		target = true,
	}
	setmetatable(valid_singleton_unit_ids, target_same_mt)

Add this:

	for i = 1, MAX_BOSS_FRAMES do
		valid_singleton_unit_ids["boss" .. i] = true
	end

And below this:

	local classifications = {
		player = L["Player"],
		target = L["Target"],
		pet = L["Player's pet"],
		party = L["Party"],
		party_sing = L["Party"],
		partypet = L["Party pets"],
		partypet_sing = L["Party pet"],
		raid = L["Raid"],
		raid_sing = L["Raid"],
		raidpet = L["Raid pets"],
		raidpet_sing = L["Raid pet"],
		mouseover = L["Mouse-over"],
		focus = L["Focus"],
		maintank = L["Main tanks"],
		maintank_sing = L["Main tank"],
		mainassist = L["Main assists"],
		mainassist_sing = L["Main assist"]
	}

Add this:

	for i = 1, MAX_BOSS_FRAMES do
		classifications["boss" .. i] = L["Boss"] .. " " .. i
	end

In PitBull4/Main.lua . . .

Below this:

for i = 1, MAX_PARTY_MEMBERS do
	NORMAL_UNITS[#NORMAL_UNITS+1] = "party" .. i
	NORMAL_UNITS[#NORMAL_UNITS+1] = "partypet" .. i
end
for i = 1, MAX_RAID_MEMBERS do
	NORMAL_UNITS[#NORMAL_UNITS+1] = "raid" .. i
end

Add this:

for i = 1, MAX_BOSS_FRAMES do
	SINGLETON_CLASSIFICATIONS[#SINGLETON_CLASSIFICATIONS + 1] = "boss" .. i
	NORMAL_UNITS[#NORMAL_UNITS+1] = "boss" .. i
end

In PitBull4_LuaTexts/ScriptEnv.lua . . .

Below this:

local UnitToLocale = {player = L["Player"], target = L["Target"], pet = L["%s's pet"]:format(L["Player"]), focus = L["Focus"], mouseover = L["Mouse-over"]}

Add this:

for i = 1, MAX_BOSS_FRAMES do
	UnitToLocale["boss" .. i] = L["Boss"] .. " " .. i
end
  • Screen_shot_2011-07-03_at_9.48.06_PM.png
    Screenshot.
User When Change
Shefki Jul 04, 2011 at 19:39 UTC
cbrown11 Jul 04, 2011 at 04:29 UTC Changed description:
- This should enable PitBull to create frames for bosses, just like it does for target and focus.
+ This should enable PitBull to create frames for bosses, just like it does for target and focus.  I haven't noticed any bugs with it so far.
  **In PitBull4/Utils.lua . . .**
cbrown11 Jul 04, 2011 at 04:24 UTC Changed description type from Plain Text to WikiCreole
cbrown11 Jul 04, 2011 at 04:22 UTC

Added attachment Screen_shot_2011-07-03_at_9.48.06_PM.png

cbrown11 Jul 04, 2011 at 04:22 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 6 comments
  • Avatar of Linaeri Linaeri Dec 10, 2012 at 11:45 UTC - 0 likes

    Interesting hack attempt to include boss frames. Surely there is a way though to have it move and edit the frames as a whole instead of individually? Must be doable since the mod doesn't require you to move around 40 different frames for each player in a 40 man raid.

  • Avatar of tordenflesk tordenflesk Dec 01, 2012 at 01:14 UTC - 0 likes

    Anyone have a fix for the background of the blizz frames showing up with these in 5.1?

    Last edited Dec 08, 2012 by tordenflesk
  • Avatar of icekold icekold Jan 10, 2012 at 03:00 UTC - 0 likes

    Would it be possible for these frames to show up only when an encounter has more than 1 boss entity? Currently even if it is a solo boss (Ultraxion, zon'az etc) the boss frame will show up (unlike the blizzard default frames which only show up when a boss encounter has multiple boss level monsters)

  • Avatar of RVCA18 RVCA18 Jul 17, 2011 at 07:39 UTC - 0 likes

    Thanks cbrown11. I'd rather use your patch and wait until they decide to add this feature in. I take it from the creators response it's either not coming or a long ways away, which I'm cool with because I love this addon and your patch seems to be working out well.

    I'd rather not waste addon memory downloading another mod just to show 4 frames.

    Much appreciated!

  • Avatar of cbrown11 cbrown11 Jul 04, 2011 at 22:34 UTC - 0 likes

    I didn't think you guys would. There's certainly a cleaner way to do it. :) This was partly just in case others wanted to do it themselves since this feature is so long overdue (and the reason a lot of my friends don't use PitBull). Happy coding.

  • Avatar of Shefki Shefki Jul 04, 2011 at 19:39 UTC - 0 likes

    Declining. We won't be implementing it this way.

  • 6 comments

Facts

Last updated
Mar 30, 2012
Reported
Jul 04, 2011
Status
Declined - We decided not to take action on this ticket.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees