628 - remove oRA3-MT-list
The ora3-MT-list keeps a list of "favorite"-MTs (who are not necessarily actual MTs).
So suppose there is some feral that only tanks in heroic-mode, but does damage on normal mode (just an example).
He appears in the oRA3-"favorite"-MT-list (the shield-icon is disabled), but not in the blizzard-MT-list.
So since oRA3 sets blizzard-MTs anyway I suggest to remove the following lines
if oRA3 then main_tanks = oRA3:GetSortedTanks()
from GroupHeader.lua
| User | When | Change |
|---|---|---|
| Shefki | Mon, 26 Oct 2009 20:27:48 | Changed type from Defect to Enhancement |
| profalbert | Mon, 26 Oct 2009 20:04:20 | Create |
- 4 comments
- 4 comments
Facts
- Last updated on
- 26 Oct 2009
- Reported on
- 26 Oct 2009
- Status
- New - Issue has not had initial review yet.
- Type
- Enhancement - A change which is intended to better the project in some way
- Priority
- Medium - Normal priority.
Reported by
Possible assignees
-
- Manager
- Author
-
- Author
- Maintainer
-
- Author
-
- Ticket Manager
-
- Documenter
- Artist
- #4
jokeyrhyme Fri, 30 Oct 2009 06:39:34I suppose the same could be said for any feature really (ones I've personally suggest in particular, hehe), but does supporting non-Blizzard Main Tanks present significant value?
I've used a few of those raid management addons, but I uninstall them after a few nights and just go back to setting Main Tanks the Blizzard-endorsed way. Any reason why we couldn't just lean on those guys to use the Blizzard settings as their backend instead of something new and weird?
- #3
profalbert Thu, 29 Oct 2009 18:26:05Ok, I see that removing the Code is not a solution. What I'd like to see is some option to hide an MT if he is not set as blizzard-MT.
- #2
Shefki Mon, 26 Oct 2009 20:27:48And this is not a defect. It's a deliberate design decision.
- #1
Shefki Mon, 26 Oct 2009 20:27:12It only optionally sets those MTs, no everyone using oRA3 uses it that way. Not using oRA3:GetSortedTanks() also means that you can't adjust the order of the tanks. The situation with main tanks has probably reached the point that we need some configuration rather than just automagically deciding which list to use. But I typically use oRA3 now to adjust my tank list locally to reorder the list to suit my own needs and even adding players that suit my needs.