WowAce.com

PitBull Unit Frames 4.0

475 - Health bar error

What steps will reproduce the problem?
1. target something
2.
3.

What is the expected output? What do you see instead?
screenshot:
http://img375.imageshack.us/img375/8646/wowscrnshot070109131012z.jpg

What version of the product are you using?
Newest version as per curse client (4.0.0Beta1)

Do you have an error log of what happened?

Please provide any additional information below.

User When Change
cremor Wed, 29 Jul 2009 15:38:52 Changed status from Waiting to Replied
Shefki Tue, 28 Jul 2009 05:37:57 Changed status from Replied to Waiting
sfan27 Mon, 27 Jul 2009 17:59:43 Changed status from Waiting to Replied
Shefki Sun, 26 Jul 2009 04:27:32 Changed status from Replied to Waiting
esullivan Thu, 09 Jul 2009 21:10:10 Changed status from Waiting to Replied
Shefki Thu, 09 Jul 2009 20:32:18 Changed status from Replied to Waiting
esullivan Thu, 09 Jul 2009 13:11:29 Changed status from Waiting to Replied
Shefki Thu, 09 Jul 2009 07:17:48 Changed status from Replied to Waiting
sfan27 Thu, 09 Jul 2009 06:48:35 Changed status from Waiting to Replied
Shefki Wed, 08 Jul 2009 22:54:56 Changed status from Replied to Waiting
esullivan Fri, 03 Jul 2009 12:56:26 Changed status from Waiting to Replied
Shefki Fri, 03 Jul 2009 08:17:52 Changed status from New to Waiting
esullivan Wed, 01 Jul 2009 18:16:25 Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of esullivan esullivan Thu, 09 Jul 2009 21:10:10

    OK I loged in and turned into test mode and clicked around on people in ORG. I DID NOT receive any errors, but I am at work and only had about 30 secs to try.

    Based on what I sent before, can you think of a good way for me to reproduce this for you? Clicking on a class or NPC or something?

  • Avatar of Shefki Shefki Thu, 09 Jul 2009 20:31:56

    That stuff is just the header for the diff. You can ignore it.

  • Avatar of esullivan esullivan Thu, 09 Jul 2009 20:19:51 
      function PitBull4_HealthBar:GetValue(frame) -	return UnitHealth(frame.unit) / UnitHealthMax(frame.unit) +	local success,cur = pcall(UnitHealth, frame.unit) +	if not success then +		geterrorhandler()("frame = "..frame:GetName().." unit = "..tostring(frame.unit).."\n"..cur) +	end +	return cur / UnitHealthMax(frame.unit)  end>>
 function PitBull4_HealthBar:GetValue(frame)
-	return UnitHealth(frame.unit) / UnitHealthMax(frame.unit)
+	local success,cur = pcall(UnitHealth, frame.unit)
+	if not success then
+		geterrorhandler()("frame = "..frame:GetName().." unit = "..tostring(frame.unit).."\n"..cur)
+	end
+	return cur / UnitHealthMax(frame.unit)
 end

    Ok I saw this in the lua, I removed the line with the "-" and added the lines with the "+".

    I could not find this in the LUA code at all

    diff --git a/Modules/HealthBar/HealthBar.lua b/Modules/HealthBar/HealthBar.lua
index 37dcf9b..1cdd92d 100644
--- a/Modules/HealthBar/HealthBar.lua
+++ b/Modules/HealthBar/HealthBar.lua
@@ -79,7 +79,11 @@ timerFrame:SetScript("OnUpdate", function()
 end)
  • Avatar of Shefki Shefki Thu, 09 Jul 2009 07:17:17

    Yeah the code shouldn't ever get to that point when the unit isn't set. So I'm trying to figure out how it's happening. I could easily make the error go away. The patch thing I showed below actually captures some additional information that's not in the debustack so I can figure it out.

  • Avatar of sfan27 sfan27 Thu, 09 Jul 2009 06:48:34

    I've had this bug as well. It produces a lua error, but doesn't actually cause any noticeable issues.

    The bug is not frequent, but isn't rare either.

    [2009/07/09 11:41:43-770-x1]: PitBull4-v4.0.0-beta1-42-g2ac29f8\Modules\HealthBar\HealthBar.lua:82: Usage: UnitHealth("unit")
PitBull4-v4.0.0-beta1-42-g2ac29f8\Modules\HealthBar\HealthBar.lua:82: in function `GetValue'
PitBull4-v4.0.0-beta1-42-g2ac29f8\ModuleHandling\BarModule.lua:38: in function <...terface\AddOns\PitBull4\ModuleHandling\BarModule.lua:32>
PitBull4-v4.0.0-beta1-42-g2ac29f8\ModuleHandling\BarModule.lua:209: in function `UpdateFrame'
PitBull4-v4.0.0-beta1-42-g2ac29f8\ModuleHandling\Module.lua:287: in function `Update'
PitBull4-v4.0.0-beta1-42-g2ac29f8\UnitFrame.lua:606: in function `Update'
PitBull4-v4.0.0-beta1-42-g2ac29f8\UnitFrame.lua:632: in function `UpdateGUID'
PitBull4-v4.0.0-beta1-42-g2ac29f8\Main.lua:1257: in function `CheckGUIDForUnitID'
PitBull4-v4.0.0-beta1-42-g2ac29f8\Main.lua:1264: in function `?'
CallbackHandler-1.0-3:146: in function <...oot\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
<string>:"safecall Dispatcher[2]":4: in function <[string "safecall Dispatcher[2]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[2]":13: in function `?'
CallbackHandler-1.0-3:91: in function `Fire'
AceEvent-3.0-3 (AutoText):119: in function <...e\AddOns\AutoText\libs\AceEvent-3.0\AceEvent-3.0.lua:118>

    and another:

    [2009/07/09 11:49:01-770-x1]: PitBull4-v4.0.0-beta1-42-g2ac29f8\Modules\HealthBar\HealthBar.lua:82: Usage: UnitHealth("unit")
PitBull4-v4.0.0-beta1-42-g2ac29f8\Modules\HealthBar\HealthBar.lua:82: in function `GetValue'
PitBull4-v4.0.0-beta1-42-g2ac29f8\ModuleHandling\BarModule.lua:38: in function <...terface\AddOns\PitBull4\ModuleHandling\BarModule.lua:32>
PitBull4-v4.0.0-beta1-42-g2ac29f8\ModuleHandling\BarModule.lua:209: in function `UpdateFrame'
PitBull4-v4.0.0-beta1-42-g2ac29f8\ModuleHandling\Module.lua:287: in function `Update'
PitBull4-v4.0.0-beta1-42-g2ac29f8\UnitFrame.lua:606: in function `Update'
PitBull4-v4.0.0-beta1-42-g2ac29f8\GroupHeader.lua:1000: in function <Interface\AddOns\PitBull4\GroupHeader.lua:995>
(tail call): ?:
<in C code>: ?
<string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?:
AceTimer-3.0-5 (BetterInbox):160: in function <...ddOns\BetterInbox\libs\AceTimer-3.0\AceTimer-3.0.lua:132>

    For the first, I was just flying south towards the Citadel daily, with 3 other people in my group, but nobody was doing anything.
    For the second, I was literally floating still, not in a party, writing this post.

  • Avatar of Shefki Shefki Wed, 08 Jul 2009 22:53:26

    Can you apply this patch to your Modules/HealthBar/HealthBar.lua:

    diff --git a/Modules/HealthBar/HealthBar.lua b/Modules/HealthBar/HealthBar.lua
index 37dcf9b..1cdd92d 100644
--- a/Modules/HealthBar/HealthBar.lua
+++ b/Modules/HealthBar/HealthBar.lua
@@ -79,7 +79,11 @@ timerFrame:SetScript("OnUpdate", function()
 end)
 
 function PitBull4_HealthBar:GetValue(frame)
-	return UnitHealth(frame.unit) / UnitHealthMax(frame.unit)
+	local success,cur = pcall(UnitHealth, frame.unit)
+	if not success then
+		geterrorhandler()("frame = "..frame:GetName().." unit = "..tostring(frame.unit).."\n"..cur)
+	end
+	return cur / UnitHealthMax(frame.unit)
 end
 
 function PitBull4_HealthBar:GetExampleValue(frame)

    Lines starting with space are context and stay the same. Lines starting with - are removed. Lines starting with + are added. Please provide the errors that generates.

  • Avatar of esullivan esullivan Wed, 08 Jul 2009 21:03:30

    Does that help?

  • Avatar of esullivan esullivan Sat, 04 Jul 2009 21:51:12

    [2009/07/04 16:48:11-2-x3]: PitBull4-v4.0.0-beta1\Modules\HealthBar\HealthBar.lua:82: Usage: UnitHealth("unit") PitBull4-v4.0.0-beta1\Modules\HealthBar\HealthBar.lua:82: in function `GetValue' PitBull4-v4.0.0-beta1\ModuleHandling\BarModule.lua:38: in function <...terface\AddOns\PitBull4\ModuleHandling\BarModule.lua:32> PitBull4-v4.0.0-beta1\ModuleHandling\BarModule.lua:209: in function `UpdateFrame' PitBull4-v4.0.0-beta1\ModuleHandling\Module.lua:287: in function `Update' PitBull4-v4.0.0-beta1\UnitFrame.lua:600: in function `Update' PitBull4-v4.0.0-beta1\UnitFrame.lua:626: in function `UpdateGUID' PitBull4-v4.0.0-beta1\Main.lua:1244: in function `CheckGUIDForUnitID' PitBull4-v4.0.0-beta1\Main.lua:1249: in function `?' CallbackHandler-1.0-3:146: in function <...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:146> <string>:"safecall Dispatcher[1]":4: in function <[string "safecall Dispatcher[1]"]:4> <in C code>: ? <string>:"safecall Dispatcher[1]":13: in function `?' CallbackHandler-1.0-3:91: in function `Fire' AceEvent-3.0-3 (Bartender4):119: in function <...AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:118> <in C code>: in function `CameraOrSelectOrMoveStop' <string>:"CAMERAORSELECTORMOVE":4: in function <[string "CAMERAORSELECTORMOVE"]:1>

    -

  • Avatar of esullivan esullivan Sat, 04 Jul 2009 21:50:36

    [2009/07/04 16:48:03-2-x1]: PitBull4-v4.0.0-beta1\Modules\HealthBar\HealthBar.lua:82: Usage: UnitHealth("unit") PitBull4-v4.0.0-beta1\Modules\HealthBar\HealthBar.lua:82: in function `GetValue' PitBull4-v4.0.0-beta1\ModuleHandling\BarModule.lua:38: in function <...terface\AddOns\PitBull4\ModuleHandling\BarModule.lua:32> PitBull4-v4.0.0-beta1\ModuleHandling\BarModule.lua:209: in function `UpdateFrame' PitBull4-v4.0.0-beta1\ModuleHandling\Module.lua:287: in function `Update' PitBull4-v4.0.0-beta1\UnitFrame.lua:600: in function `Update' PitBull4-v4.0.0-beta1\GroupHeader.lua:962: in function `func' PitBull4-v4.0.0-beta1\Main.lua:1431: in function <Interface\AddOns\PitBull4\Main.lua:1425> (tail call): ?: PitBull4-v4.0.0-beta1\Options\ConfigMode.lua:88: in function `RecheckConfigMode' PitBull4-v4.0.0-beta1\GroupHeader.lua:515: in function <Interface\AddOns\PitBull4\GroupHeader.lua:504> <in C code>: in function `SecureGroupHeader_Update' PitBull4-v4.0.0-beta1\GroupHeader.lua:483: in function `func' PitBull4-v4.0.0-beta1\Main.lua:1431: in function <Interface\AddOns\PitBull4\Main.lua:1425> (tail call): ?: PitBull4-v4.0.0-beta1\Main.lua:1388: in function `?' CallbackHandler-1.0-3:146: in function <...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:146> <string>:"safecall Dispatcher[1]":4: in function <[string "safecall Dispatcher[1]"]:4> <in C code>: ? <string>:"safecall Dispatcher[1]":13: in function `?' CallbackHandler-1.0-3:91: in function `Fire' AceEvent-3.0-3 (Bartender4):119: in function <...AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:118>

    -

  • Avatar of esullivan esullivan Fri, 03 Jul 2009 18:51:39

    I just installed bugsack, I will post again if I can get it to come up again.

Facts

Last updated on
29 Jul 2009
Reported on
01 Jul 2009
Status
Replied - Someone has replied after waiting for more information.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.

Reported by

Possible assignees

Votes (Total: +6, Average: +3.0)