PitBull Unit Frames 4.0

475 - Health bar error

What steps will reproduce the problem?
1. target something
2.
3.

What is the expected output? What do you see instead?
screenshot:
http://img375.imageshack.us/img375/8646/wowscrnshot070109131012z.jpg

What version of the product are you using?
Newest version as per curse client (4.0.0Beta1)

Do you have an error log of what happened?

Please provide any additional information below.

User When Change
Shefki Jan 13, 2010 at 00:08 UTC Changed assigned to from ckknight to Shefki

Changed priority from Medium to Low

Changed status from Replied to Accepted
cremor Jul 29, 2009 at 15:38 UTC Changed status from Waiting to Replied
Shefki Jul 28, 2009 at 05:37 UTC Changed status from Replied to Waiting
sfan27 Jul 27, 2009 at 17:59 UTC Changed status from Waiting to Replied
Shefki Jul 26, 2009 at 04:27 UTC Changed status from Replied to Waiting
esullivan Jul 09, 2009 at 21:10 UTC Changed status from Waiting to Replied
Shefki Jul 09, 2009 at 20:32 UTC Changed status from Replied to Waiting
esullivan Jul 09, 2009 at 13:11 UTC Changed status from Waiting to Replied
Shefki Jul 09, 2009 at 07:17 UTC Changed status from Replied to Waiting
sfan27 Jul 09, 2009 at 06:48 UTC Changed status from Waiting to Replied
Shefki Jul 08, 2009 at 22:54 UTC Changed status from Replied to Waiting
esullivan Jul 03, 2009 at 12:56 UTC Changed status from Waiting to Replied
Shefki Jul 03, 2009 at 08:17 UTC Changed status from New to Waiting
esullivan Jul 01, 2009 at 18:16 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of Shefki Shefki Jan 20, 2010 at 20:32 UTC - 0 likes

    Trace of the debug assertion failing for my purposes.  This unfortunately still isn't showing me where things failed.  This was triggered by a main tank change which caught the fact that the unit id was still set when it should have been nil.  :(

    Date: 2010-01-19 18:20:58
    ID: -5
    Error occured in: Global
    Count: 2
    Message: ..\AddOns\PitBull4\UnitFrame.lua line 310:
       Expectation failed: "0xF13000908F00B1DF" == nil
    Debug:
       [C]: ?
       [C]: error()
       PitBull4\Debug.lua:114
          PitBull4\Debug.lua:109
       PitBull4\UnitFrame.lua:310
          PitBull4\UnitFrame.lua:298
       [C]: SetAttribute()
       ..\FrameXML\SecureTemplates.lua:826
          ..\FrameXML\SecureTemplates.lua:729
       ..\FrameXML\SecureTemplates.lua:1024
          ..\FrameXML\SecureTemplates.lua:905
       [C]: ?
       [C]: Show()
       PitBull4\GroupHeader.lua:419 func()
       PitBull4\Main.lua:1603
          PitBull4\Main.lua:1597
       (tail call): ?
       PitBull4\Main.lua:945 ?()
       ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
          ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
       [string "safecall Dispatcher[2]"]:4:
          [string "safecall Dispatcher[2]"]:4
       [C]: ?
       [string "safecall Dispatcher[2]"]:13: ?()
       ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:92 Fire()
       oRA3\modules\Tanks.lua:59
          oRA3\modules\Tanks.lua:51
       oRA3\modules\Tanks.lua:97 ?()
       ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
          ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
       [string "safecall Dispatcher[3]"]:4:
          [string "safecall Dispatcher[3]"]:4
       [C]: ?
       [string "safecall Dispatcher[3]"]:13: ?()
       ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:92 Fire()
       oRA3\oRA3.lua:287 ?()
       ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
          ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
       [string "safecall Dispatcher[1]"]:4:
          [string "safecall Dispatcher[1]"]:4
       [C]: ?
       [string "safecall Dispatcher[1]"]:13: ?()
       ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:92 Fire()
       Ace3\AceEvent-3.0\AceEvent-3.0.lua:120
          Ace3\AceEvent-3.0\AceEvent-3.0.lua:119

    Last edited Jan 20, 2010 by Shefki
  • Avatar of Shefki Shefki Jan 13, 2010 at 00:07 UTC - 0 likes

    I haven't said or done anything to this ticket in a while so I figure I should post something. In general this issue no longer is visible to users at all. The places that were triggering errors have all be protected to check the unit is set as well as the guid. This probably isn't a bad thing but it doesn't really solve the out of sync issue that this ticket represents.

    Ultimately if the unit is not set then the guid should not be set for that frame. The code all appears to always trigger a guid clear whenever the unit is cleared. However, as is evidenced from these issues it wasn't happening in some unusual circumstance.

    It is clear that it is almost always wacky frames (particular of target group frames) that trigger this. There is a DEBUG only assertion that will complain if this issue pops up. However, at this point I'm really not sure what causes this. Anyone running PB4 with debug turned on should report any tracebacks of the assertion error here.

    This is pretty low priority even though it's just a small nit that bugs me. I'm not focusing on tracking down this issue at this time and will eventually get back to it when other more pressing issues are dealt with.

  • Avatar of cremor cremor Aug 13, 2009 at 18:48 UTC - 0 likes

    I think this one is also related:

    [2009/08/13 20:20:24-2408-x5]: PitBull4-v4.0.0-beta3-4-g444072c\Modules\CastBar\CastBar.lua:164 Usage: UnitGUID("unit")
    PitBull4-v4.0.0-beta3-4-g444072c\Modules\CastBar\CastBar.lua:164 in function `UpdateInfo'
    PitBull4-v4.0.0-beta3-4-g444072c\Modules\CastBar\CastBar.lua:79 in function `GetValue'
    PitBull4-v4.0.0-beta3-4-g444072c\ModuleHandling\BarModule.lua:40 in function <...terface\AddOns\PitBull4\ModuleHandling\BarModule.lua:34
    PitBull4-v4.0.0-beta3-4-g444072c\ModuleHandling\BarModule.lua:263 in function `UpdateFrame'
    PitBull4-v4.0.0-beta3-4-g444072c\ModuleHandling\Module.lua:288 in function `Update'
    PitBull4-v4.0.0-beta3-4-g444072c\Modules\CastBar\CastBar.lua:159 in function `ClearFramesByGUID'
    PitBull4-v4.0.0-beta3-4-g444072c\Modules\CastBar\CastBar.lua:244 in function `FixCastData'
    PitBull4-v4.0.0-beta3-4-g444072c\Modules\CastBar\CastBar.lua:53 in function `FixCastDataAndUpdateAll'
    PitBull4-v4.0.0-beta3-4-g444072c\Modules\CastBar\CastBar.lua:30 in function <...nterface\AddOns\PitBull4\Modules\CastBar\CastBar.lua:30

  • Avatar of strikeq strikeq Aug 11, 2009 at 23:22 UTC - 0 likes

    Haven't got this error in awhile, but now it's back

  • Avatar of cremor cremor Jul 31, 2009 at 16:22 UTC - 0 likes

    Also got it in a newer version, v4.0.0-beta2-36-g7cdf1c4

    [2009/07/31 18:20:16-2331-x1]: frame = PitBull4_Groups_MTTargetsUnitButton1; unit = nil; guid = 0x0400000001F69227; is_shown = nil:
    Usage: UnitHealth("unit"):
    PitBull4-v4.0.0-beta2-36-g7cdf1c4\ModuleHandling\BarModule.lua:39: in function <...terface\AddOns\PitBull4\ModuleHandling\BarModule.lua:33>
    PitBull4-v4.0.0-beta2-36-g7cdf1c4\ModuleHandling\BarModule.lua:216: in function `UpdateFrame'
    PitBull4-v4.0.0-beta2-36-g7cdf1c4\ModuleHandling\Module.lua:288: in function `Update'
    PitBull4-v4.0.0-beta2-36-g7cdf1c4\UnitFrame.lua:619: in function `Update'
    PitBull4-v4.0.0-beta2-36-g7cdf1c4\UnitFrame.lua:645: in function `UpdateGUID'
    PitBull4-v4.0.0-beta2-36-g7cdf1c4\Main.lua:1269: in function `CheckGUIDForUnitID'
    PitBull4-v4.0.0-beta2-36-g7cdf1c4\Main.lua:1280: in function `?'
    CallbackHandler-1.0-3 (Ace3):146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
    <string>:"safecall Dispatcher[1]":4: in function <[string "safecall Dispatcher[1]"]:4>
    <in C code>: ?
    <string>:"safecall Dispatcher[1]":13: in function `?'
    CallbackHandler-1.0-3 (Ace3):91: in function `Fire'
    AceEvent-3.0-3 (Ace3):119: in function <Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:118>
    <in C code>: in function `TurnOrActionStop'
    <string>:"TURNORACTION":4: in function <[string "TURNORACTION"]:1>

    -

  • Avatar of cremor cremor Jul 29, 2009 at 15:38 UTC - 0 likes

    Seems like someone managed to get the error in a newer version:
    http://www.wowace.com/addons/pitbull4/tickets/529-power-bar-lua-error/

  • Avatar of Shefki Shefki Jul 28, 2009 at 05:37 UTC - 0 likes

    I believe I've found the root cause of this. And the latest alpha push includes a fix for this. The timer for wacky frames was still updating them because we were checking if they were shown as opposed to checking if they were visible. This meant when a group was hidden, the guid would get cleared and then the wacky timer would come along and remove it.

    It does not entirely explain the errors you are getting however, because I can't find a way to get the unit not to be set on the frame but the guid to be set. So this may not be the fix to this problem. However, either way we shouldn't have been updating those frames since they weren't visible anyway.

    As a result I'm leaving the ticket open. If you guys stop seeing these errors for a while then I'll eventually close it. So please only post here if you're running v4.0.0-beta2-34-g1510aa4 or newer.

  • Avatar of Shefki Shefki Jul 27, 2009 at 22:15 UTC - 0 likes

    BetterInBox is just mentioned because it's providing Ace3 for you.

    The second error is showing up because the first one is being trapped by the code I put in. Usually without the code I put in the execution would stop at the first error.

    After looking through these errors they probably are all caused by the same root cause but not really coming from the same place. Some of them come from the delayed reaper code that tears down group frames after you haven't been in a group frame for 5 minutes and slowly removes the frame over 10 minutes. So it's entirely possible that the error doesn't show until 15 minutes after the root cause.

    Basically the problem is the guid set on the frame should always be cleared if the frame is hidden. But somehow the frames are being hidden and the guid is being left set on them. Which is perplexing.

  • Avatar of sfan27 sfan27 Jul 27, 2009 at 17:59 UTC - 0 likes

    I had two simultaneous errors.  Both of them show BetterInbox, another addon, as well as pitbull.  I was nowhere near a mailbox, and didn't receive new mail, so I don't get what BetterInbox has to do with anything.

    Edit: Also, I wasn't in a group

    [2009/07/27 10:54:03-899-x1]: frame = PitBull4_Groups_Party targetsUnitButton4; unit = nil; guid = 0xF13000830E658505; is_shown = nil:
    Usage: UnitHealth("unit"):
    PitBull4-v4.0.0-beta2-33-g1a828df\ModuleHandling\BarModule.lua:39 in function <...terface\AddOns\PitBull4\ModuleHandling\BarModule.lua:33
    PitBull4-v4.0.0-beta2-33-g1a828df\ModuleHandling\BarModule.lua:216 in function `UpdateFrame'
    PitBull4-v4.0.0-beta2-33-g1a828df\ModuleHandling\Module.lua:288 in function `Update'
    PitBull4-v4.0.0-beta2-33-g1a828df\UnitFrame.lua:619 in function `Update'
    PitBull4-v4.0.0-beta2-33-g1a828df\GroupHeader.lua:1001 in function <Interface\AddOns\PitBull4\GroupHeader.lua:996
    (tail call): ?:
    <in C code>: ?
    <string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
    (tail call): ?:
    AceTimer-3.0-5 (BetterInbox):160: in function <...ddOns\BetterInbox\libs\AceTimer-3.0\AceTimer-3.0.lua:132

      --

    [2009/07/27 10:54:03-899-x1]: PitBull4-v4.0.0-beta2-33-g1a828df\Modules\HealthBar\HealthBar.lua:86 Usage: UnitHealthMax("unit")
    PitBull4-v4.0.0-beta2-33-g1a828df\Modules\HealthBar\HealthBar.lua:86 in function `GetValue'
    PitBull4-v4.0.0-beta2-33-g1a828df\ModuleHandling\BarModule.lua:39 in function <...terface\AddOns\PitBull4\ModuleHandling\BarModule.lua:33
    PitBull4-v4.0.0-beta2-33-g1a828df\ModuleHandling\BarModule.lua:216 in function `UpdateFrame'
    PitBull4-v4.0.0-beta2-33-g1a828df\ModuleHandling\Module.lua:288 in function `Update'
    PitBull4-v4.0.0-beta2-33-g1a828df\UnitFrame.lua:619 in function `Update'
    PitBull4-v4.0.0-beta2-33-g1a828df\GroupHeader.lua:1001 in function <Interface\AddOns\PitBull4\GroupHeader.lua:996
    (tail call): ?:
    <in C code>: ?
    <string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5>
    (tail call): ?:
    AceTimer-3.0-5 (BetterInbox):160: in function <...ddOns\BetterInbox\libs\AceTimer-3.0\AceTimer-3.0.lua:132

      ---

    Last edited Jul 27, 2009 by sfan27

Facts

Last updated
Nov 04, 2013
Reported
Jul 01, 2009
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Low - Might slip to a later milestone.
Votes
2

Reported by

Possible assignees