PitBull Unit Frames 4.0

445 - Unique PvP icon for neutral NPCs

Neutral NPCs that have no faction group receive the players' faction icon if they are PVP flagged.  The FFA icon is not entirely correct since they are friendly to the player and can't be attacked.  Not showing the icon hides the information that they are acting as guards to discourage or prevent PVP.  We need a unique icon to display this information.

User When Change
Stanzilla Nov 04, 2013 at 22:15 UTC Changed assigned to from Trillianne to Shefki
Stanzilla Aug 20, 2012 at 01:01 UTC Changed assigned to from ckknight to Trillianne
Shefki Jun 20, 2009 at 20:14 UTC Changed name from wrong PvP icon to Unique PvP icon for neutral NPCs

Changed type from Defect to Enhancement

Changed priority from Medium to Low

Changed description from PvP icon is showed correctly only on players. All PvP flagged NPC (Alliance, Horde and Neutral) have the player's faction icon. to Neutral NPCs that have no faction group receive the players' faction icon if they are PVP flagged. The FFA icon is not entirely correct since they are friendly to the player and can't be attacked. Not showing the icon hides the information that they are acting as guards to discourage or prevent PVP. We need a unique icon to display this information.

Changed status from Replied to Accepted
TAP3AH Jun 20, 2009 at 18:06 UTC Changed status from Waiting to Replied
Shefki Jun 20, 2009 at 07:31 UTC Changed status from New to Waiting
TAP3AH Jun 16, 2009 at 12:27 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 5 comments
  • Avatar of Shefki Shefki Jun 20, 2009 at 20:11 UTC - 0 likes

    Talking to ck there's really no clear correct thing to do here. These are typically vendors and other NPCs that also function as guards.

    Player's faction icon isn't entirely correct because they may attack you if you begin PVP'ing.

    FFA isn't entirely correct because you can not attack them.

    No icon loses the display of the information that these are guards in neutral areas to stop PVP'ing.

    Guess we need our own "guard" icon.

    Edited the ticket to be appropriate to what we really need. It's not a defect it's something we could improve thus enhancement.

  • Avatar of TAP3AH TAP3AH Jun 20, 2009 at 18:06 UTC - 0 likes

    Actually, I made a mistake. Flagged and aligned NPCs do have proper flag. Only flagged and non-aligned have player's faction flag. Still, I think it would be more logical if flagged and non-aligned ones have FFA flag. Like:

    return [[Interface\TargetingFrame\UI-PVP-]] .. (UnitFactionGroup(unit) or "FFA")
    

    instead of

    return [[Interface\TargetingFrame\UI-PVP-]] .. (UnitFactionGroup(unit) or UnitFactionGroup("player"))
    

    in line 38.

  • Avatar of Shefki Shefki Jun 20, 2009 at 07:31 UTC - 0 likes

    Okay I misunderstood. I thought you were just talking about NPCs that did not have a faction and were PVP flagged. However, after looking into this I can't reproduce what you're saying. Opposing faction NPCs have the proper icons for me. I'm curious this returns when you're targeting one of them: /dump UnitFactionGroup("target")

    If it's two nil's then the NPC is actually not flagged as Horde or Alliance and it's behaving as expected.

  • Avatar of TAP3AH TAP3AH Jun 17, 2009 at 15:29 UTC - 0 likes

    Hmm... That's new for me. And quite surprising. Why on earth would Thrall have Alliance symbol on his portrait.

  • Avatar of Shefki Shefki Jun 17, 2009 at 08:30 UTC - 0 likes

    Umm this is intentional. It's how we've always done it.

  • 5 comments

Facts

Last updated
Nov 04, 2013
Reported
Jun 16, 2009
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Low - Might slip to a later milestone.
Votes
0
Component
Core

Reported by

Possible assignees