5.0.4 Patch #206


  • Started
  • Patch
Open
Assigned to _ForgeUser451653
  • sourceway created this issue Sep 5, 2012

    What does the provided patch do?
    fix most errors in ZOMG itself as an easy start to realy fix zomg :))

  • sourceway added the tags New Patch Sep 5, 2012
  • sourceway added an attachment 504-v2.patch Sep 5, 2012

    504-v2.patch

    <p>Extended Patch</p>

  • sourceway added an attachment Sep 5, 2012
    Attachment was deleted Nov 8, 2016
  • sourceway added an attachment rogue.patch Sep 5, 2012

    rogue.patch

    <p>rogue patch</p>

  • sourceway added an attachment hunter_pet.patch Sep 5, 2012

    hunter_pet.patch

  • Davenrothz posted a comment Sep 5, 2012

    Is there a way for a user to easily implement this patch you've created? I assume that is what I'm seeing by the link above.

    I also assume one would have to install these new 5.0.4 libraries they discussed on the other ticket #205: http:www.wowace.com/addons/zomgbuffs/tickets/205-5-0-4-issue/

  • sourceway posted a comment Sep 6, 2012

    The easiest way to apply this patch is if you have TortoiseSVN or another SVN client installed.

    if you want to manually apply the patch you have to read throu the .patch file and modify the files in your addon folder.

    updated librarys such as LibGroupTalents-1.0 would be required.

    also i found that there still seems to be a logical bug, as it does not want to buff Mark of the Wild while Solo, in Party or in Raid... Also it seems it wont fix all deprecated/removed spell ids (only tested on my druid before posting the patch) as on my warrior i again got errors. if i get the time, i'll try to update the patch the next days (if there is not an official update earlier *hopng so*)

  • sourceway posted a comment Sep 6, 2012

    updated the patch to fix errors for most classes (think rogue and DK missing as i dont have them)

  • _ForgeUser451653 posted a comment Sep 6, 2012

    Hi Netrox, thanks for contributing this!

    I gave it a once over and while I haven't really tested it for lack of time, went ahead and committed your fixes.

    A new alpha build should be packing up at this moment. It'll grab the new libraries as well. Once it's stable here I can flag a major revision and push it to curse.

  • _ForgeUser451653 removed a tag New Sep 6, 2012
  • _ForgeUser451653 added a tag Started Sep 6, 2012
  • _ForgeUser451653 unassigned issue from Forge_User_26050436 Sep 6, 2012
  • _ForgeUser451653 self-assigned this issue Sep 6, 2012
  • sourceway posted a comment Sep 6, 2012

    Hi thelibrarian,

    thanks for commiting my changes.

    i attached a patch for rogue. dk seems to work.

    LibGroupTalents-1.0 is still buggy. i posted a patch there too. hope they'll apply it (http://www.wowace.com/addons/libgrouptalents-1-0/tickets/17-5-0-4-patch/)

  • _ForgeUser451653 posted a comment Sep 6, 2012

    Thanks, applied it.

    For now I've just disabled the LibGroupTalents interface entirely. You'll lose the automatic role detection, but it should still show the icons for if the roles are set using the Blizzard interface (I *THINK*).

  • sourceway posted a comment Sep 6, 2012

    Nice, i'm happy to help :)

    just want to mention: these fixes are some kind of "remove old stuff to kill errors" if there are some new spells/buffs (e.g. Monk) they're not handled. so maybe someday someone who knows the code better than me should take a look :)

    EDIT: The module TOCs are not yet updated :)


    Edited Sep 6, 2012
  • sourceway posted a comment Sep 6, 2012

    LGT is still being used in bufftheraid and selfbuff

  • _ForgeUser451653 posted a comment Sep 6, 2012

    Fixed them - forgot to do a recursive search. Unfortunately that breaks Improved Earth Shield (if it even still exists, haven't really kept up with all the class changes), and possibly Inner Fire.

    Bumped the TOCs too.


    Edited Sep 6, 2012
  • sourceway posted a comment Sep 6, 2012

    it seems that Improved Earth Shield is gone and Earth Shield now has always 9 Stacks (http://www.wowhead.com/spell=974) so you could remove the check in the bufftheraid module.

    no idea what about inner fire.


    Edited Sep 6, 2012
  • _ForgeUser451653 posted a comment Sep 6, 2012

    Well, that's easy enough. BuffTheRaid really doesn't need LibGroupTalents anymore then.

  • sourceway posted a comment Sep 6, 2012

    found another little bug for hunter.

  • zeroglitch posted a comment Sep 6, 2012

    Dark Intent isn't depreciated, the spell ID has changed though. It is now 109773. Updating the id in line 978 to 109773 in the ZOMGBuffs_BuffTehRaid.lua fixes the issue some are having with it not showing.

  • Davenrothz posted a comment Sep 6, 2012

    I believe the most important paladin reminder buff is Sacred Shield. For a prot paladin, it comprises around 3k-5k of self healing, and probably moreso for holy. The moveable icon was indispensable. I installed the alpha version & I did not see an option for it.

    Of course the earthshield tracker for resto shaman was insanely useful as well.


To post a comment, please login or register a new account.