LibGroupTalents-1.0

17 - 5.0.4 Patch

What does the provided patch do?
Replaces old function names with new :)

Name Size MD5
504.patch 4.2 KiB e05355a747aa...
User When Change
Netrox Sep 06, 2012 at 14:41 UTC

Added attachment 504.patch

Netrox Sep 06, 2012 at 14:40 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of oscarucb oscarucb Sep 10, 2012 at 00:46 UTC - 0 likes

    Changing function names is unfortunately the easy part.

    The hard part is that talents themselves no longer mean what they used to, and the library interface to LibGroupTalents is now basically out-of-date. This library needs a re-design/re-write to be useful to addons on 5.x.

  • Avatar of Netrox Netrox Sep 06, 2012 at 14:43 UTC - 0 likes

    maybe locations containing "GetNumSpecializations"(new name for "GetNumTalentTabs") calls should be reviewed.

    for one of my addons i found, that GetNumSpecializations does not realy care. only first two tabs should care (General Tab + currently Active Spec)

  • 2 comments

Facts

Last updated
Sep 06, 2012
Reported
Sep 06, 2012
Status
New - Issue has not had initial review yet.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees