War Campaign not appearing. #102


Open
  • tw_vincent created this issue Aug 13, 2018

    They seem to be counted in the x/25 header but do not display in the tracker itself.

  • Shiv_G3 posted a comment Aug 13, 2018

    Was going to post here about the same.  Disabled SQL for now.

  • Gnare posted a comment Aug 13, 2018

    +1 on this.... 

    I tried to debug it a little, and it doesn't seem to like "The War Campaign" as a zoneID...  seemingly because it's not actually in the list returned by GetNumQuestLogEntries as a header...    you might need to just fudge it as a header?   I didn't spend a lot of time trying to understand your code, sorry - just took a quick debug stab at it.

  • A_Tiny_Raven posted a comment Aug 14, 2018

    +1 as well. This is kind of a big deal since I have no way to see what's happening with War Campaign currently.

  • fenixfunkfive posted a comment Aug 15, 2018

    Same exact problem!

    Until I disabled SQL  I realized how much of a step-up it is from the vanilla quest tracker. It'll do for now, but hopefully the author can take a look into it!

     

    TY

  • Dzendrieh posted a comment Aug 19, 2018

    +1.   Trying to get around using other addons, but sorely miss this. Do we know if there's gonna be any traction on this yet?

  • cheesecake4711 posted a comment Aug 21, 2018

    Fix for Battle for Azeroth:

    https://github.com/Eiltherune/SorhaQuestLogBFA

     

    This fix adds the War Campaign quests to the tracker and marks BfA World Quests as lvl 120.

    To be done:

    • Option to hide all WQs
    • Change options for hiding/showing modules so each module type can be changed separately
  • wizjany_ posted a comment Aug 21, 2018

    here's a diff for people who just want to see the fix:

     

    diff -wr SorhaQuestLog/Modules/Quests.lua SorhaQuestLogBFA/Modules/Quests.lua
    55a56,57
    > local warCampaignZoneTitle = WAR_CAMPAIGN;
    > local warCampaignZoneID = 'War Campaign';
    2570a2573,2594
    >               local zoneID = C_TaskQuest.GetQuestZoneID(self.ID);
    >               local zoneIDsToLevel = {
    >                       [650] = 110, -- Highmountain
    >                       [634] = 110, -- Stormheim
    >                       [680] = 110, -- Suramar
    >                       [630] = 110, -- Azsuna
    >                       [641] = 110, -- Val'sharah
    >                       [627] = 110, -- Dalaran
    >                       [790] = 110, -- Eye of Azshara
    >                       [646] = 110, -- Broken Shore
    >                       [882] = 110, -- Mac'Aree
    >                       [830] = 110, -- Krokun
    >                       [885] = 110, -- Antoran Wastes
    >                       [942] = 120, -- Stormsong Valley
    >                       [895] = 120, -- Tiragarde Sound
    >                       [1161] = 120, -- Boralus
    >                       [896] = 120, -- Drustvar
    >                       [864] = 120, -- Vol'dun
    >                       [863] = 120, -- Nazmir
    >                       [862] = 120, -- Zuldazar
    >                       [1165] = 120, -- Dazar'alor
    >               }
    2587c2611
    <                       self.Level = 110;
    ---
    >                       self.Level = zoneIDsToLevel[zoneID] or 120;
    3311a3336
    >       self.ZoneList[warCampaignZoneID] = SQLZone:new(101, true, warCampaignZoneID, warCampaignZoneTitle);
    3418a3444,3445
    >                                       else
    >                                               self.ZoneList[warCampaignZoneID]:AddQuest(self.QuestList[questID]);
    3468a3496,3500
    >       if (dbChar.ZoneIsCollapsed[warCampaignZoneID] == true) then
    >               self.ZoneList[warCampaignZoneID].IsCollapsed = true;
    >       else
    >               self.ZoneList[warCampaignZoneID].IsCollapsed = false;
    >       end
    

     even better, gisted the diff

    https://gist.github.com/wizjany/26791988d89f8b14509c0342ef110ed3

     

     

    disclaimer: credit goes to eiltherune's repo. I just created a diff because I find it annoying when people make a brand new repo with the fixed code without first committing the original code.


    Edited Aug 21, 2018
  • tw_vincent posted a comment Aug 22, 2018

    Oh praise be. A little nip-tuck to add a wowhead link generator and I'm back in business. Hat's off to Eiltherune.

  • Sorha2 posted a comment Aug 29, 2018

    Sorry for being gone so long, health just isn't treating me well :(

     

    Those changes above should work, I committed some today that I had been working on before. Will break those though :(

  • xtoq posted a comment Aug 30, 2018

    Thanks for the update to add War Campaign tracking!

     

    Right now I can't collapse the War Campaign in the quest tracker, and it pushes the tracker over from the edge of the screen even when there isn't long text.

     

    I was on the Kul Tiras part of the Horde War Campaign if you need to recreate. I also have a screenshot if you need.

    Thanks again!

  • PancakeTac0 posted a comment Aug 31, 2018

    Really appreciate the update to add the war campaign and hope it didn't come at the expense of your health.  When you have the time would you please make it so we can show/hide the campaign or perhaps have it autohide when there's nothing left to do?  


    Edited Aug 31, 2018

To post a comment, please login or register a new account.