WowAce

Looks like its working properly again. But will you do so the war Campaign gets its own little spot at the top in the queslog?

I know this was enabled for the older version so that part was distinguised from the normal quests.

BR

In reply to wheatleyzor:

 Some war campaign API functions were removed and others updated or added to (apparently) now support multiple campaigns active at once.  This means there is no longer the concept of "THE" current campaign, and the API function to retrieve "THE" current campaign has been removed. Putting the war campaign at the top was driven by finding what was the current campaign using the now removed function, so this code needs to be revisited.

I'll see what I can do with it and to add back in support for quest timers; the APIs for both of these were sufficiently altered that the existing code can't be updated directly and will need to be reworked somewhat.

In reply to RubioTwitch:

 I mean, its not gonna be horrible to not have it but as SL going in you will still have that "main campaign" like BFA has now and having that seperated was a nice feature added to SQL since its already in the default questlog.

Personally it adds alot to be able to seperate the "normal" quest from the quest or quests that is tied directly to the main campaign or what you want to call it.

In reply to wheatleyzor:

 I just found another thing that dosent seem like its working at the moment.

Under Zones you can enable "Auto Expand on Enter" and "Auto Collapse on Exit".
It dosent seem like its working at the moment.
I have quests in Pandaria but when going back to Ogrimmar, the "Auto Collapse on Exit" does not work and all my quests in Pandaria are still visible.

I'm getting this error as an example:

"
18x SorhaQuestLog\Modules\Quests.lua:5646: attempt to call global 'GetDistanceSqToQuest' (a nil value)
[string "@SorhaQuestLog\Modules\Quests.lua"]:5646: in function `GetClosestItemQuest'
[string "@SorhaQuestLog\Modules\Quests.lua"]:5294: in function `UpdateSmartItemButton'
[string "@SorhaQuestLog\Modules\Quests.lua"]:4890: in function `UpdateMinion'
[string "@SorhaQuestLog\Modules\Quests.lua"]:4837: in function `UpdateMinionHandler'
[string "@SorhaQuestLog\Modules\Quests.lua"]:3852: in function `?'
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:119: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire'
[string "@Ace3\AceEvent-3.0\AceEvent-3.0-4.lua"]:120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119> "

This is after updating to your new version.

BR

In reply to wheatleyzor:

 (fixed; download again from same url)

UPDATED 19-Oct-2020

I've taken a SECOND pass at updating for 9.0.1 -

Reported issues, and some other problems found in my testing, have now been fixed.

I'll try to update further if people report additional issues.

The only currently known issue is that quest timers are currently disabled.

Download link:  https://github.com/Rubio9/SorhaQuestLog/archive/main.zip

NOTE, you will want to rename the folder after extracting it. 

It will extract as SorhaQuestLog-main and should be renamed to SorhaQuestLog - and you probably need to remove your existing SorhaQuestLog folder before doing that.

(For the curious - follow this link to see first pass changes, and this one for second pass.)

In reply to RubioTwitch:

Getting an error, which causes the quest log frame to disappear, when the quest has an item that needs to be used with it.

Turning off quest items "fixes" it.

13x SorhaQuestLog\Modules\Quests.lua:5646: attempt to call global 'GetDistanceSqToQuest' (a nil value)

In reply to Greybit:

  (fixed; download again from same url)

In reply to RubioTwitch:

Also getting an error when you shift click on a world quest to track it.

This causes the quest log frame not to show until you remove the WQ from tracking using the default tracker.

7x SorhaQuestLog\Modules\Quests.lua:2496: Usage: GetQuestLogSpecialItemInfo(index)
[string "=[C]"]: in function `GetQuestLogSpecialItemInfo'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2496: in function `Update'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2479: in function `new'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2631: in function `Update'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2573: in function `new'
[string "@SorhaQuestLog\Modules\Quests.lua"]:3500: in function `Update'
[string "@SorhaQuestLog\Modules\Quests.lua"]:5333: in function `GetQuestLogInformation'
[string "@SorhaQuestLog\Modules\Quests.lua"]:4856: in function `?'
[string "@Ace3\AceTimer-3.0\AceTimer-3.0-17.lua"]:55: in function <Ace3\AceTimer-3.0\AceTimer-3.0.lua:50>

Locals:
(*temporary) = nil

In reply to Greybit:

 in Modules\Quest.lua:

2923: change GetDistanceSqToQuest to C_QuestLog.GetDistanceSqToQuest

5646: same

In reply to pjotrpottervogel:

Still getting the following error when a world quest is being tracked when shift clicking the quest on the map.

Prevents the quest tracker from showing until its removed.

Item button is now working correctly.

19x SorhaQuestLog\Modules\Quests.lua:2496: Usage: GetQuestLogSpecialItemInfo(index)
[string "=[C]"]: in function `GetQuestLogSpecialItemInfo'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2496: in function `Update'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2479: in function `new'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2631: in function `Update'
[string "@SorhaQuestLog\Modules\Quests.lua"]:2573: in function `new'
[string "@SorhaQuestLog\Modules\Quests.lua"]:3500: in function `Update'
[string "@SorhaQuestLog\Modules\Quests.lua"]:5333: in function `GetQuestLogInformation'
[string "@SorhaQuestLog\Modules\Quests.lua"]:4856: in function `?'
[string "@Ace3\AceTimer-3.0\AceTimer-3.0-17.lua"]:55: in function <Ace3\AceTimer-3.0\AceTimer-3.0.lua:50>

Locals:
(*temporary) = nil

In reply to Greybit:

  (fixed; download again from same url)

In reply to Greybit:

  (fixed; download again from same url)

In reply to RubioTwitch:

 Thank you very much! I love you forever ^^

In reply to RubioTwitch:

When clicking on a completed quest it throws back this:

SorhaQuestLog\Modules\Quests.lua:5702: attempt to call global 'GetQuestLogIsAutoComplete' (a nil value)

In reply to Greybit:

another one:

look for line 5700

replace:

if ( C_QuestLog.IsComplete(questInstance.ID) and GetQuestLogIsAutoComplete(questInstance.Index) ) then

with:

local info = C_QuestLog.GetInfo(questInstance.Index)

if ( C_QuestLog.IsComplete(questInstance.ID) and info[isAutoComplete] ) then

In reply to pjotrpottervogel:

 Could you roll all your changes into a .zip file and upload them to github or dropbox?

In reply to mothandras:

 sorry, no. posting here is the best i can do. 

In reply to mothandras:

 I'll be updating mine soon with fixes for what's been reported, and a few that haven't