Incorrect stats merge for player named Hati #543


Open
  • Forge_User_98149804 created this issue Oct 28, 2017

    Yes, they are some - very old - characters that are named Hati...

     

    And sometimes, my stats are merged with that of another player. I propose this correction, in modules/Tweaks.lua :

    replace line 27 with this one (e.g. add the band(...) condition)

        elseif srcName == 'Hati' and not assignedhatis[srcGUID] and band(srcFlags, COMBATLOG_OBJECT_TYPE_GUARDIAN) ~= 0 then

    Without the test,  an event from "Hati" fired in the same timestamp of a previous event from a pet will assign "Hati" as a pet of the pet owner, even if Hati is not a guardian/pet.

     

    Best regards,

    Hati, EU Eitrigg

  • Forge_User_98149804 posted a comment Oct 29, 2017

    Actually, the both lines (28 and 29 of Tweaks.lua)

        if lastpet.timestamp == timestamp then
                local owner = Skada:GetPetOwner(lastpet.srcGUID)

    can assign an Hati to a bad owner if events are reported with the same timestamp. And apparently, it occurs...

     

     

    As an improvement, this function should be rewritten with if/elseif  .

  • Forge_User_98149804 edited description Oct 29, 2017
  • transitbus posted a comment Nov 6, 2017

    Hati is the secondary pet for BM hunters sue to their legendary weapon. Since it is not tagged as a normal pet, skada doesn't group it properly. It isn't going to be fixed so to get accurate meters, switch to details that fixed this a while ago.


To post a comment, please login or register a new account.