Skada shows wrong % when tracking buff uptime #490


  • Defect
  • Fixed
Closed
Assigned to zarnivoop
  • _ForgeUser417705 created this issue Oct 6, 2016

    When tanking on my Demon Hunter I tried to use Skada to keep track on my Demon Spikes uptime, but it shows the wrong %.
    Even if I do nothing but use Shear and Demon Spikes or macro them together and just hit a dummy for several minutes, the addon shows the expected % for the first 10 seconds or so, but the % drops steadily the longer the fight is (ive had it show under 1% uptime as a result)

    What steps will reproduce the problem?
    1. Play tank Demon Hunter
    2. Macro shear and Demon Spikes together, or just play a dungeon
    3. hit a dummy for a few minutes, track buff uptime, and see the numbers drop

    What version of the product are you using?
    Latest version.

  • _ForgeUser417705 added the tags New Defect Oct 6, 2016
  • _ForgeUser366474 posted a comment Oct 9, 2016

    Copied from my reply on https://www.wowace.com/addons/skada/tickets/473-buff-debuff-uptime-showing-wrong-percentage/#c2

    It seems like Skada is only tracking the initial application presence of a buff. I tested a couple of times on my DH with a 60 second target dummy fight. I used immolation aura on CD (every 13.6 sec) and at the 30 second mark used soul cleave to clear the initial soul fragment buff. I also was spamming shear so that within a few seconds at most a new soul fragment buff was applied. The results were:

    • Soul Fragment uptime 44%, 40.6%
    • Immolation Aura uptime 9.8%, 10.9%

    There should have been around 75-90% uptime on Soul Fragment depending on RNG and as Immolation Aura lasts 6 seconds with a 13.6 sec CD it should have been around 40-44% even accounting for lag.

    Given that I cleared my initial soul fragment buff at 30 seconds with soul cleave and assuming a second or two for the initial application presence to appear that 40-44% uptime would be for that initial application presence. Same for Immolation aura, it lasts 6 seconds(aka 10% of a minute)

    Edit: after testing with demon spikes I actually think it stops counting the uptime after the first time the buff falls off. I tested this again with a 1 minute fight. I applied demon spikes and then reapplied it before the initial application fell off the results were a 18.2% uptime, which is pretty close to the expected 20% since demon spikes lasts 6 seconds (2 applications would be 12 seconds if done perfect) and I had to reapply slightly early.

  • _ForgeUser1494371 posted a comment Oct 10, 2016

    I have the same issue with pretty much any character i play.. And i also posted a ticket a while ago https://www.wowace.com/addons/skada/tickets/473-buff-debuff-uptime-showing-wrong-percentage/ but didnt get any response. Tried Recount as well, but that addon is so weird with settings that i couldnt make it to track buff uptimes either. I hope this gets fixed soon because not everyone is uploading logs to check such stuff..

  • _ForgeUser2159598 posted a comment Oct 11, 2016

    Fixed by my own, just replace at line 24 (modules/debuffs.lua):

    else player.auras[aura.spellname].active = player.auras[aura.spellname].active + 1 end

    by:

    else player.auras[aura.spellname].active = player.auras[aura.spellname].active + 1 player.auras[aura.spellname].started = time() end


    Edited Oct 11, 2016
  • xodiv posted a comment Oct 17, 2016

    That fix is not quite right, as it will reduce the duration any buff that is reapplied before it ends.

    Try this:

    player.auras[aura.spellname].started = player.auras[aura.spellname].started or time()

  • zarnivoop removed a tag New Oct 30, 2016
  • zarnivoop added a tag Fixed Oct 30, 2016
  • zarnivoop closed issue Oct 30, 2016

To post a comment, please login or register a new account.