This site works best with JavaScript enabled. Please enable JavaScript to get the best experience from this site.
What steps will reproduce the problem?1. Enter or exit to Dalaran or Order Hall2.3.
What is the expected output? What do you see instead?Skada is showed but I have checked the Hide on Solo option and Disable when is hide.Skada is Enable although i Hide clicking in the minimap button. To disable I need to go Options and unmark and mark the Disable when is Hide
What version of the product are you using?Always the last.
Do you have an error log of what happened?No
I also see that Skada is Enabled and I have checked Disable when Skada is hidden by the other option (I am alone).
I think this is the issue I've posted about a few times in the Curse comments, in which case here's the fix:
Change
if not win.db.hidden and self.db.profile.hidecombat then
in Skada.lua:1443 to
if not win.db.hidden and self.db.profile.hidecombat and (not self.db.profile.hidesolo or IsInGroup()) then
and add
if not Skada.db.profile.hidesolo or IsInGroup() then ... end
around the contents of Skada:PET_BATTLE_CLOSE() in Skada.lua:1096–1099.
Hello:
The first change I suppose is:
1442 -- Hide in combat option. 1443 if not win.db.hidden and self.db.profile.hidecombat then 1444 win:Show() 1445 end
change to:
1442 -- Hide in combat option. 1443 if not win.db.hidden and self.db.profile.hidecombat and (not self.db.profile.hidesolo or IsInGroup()) then 1444 win:Show() 1445 end
If is correct, the second change at:
1095 -- Restore after pet battles 1096 for i, win in ipairs(windows) do 1097 if not win.db.hidden and not win:IsShown() then 1098 win:Show() 1099 end
I don't understand where add the line and how is the final aspect of the code.
On the other hand, if I change these lines, every update of Skada undo these changes, right?
Regards
With r699 is all the same.
If I enter into Order Hall (mage) appears Skada when the option Hide in Solo are enabled. To hide Skada (and disable) I need to uncheck and check the option Unable if is Hide.
Also occurs when i exit of Dalaran via flying taxi or others methods.
To post a comment, please login or register a new account.