Deathlog doesn't show spell names in bars #346


  • Defect
  • Declined
Closed
Assigned to zarnivoop
  • mcremor created this issue Dec 16, 2013

    What steps will reproduce the problem?
    1. Die.
    2. Check the Death module detail data.

    What is the expected output? What do you see instead?
    It should show the spell names that did damage/healing. Instead it shows just the actor names.

    What version of the product are you using?
    I tested r471 and r477.

    Do you have an error log of what happened?
    No errors thrown.

    Please provide any additional information below.
    The bars look like this:
    -1.23: Actor's             -20k (10k, 10%)
    Instead of this:
    -1.23: Actor's Spell     -20k (10k, 10%)

    The data is there, because the toolips of the player bars (one level up) correctly show the spell names.
    It's not a problem with the window width, there's enough space available.
    All other modules also seem to display their data fine.
    I first noticed the problem after patch 5.4.2. I don't know if the WoW patch or a Skada update caused it, but it worked fine just a week before the patch.

  • mcremor added the tags New Defect Dec 16, 2013
  • mcremor added an attachment Tooltip.jpg Dec 16, 2013

    Tooltip.jpg

  • mcremor added an attachment Bars.jpg Dec 16, 2013

    Bars.jpg

  • mcremor added an attachment Bars2.jpg Dec 16, 2013

    Bars2.jpg

  • mcremor added an attachment Wrapping.jpg Dec 16, 2013

    Wrapping.jpg

  • mcremor added an attachment Arial_Narrow.jpg Dec 16, 2013

    Arial_Narrow.jpg

  • mcremor added an attachment Accidental_Presidency.jpg Dec 16, 2013

    Accidental_Presidency.jpg

  • Funkeh posted a comment Dec 18, 2013

    Is this an old log or did you just record it? The functionality seems to be working fine for me but that screenshot seems to indicate that your log was lacking a .spellname entry for some reason.

  • mcremor posted a comment Dec 19, 2013

    This was a fresh log. I have reset Skada just 1 minute before I let my character die from a random mob and then took these screenshots.

    I've also spoken to other guild members in the meantime and they have the same problem.

    I've already added quite a few print statements in the function deathlog:Update in Deaths.lua and everything there seemed to be correct, including the spellname. So either the bar text isn't just printing the text that was written to "d.label" in this function or there is something that prevents the whole label from displaying.


    Edited Dec 19, 2013
  • Funkeh posted a comment Dec 19, 2013

    The label is showing perfectly fine in your screenshot, the only thing that's missing is the "spellname" as if the value of spellname is "" and has be concatenated in as such. That means there's something wrong with log.spellname log.spellid or your GetSpellInfo call.

    I suggest adding prints for all of these, including the value of spellname after it's been concatenated with log.srcname

  • mcremor posted a comment Dec 19, 2013

    I've attached a new screenshot showing the problem again. And here is the requested debug output that was printed exactly for that shown bars:

    log.spellid 5384
    local spellname: Cremor stirbt
    local spellid: 5384
    d.label: 20:20:24: Cremor stirbt
    log.spellname <nil>
    log.spellid 88163
    local spellname: Angreifen
    local spellid: 88163
    d.label: -0.22: Kalan'ii'sĀ Angreifen
    (Deleted the rest, not relevant any more.)


    Edited Jan 2, 2014
  • mcremor posted a comment Dec 22, 2013

    Some new information:

    1. I've tested it with a completely reset WoW (deleted Cache, Interface and WTF) and with only Skada (r477) installed running in its default settings. Same problem.

    2. I've tested version r458 (the one before you started your changes) under the same conditions. Same problem. Since I'm 100% sure that the bug didn't exist in version r458 before patch 5.4.2, I have to assume that Blizzard changed something that caused the bug.

    3. I also noticed that the text on the bars on the death module behave different from the text of all other modules. The text in the death module breaks to a second line if the window gets to small (which is a bug by itself in my opinion), all other modules just cut the text off and replace the last few chars with "...". Maybe whatever code that controls that behaviour is bugged?

  • mcremor posted a comment Jan 2, 2014

    I've now debugged this down to label:SetText in SpecializedLibBars-1.0. The whole label (including spell name) is correctly set to the FontString at all times.

    I've even found a situation where just a part in the middle of the FontString is missing when it is wrapped to a second line at the exact correct width. See the newly attached screenshot for that situation (the spell name is "Dreckige Tatzen" but it only shows "Tatzen").

    It also seems like not all fonts are affected. If I change the font to "Arial Narrow" or a few other fonts everything is shown fine. But some fonts, like the default one, show the bug. And with the fonts that are not affected no wrapping occurs either. But it's not just the wrapping that causes the problem, because if I call :SetWordWrap(false) on the FontString the wrapping is gone but the spell names are still not shown for affected fonts.

  • zarnivoop posted a comment Dec 23, 2014

    Is this still a thing? I can not reproduce it myself. Closing for now - re-open if it still applies.

  • zarnivoop removed a tag New Dec 23, 2014
  • zarnivoop added a tag Declined Dec 23, 2014
  • zarnivoop closed issue Dec 23, 2014
  • mcremor posted a comment Jan 2, 2015

    Yes, this is still bugged with r602 in WoW 6.0.3. I've attached two new screenshots that show exactly the same data, one with missing spell names using the default font (Accidental Presidency), one with shown spell names using Arial Narrow.


To post a comment, please login or register a new account.