WowAce

My skada is no longer keeping segments of fight anymore. It either does Total Overall fights (all of them together) or Only the current fight. I can not look at past fights anymore? Deleted and redownloaded anything else i should do? I checked options it says I should have at least 10 segments kept.

Are you only saving boss fights? Are you using "aggressive combat detection"?

Same thing happens to me. I have both options enabled.

I find that I have similar problems. Skada only acknowledges some boss fights, but not others. Storing segments doesn't seem to work correctly in Cata.

FWIW, I have "only keep boss fights" off, "aggressive combat detection" on, and segments show up just fine for me.

same problem here

only keep boss fights > off aggressive combat detection > on/off

So I've occasionally noticed this problem as well (segments never appearing for some non-boss combats), and finally took the time to track down why it happens for me. It basically boils down to a flaw in the Skada segmentation algorithm, one which is present regardless of the "aggressive combat detection" mode.

In a nutshell, Skada will not create a segment for any encounter where the only enemy is "neutral" (ie yellow before it was pulled, not "hostile" red). Makes no difference how long or in-depth the combat is, the segment will never get saved if the only enemy was yellow.

The offending code is in Skada.lua COMBAT_LOG_EVENT_UNFILTERED():

        if Skada.current and src_is_interesting and not Skada.current.gotboss then
                -- Store mob name for set name. For now, just save first unfriendly name available, or first boss available.
                if bit.band(dstFlags, COMBATLOG_OBJECT_REACTION_HOSTILE) ~=0 then
                        if not Skada.current.gotboss and boss.BossIDs[tonumber(dstGUID:sub(6, 10), 16)] then
                                Skada.current.mobname = dstName
                                Skada.current.gotboss = true
                        elseif not Skada.current.mobname then
                                Skada.current.mobname = dstName
                        end
                end
        end

and Skada:EndSegment():

function Skada:EndSegment()
        -- Save current set unless this a trivial set, or if we have the Only keep boss fights options on, and no boss in fight.
        -- A set is trivial if we have no mob name saved, or if total time for set is not more than 5 seconds.
        if not self.db.profile.onlykeepbosses or self.current.gotboss then
                if self.current.mobname ~= nil and time() - self.current.starttime > 5 then
                        -- End current set.

The check for COMBATLOG_OBJECT_REACTION_HOSTILE excludes all neutral (yellow) mobs from candidates for the mobname field to name the set. This is usually not an issue in dungeons where most mobs are hostile, but it arises frequently in outdoor combat, and VERY notably excludes target dummies!!!

I believe this check should be changed to something like the following, which will trigger from both hostile AND neutral mobs:

 if bit.band(dstFlags, COMBATLOG_OBJECT_REACTION_FRIENDLY) ==0 then

Hoping Zarnivoop can provide some comment on this, at least to verify that excluding neutral mobs was not intentional...

It was not intentional, and your solution looks good. I will add it later today for the 5.4 version.