Fish of the Day #70


  • Waiting
  • Fixed
  • Enhancement
Closed
Assigned to allarastarmist
  • Urtgard created this issue Feb 13, 2014
    Contributor

    Can you add support for the large Fish of the Day pools? http://www.elsanglin.com/fish_of_day.html

    I just heard about them and they are great for framing the Sea Turtle.

  • Urtgard added the tags New Enhancment Feb 13, 2014
  • Urtgard removed a tag Defect Feb 13, 2014
  • Urtgard added a tag Enhancement Feb 13, 2014
  • AllaraStarmist posted a comment Feb 13, 2014

    I'll look into it at some point. Fishing pools require translations, so I'll only be able to implement enUS.

    If you want to help, you could give me the enUS strings for all the pools that Rarity doesn't support. I can just add those in without testing, and let you test, which would mean I do this now versus in a few months ;)

  • Urtgard posted a comment Feb 13, 2014

    With today's pool (Large Swarm of Migrated Reef Octopus) everything works perfect.

    --Core.lua:
    R.fishnodes = {
    [L["Large Swarm of Migrated Reef Octopus"]] = true,
    [L["Large Pool of Sha-Touched Spinefish"]] = true,
    [L["Large Pool of Glowing Jade Lungfish"]] = true,
    [L["Large Pool of Crowded Redbelly Mandarin"]] = true,
    [L["Large Tangled Mantis Shrimp Cluster"]] = true,
    [L["Large Swarm of Panicked Paddlefish"]] = true,
    [L["Large Pool of Tiger Gourami Slush"]] = true,
    [L["Large Pool of Glimmering Jewel Danio Pool"]] = true,
    [L["Large Pool of Brew Frenzied Emperor Salmon"]] = true,
    ...
    }
    
    --Locales.lua:
    L["Large Swarm of Migrated Reef Octopus"] = true
    L["Large Pool of Sha-Touched Spinefish"] = true
    L["Large Pool of Glowing Jade Lungfish"] = true
    L["Large Pool of Crowded Redbelly Mandarin"] = true
    L["Large Tangled Mantis Shrimp Cluster"] = true
    L["Large Swarm of Panicked Paddlefish"] = true
    L["Large Pool of Tiger Gourami Slush"] = true
    L["Large Pool of Glimmering Jewel Danio Pool"] = true
    L["Large Pool of Brew Frenzied Emperor Salmon"] = true
    --german localization:
    L["Large Swarm of Migrated Reef Octopus"] = "Großer Schwarm gewanderter Riffkraken"
    L["Large Pool of Sha-Touched Spinefish"] = "Ein großer Schwarm Sha-berührter Stachelfische"
    L["Large Pool of Glowing Jade Lungfish"] = "Großer Schwarm leuchtender Jadelungenfische"
    L["Large Pool of Crowded Redbelly Mandarin"] = "Ein großer Schwarm wimmelnder Rotbauchmandarine"
    L["Large Tangled Mantis Shrimp Cluster"] = "Großer verhedderter Schwarm riesiger Mantisgarnelen"
    L["Large Swarm of Panicked Paddlefish"] = "Großer Schwarm panischer Krasaranglöffelstöre"
    L["Large Pool of Tiger Gourami Slush"] = "Großer Schwarm Tigerguramischlick"
    L["Large Pool of Glimmering Jewel Danio Pool"] = "Ein großer Schwarm glitzernder Juwelendanios"
    L["Large Pool of Brew Frenzied Emperor Salmon"] = "Großer Schwarm brauverrückter Kaiserlachse"
    
  • AllaraStarmist posted a comment Feb 13, 2014

    Nice! Committing now. Can you test the alpha when it gets built to see if it works? If it does, I'll tag as release.

    I need to give you some credit on this addon at this rate... :)

  • AllaraStarmist posted a comment Feb 13, 2014

    Oh I went ahead and imported the deDE translations too.

  • AllaraStarmist posted a comment Feb 13, 2014

    r236-alpha should have this functionality. It will take a few minutes for WowAce to package the build.

  • AllaraStarmist removed a tag New Feb 13, 2014
  • AllaraStarmist added a tag Waiting Feb 13, 2014
  • Urtgard posted a comment Feb 14, 2014

    No problems.

    I have noticed that the small Fish of the Day pools got different names than their normal equivalent. Only Reef Octopus Swarm is the same name.

    --Core.lua:
    R.fishnodes = {
    [L["Brew Frenzied Emperor Salmon"]] = true,
    [L["Glimmering Jewel Danio Pool"]] = true,
    [L["Tiger Gourami Slush"]] = true,
    [L["Swarm of Panicked Paddlefish"]] = true,
    [L["Tangled Mantis Shrimp Cluster"]] = true,
    [L["Crowded Redbelly Mandarin"]] = true,
    [L["Glowing Jade Lungfish"]] = true,
    [L["Sha-Touched Spinefish"]] = true,
    ...
    }
    
    --Locales.lua:
    L["Brew Frenzied Emperor Salmon"] = true
    L["Glimmering Jewel Danio Pool"] = true
    L["Tiger Gourami Slush"] = true
    L["Swarm of Panicked Paddlefish"] = true
    L["Tangled Mantis Shrimp Cluster"] = true
    L["Crowded Redbelly Mandarin"] = true
    L["Glowing Jade Lungfish"] = true
    L["Sha-Touched Spinefish"] = true
    --german localization:
    L["Brew Frenzied Emperor Salmon"] = "Brauverrückter Kaiserlachs"
    L["Glimmering Jewel Danio Pool"] = "Ein Schwarm glitzernder Juwelendanios"
    L["Tiger Gourami Slush"] = "Tigerguramischlick"
    L["Swarm of Panicked Paddlefish"] = "Ein Schwarm panischer Krasaranglöffelstöre"
    L["Tangled Mantis Shrimp Cluster"] = "Verhedderter Schwarm riesiger Mantisgarnelen"
    L["Crowded Redbelly Mandarin"] = "Ein Schwarm wimmelnder Rotbauchmandarine"
    L["Glowing Jade Lungfish"] = "Leuchtender Jadelungenfisch"
    L["Sha-Touched Spinefish"] = "Ein Schwarm Sha-berührter Stachelfische"
    
  • AllaraStarmist posted a comment Feb 14, 2014

    Thanks! I added those and went ahead and tagged it as release. If you notice any issues with this detection, go ahead and open a new ticket. Thanks again for your help!

  • AllaraStarmist removed a tag Replied Feb 14, 2014
  • AllaraStarmist added a tag Fixed Feb 14, 2014
  • AllaraStarmist closed issue Feb 14, 2014
  • Urtgard posted a comment Feb 14, 2014

    You're welcome. It's obvious that you can't farm and check every mount by yourself.

    No problems with the new version.


To post a comment, please login or register a new account.