WowAce

I've been seing this for quite some time: Rarity procs twice on a lot of items.

[10:04:20] Accursed Keepsake: 4 attempts
[10:04:20] Accursed Keepsake: 5 attempts

There is only ONE of these NPCs up, with 20 minutes intervals, and far apart, so it cannot be because multiple mobs are present.

This one I added myself (all 20 bosses in Icecrown), but I have seen it for other items from other NPCs for several months..

Using latest version available

Please provide a debug log (enable /rarity debug) of at least an instance where attempts are counted incorrectly. If it always happens for a specific item and/or NPC, mentioning those should suffice, but otherwise I won't be able to reproduce the problem.

I will try.

However, it doesn't happen every time.

Another thing I think might be related, is that an item like <Illusion: Earthliving> still procs on Valithria on my Paladin, even though it's set to exclude every class other than Shaman.

On Lich King, you actually stay in combat, until you leave the instance, so I didn't get this in the debug-log. Where is that stored?

[15:10:47] You receive loot: [Havoc's Call, Blade of Lordaeron Kings].
[15:10:47] You loot 34 Gold, 37 Silver, 94 Copper
[15:10:47] You receive loot: [Havoc's Call, Blade of Lordaeron Kings].
[15:10:47] You receive loot: [Havoc's Call, Blade of Lordaeron Kings].
[15:11:18] Invincible's Reins: 107 attempts
[15:11:18] Illusion: Rune of Razorice: 98 attempts
[15:11:21] [1] Changed Channel: [1. General - Icecrown]
[15:11:21] [3] Changed Channel: [3. LocalDefense - Icecrown]

Razorice is disabled for all classes, except DK. This run was on my Warrior (for legendary and mount). By DK have 7ish total kills of LK, so 98 is waaaaaaaaay off.

I hope this is what you need:

Scourgelord is currently where I see it most often.

[22:03:58] Rarity: Detected UNIT_SPELLCAST_SENT for unit = player, spellID = 190984, castGUID = Cast-3-3894-571-978-5176-00552EF4BE, target = Scourgelord Tyrannus
[22:03:58] Scourgelord Tyrannus yells: Power... overwhelming!
[22:04:00] Rarity: Mouse hovered over NPC with id = 0
[22:04:01] Rarity: Mouse hovered over NPC with id = 168253
[22:04:07] [RareScanner]: Shadowlands pre-patch event: Forgemaster Garfrost will spawn next! Look for the pink skull on the map.
[22:04:09] Rarity: LOOT_READY with target: Creature-0-3894-571-978-174057-00002EF421
[22:04:09] Rarity: Locking session for 1 second(s) to prevent duplicate attempts from being counted
[22:04:09] Rarity: 1 slot(s) to loot
[22:04:09] Rarity: Checking NPC guid (1): Creature-0-3894-571-978-174057-00002EF421
[22:04:09] Rarity: NPC ID is one we need: 174057
[22:04:09] Rarity: New attempt found for accursed keepsake
[22:04:09] Rarity: Starting a session
[22:04:09] Accursed Keepsake: 31 attempts
[22:04:09] Rarity: New attempt found for accursed keepsake
[22:04:09] Accursed Keepsake: 32 attempts
[22:04:10] Rarity: Unlocking session to continue scanning for new LOOT_READY events
[22:04:12] You receive loot: [Pitch Black Scourgestone]x30.
[22:04:12] Rarity: Mouse hovered over NPC with id = 168253
[22:04:13] Rarity: BAG_UPDATE

Hmm, very odd. Can you share the settings you use for this item?

I'd probably need to try and reproduce it first to see what's going on here, since the debug log doesn't give any indication as to why the second attempt was added.

As for the filtering issue, it appears someone has reported this previously (see https://github.com/SacredDuckwhale/Rarity/issues/182).

I think this should be it...

AzRwAv8CalG0TdFsVeomldIvEbiNYqe0F3YrtF+E/BRBw0jjiGqoSBosEoZT5aBIdQw5R5SFImWpSLRYRFmuSh6KiKeoHqviuaomiqqmUjGZSqZTLopIz6jquoI2iqh+i8JmUXKYyDSV81Qqn0XFaZS+Kb0WVUaLUuOpVJ1UYJnQNcE9UWkllWKtCHWZMAgOOGuC+XBQXwYH3Nx5AnzgJHULzgjLznCBNzUJ+Fv6lm4mGM8+quDCvZfxMqSBsyaYgQsluT9pgrPjN2l8RD6blcU+w7ex4sNBFWkw8CdbGh+Bkiq4sYxAfQUfvefDQQmlPQ2LRpT2dAbUR2lP56GH0p5OHw0o7emM6ERpTyehi9KeTkXlKO1pkKEylPY0yFFSlPY0LEqE0p6GiVJEaU9DQMlHaU/DoXQo7WnwUQoo7WmIKE2U9jQQSovSngZFSY7Snp4MJRlKe3pyNCpKe3qLRkJpT+dEY0RpT+fCwF2SiQ8HjRqViHw44MYyAg3gkplgPPvohKFRoxIRwQE3lhHoBJfMBOPZRxeGRo1KRBEOuLGMQEkGLpkJxrOPRoXBwEeJEeDS8wxfX7gSpcgTwvtSnv8Cl8wE49lH/f8Cg4F/NmeUbPgS4CmTD2Jq/mUmzHSjHS1nMD4JEqfn5oInG7JvF7pKMP8C

I haven't seen any duplicate attempts in my limited testing, but I noticed there's another NPC in your list that, according to wowhead, doesn't appear to be one of the Icecrown rares: https://www.wowhead.com/npc=174047/molten-champion

I don't know if these NPCs are part of the event, but they have been added recently, so it might be that you've killed and looted one of those and the second attempt? In the log you posted, there's no mention of anything like that of course, so it doesn't seem likely. I can't tell why the second attempt was added after looting the boss, however, which means I can't really do anything about it for the time being.

Fix didn't work...

Todays run in ICC resulted in this.

It tracked Invinsible, when I killed LK, but the bug kept me in combat, and once I left, it tracked it again (along with Illusion of Razorice)

[09:38:07] The Lich King yells: Impossible...
[09:38:13] Highlord Tirion Fordring yells: No more, Arthas! No more lives will be consumed by your hatred!
[09:38:16] Invincible's Reins: 110 attempts
[09:38:17] <DBM> 25 Player (Heroic) - The Lich King down after 2 |4minute:minutes; and 50.16 |4second:seconds;! Your last kill took 3 |4minute:minutes; and 24.70 |4second:seconds; and your fastest kill took 2 |4minute:minutes; and 48.49 |4second:seconds;. You have 9 total victories.
[09:38:25] <DBM> DBM has attempted to skip a cut scene automatically.
[09:38:26] You loot 35 Gold, 6 Silver, 39 Copper
[09:38:27] You receive loot: [Sealed Chest].
[09:38:27] You receive loot: [Conqueror's Mark of Sanctification].
[09:38:27] Quest accepted: Personal Property
[09:38:28] You receive loot: [Royal Scepter of Terenas II].
[09:38:28] You receive loot: [Fal'inrush, Defender of Quel'thalas].
[09:38:28] You receive loot: [Oathbinder, Charge of the Ranger-General].
[09:38:28] You receive loot: [Fal'inrush, Defender of Quel'thalas].
[09:39:11] Invincible's Reins: 111 attempts
[09:39:11] Illusion: Rune of Razorice: 101 attempts

What fix are you referring to? There wasn't any change that would fix this yet, because I didn't see any duplicate attempts previously.

Luckily, in looking into your other issue I've managed to uncover an oddity that might be the cause of the duplicate attempts, at least in the instance of the Lich King. This should hopefully help in fixing the problem, though I don't have much time to tackle it right now.

Status: https://github.com/SacredDuckwhale/Rarity/issues/213

Should be resolved (as part of the next release).