Rarity script runs too long #386


Closed
  • Forge_User_29158471 created this issue May 4, 2020

    If you're reporting a problem, please ALWAYS include the following information or I won't be able to help you!  (Suggestions or feature requests need not use this template)

    • Addon version (Example: r664-alpha)
    • Did you RESTART the game after updating the addon? (Make sure to exit and close fully the client, and not just reload your UI, to detect newly-added files)
    • Steps to reproduce the error or unwanted behaviour (If the addon won't load, make sure to enable script errors!)
    • Any other information you consider relevant or helpful in solving the problem (Screenshots, expected behaviour, things you already tried to fix the issue...)

     Thank you for understanding! It's not always easy to troubleshoot problems. Please don't make it more difficult by disregarding these suggestions.

    Rarity doesn't work after fresh install. Mouseovering on rarity icon (both broker plugin and minimap icon) cause game freeze for 15-30 sec, and gives this:

     

    Message: ...\AddOns\Broker_Cash\Libs\LibQTip-1.0\LibQTip-1.0.lua:1070: script ran too long
    Time: Mon May 4 23:40:08 2020
    Count: 1
    Stack: ...\AddOns\Broker_Cash\Libs\LibQTip-1.0\LibQTip-1.0.lua:1070: script ran too long
    [string "@Interface\AddOns\Broker_Cash\Libs\LibQTip-1.0\LibQTip-1.0.lua"]:1070: in function <...\AddOns\Broker_Cash\Libs\LibQTip-1.0\LibQTip-1.0.lua:1058>
    [string "=(tail call)"]: ?
    [string "@Interface\AddOns\Rarity\Core\GUI.lua"]:1498: in function <Interface\AddOns\Rarity\Core\GUI.lua:1127>
    [string "@Interface\AddOns\Rarity\Core\GUI.lua"]:1694: in function `ShowTooltip'
    [string "@Interface\AddOns\Rarity\Core\GUI.lua"]:404: in function `OnEnter'
    [string "@Interface\AddOns\Bazooka\Bazooka.lua"]:1583: in function `showTip'
    [string "@Interface\AddOns\Bazooka\Bazooka.lua"]:1388: in function <Interface\AddOns\Bazooka\Bazooka.lua:1379>

    Locals: tooltip = <unnamed> {
    0 = <userdata>
    regularFont = GameTooltipText {
    }
    headerFont = GameTooltipHeaderText {
    }
    key = "RarityTooltip"
    scrollFrame = <unnamed> {
    }
    anchorframe = BazookaPlugin_SavedInstances {
    }
    columns = <table> {
    }
    scrollChild = <unnamed> {
    }
    colspans = <table> {
    }
    autoHideTimerFrame = <unnamed> {
    }
    width = 896.068375
    cell_margin_h = 6
    cell_margin_v = 3
    labelProvider = <table> {
    }
    lines = <table> {
    }
    height = 4052.372141
    }
    font = GameTooltipText {
    0 = <userdata>
    }
    lineNum = 267
    line = <unnamed> {
    0 = <userdata>
    }
    (*temporary) = <function> defined =[C]:-1
    (*temporary) = <unnamed> {
    0 = <userdata>
    }
    (*temporary) = "RIGHT"
    (*temporary) = <unnamed> {
    0 = <userdata>
    }
    (*temporary) = <userdata>
    (*temporary) = <userdata>
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = "script ran too long"
    error = <function> defined =[C]:-1
    AcquireFrame = <function> defined @Interface\AddOns\Broker_Cash\Libs\LibQTip-1.0\LibQTip-1.0.lua:170
    CELL_MARGIN_V = 3
    SetTooltipSize = <function> defined @Interface\AddOns\Broker_Cash\Libs\LibQTip-1.0\LibQTip-1.0.lua:831
    AcquireTable = <function> defined @Interface\AddOns\Broker_Cash\Libs\LibQTip-1.0\LibQTip-1.0.lua:493
    select = <function> defined =[C]:-1
    _SetCell = <function> defined @Interface\AddOns\Broker_Cash\Libs\LibQTip-1.0\LibQTip-1.0.lua:930

    The lua error varies, it persists even if other plugins and data brokers are disabled. 

     

    Could this be because I have too much mounts/pets in the tracking list?

  • RDW posted a comment May 14, 2020

    Yes, this is caused by having "too many" items that the tooltip library cannot display efficiently.

     

    It can't be fixed easily, as I didn't write any of the code that is doing all this (and the original developer is gone), so the workaround is to minimize some categories or otherwise reduce the amount of items displayed all at once ("show items only in the current zone", "only show X expansion items" etc).

  • RDW closed issue Jul 18, 2021
  • RDW posted a comment Jul 18, 2021

     

    Half of this problem should be fixed in the latest release. The other half is due to some limitations of the WOW UI and we're looking into workarounds to the problem. However, it should be much more usable now in virtually all scenarios.

     

    If you're still experiencing significant a performance drops after updating, please open a new issue.


To post a comment, please login or register a new account.