Rarity causing temporary game freeze #345


Closed
  • djfreezingcold created this issue Jul 3, 2019

    If you're reporting a problem, please ALWAYS include the following information or I won't be able to help you!  (Suggestions or feature requests need not use this template)

    • Addon version (Example: r664-alpha)
    • Did you RESTART the game after updating the addon? (Make sure to exit and close fully the client, and not just reload your UI, to detect newly-added files)
    • Steps to reproduce the error or unwanted behaviour (If the addon won't load, make sure to enable script errors!)
    • Any other information you consider relevant or helpful in solving the problem (Screenshots, expected behaviour, things you already tried to fix the issue...)

     Thank you for understanding! It's not always easy to troubleshoot problems. Please don't make it more difficult by disregarding these suggestions.

     It seems like with 8.2 people (including me) are noticing the game freezing up for a few seconds after logging into the game with this addon enabled. There's a discussion going on in /r/wow right now - https://old.reddit.com/r/wow/comments/c8hfn4/anybody_here_getting_510_second_lags_after/

    I'm not at my gaming computer right now but it is the most recent version available on curseforge. It happens just before the grey Rarity text loads in the chat box. Happening to several players.

  • Cakechart posted a comment Jul 5, 2019

    Thanks! There have been reports of freezes on login taking an excessive amount of time, but unfortunately I was unable to reproduce the exact problem.

     

    I'm not sure if this is the same issue or a new one, but I recall that changing the sort order could significantly speed up the loading time of the tooltip window due to how Rarity and the tooltip library it uses handle the data internally. The entire process might benefit from some more optimization, but not only am I unfamiliar with the internals, I also don't have time to find all the performance bottlenecks in the addon with how busy things are currently.

     

    I'll definitely look into this as soon as I can, but unless it's a new issue caused by the patch that I can readily reproduce, I likely won't have time to troubleshoot it further right now. Sorry!

  • DivanGuy posted a comment Jul 15, 2019

    Same problem for me. Game freeze for about 5 sec about after 15 sec i log in.

    I have many alts and relog a lot so it's too annoying so i have to disable this addon.

    Can i disable some features of the addon so i can use it again or should i wait for a fix?

  • Cakechart posted a comment Jul 16, 2019

    Try changing the sort order. Other than that, can't really do much right now because I don't have the time and the addon's tooltip loading is a bit... complicated, to say the least.

     

    The freeze duration can hopefully be shortened, though it may also depend on your hardware. For me, it's noticeable but not nearly as long (< 1 sec).

  • DivanGuy posted a comment Jul 16, 2019

    I'm multiboxing with 5 game clients. I have a decent PC so it's not a hardware issue.

  • Cakechart posted a comment Jul 18, 2019

    Another user reported that the tooltip library, LibQTip, ran too long and hence execution was stopped by the game client. Are there any Lua errors occuring shortly after the freeze (see FAQ for how to enable them)? And I assume the tooltip is still being shown? If so, it's probably a different issue, though I don't know for sure :P

     

    People are reporting all sorts of freeze issues and yet I've not seen anything as significant as has been described. Without more information, I'm sorry to say that I'm not sure what I can do :(

  • lechatron posted a comment Jul 18, 2019

    After a bit of fiddling I found what was causing the freeze for my game. Checking the box "Hide items not in your zone" has fixed the few second freeze that has been happening since 8.2. Hopefully that helps track down the root cause, or fixes the problem for other users.

  • Ymmuy posted a comment Jul 19, 2019

    I turned on debug and profiling.  

     

    23:10:35] Rarity: Loading 800 item(s) from server...
    [23:10:35] Rarity: addGroup(Mounts, nil) took 175.423800ms (Total: 175.413900, Sort: 6.313500, Iteration: 169.094000, Tooltip: 0.000300
    [23:10:37] Rarity: addGroup(Battle Pets, nil) took 1971.707200ms (Total: 1971.694800, Sort: 40.749100, Iteration: 1930.939300, Tooltip: 0.000200
    [23:10:38] Rarity: addGroup(Toys & Items, nil) took 1047.373700ms (Total: 1047.361100, Sort: 8.336000, Iteration: 1039.018100, Tooltip: 0.000200
    [23:10:38] Rarity: addGroup(Custom, nil) took 0.022000ms (Total: 0.012700, Sort: 0.004200, Iteration: 0.000500, Tooltip: 0.000200
    [23:10:38] Rarity: addGroup(Mounts, true) took 532.989300ms (Total: 532.974600, Sort: 8.211100, Iteration: 524.760300, Tooltip: 0.000200
    [23:10:40] Rarity: addGroup(Battle Pets, true) took 1258.466500ms (Total: 1258.453800, Sort: 33.298400, Iteration: 1225.147100, Tooltip: 0.000200
    [23:10:40] Rarity: addGroup(Toys & Items, true) took 324.230600ms (Total: 324.215200, Sort: 8.554900, Iteration: 315.652800, Tooltip: 0.000200
    [23:10:40] Rarity: addGroup(Custom, true) took 0.021000ms (Total: 0.012800, Sort: 0.004400, Iteration: 0.000400, Tooltip: 0.000100
    [23:10:40] Rarity: Tooltip rendering took 5330.318100ms (175.487800, 1971.804500, 1047.466500, 0.065200, 533.057000, 1258.535800, 324.304600, 0.060700)
    [23:10:40] Rarity: UpdateText: 0.045700m

  • Amenitra posted a comment Jul 19, 2019

    Hello, I have the same problem. Screen freezes when logging in. And also the screen freezes when I go over the Minimap button. Is that right?

    I read Lechatron tip. Now everything is good. But I like to look over the minimap button which mounts I do not have yet. So I prefer the complete overview. Will the problem be solved?

  • Cakechart posted a comment Jul 19, 2019

    Yes, I will look into it improving the tooltip UI as soon as I am able. It appears to be a huge problem, and from what I've seen it's caused by the tooltip library in combination with the rather large amount of collectibles Rarity is now tracking.

     

    I'm sure when the addon was first developed, there weren't as many things to manage, and perhaps the issue has gotten worse over time because the UI was never designed for this many items. I can't say for sure before looking into it more, but poor scaling of the tooltip display/sort algorithms appears to be the most likely cause, assuming Blizzard hasn't suddenly changed something in the most recent patch.

     

    Unfortunately, it will be a few weeks until I can hopefully dedicate more time to working on Rarity again. Things are quite busy, but I am keeping tabs on the issues reported (and updating them on GitHub) as best as I can!

  • commandpostkyle posted a comment Jul 24, 2019

    Checking "Hide items not in your zone" fixed the issue for me. This was happening when I logged in or did /reload.

  • Amenitra posted a comment Jul 29, 2019

    @Cakechart great, have many thanks for the great work. And thank you for your time. :)

  • retrogamer064 posted a comment Oct 4, 2019

    @Cakechart any update on progress on the proper fix for this issue? Thanks


    Edited Oct 5, 2019
  • Cakechart posted a comment Oct 10, 2019

    A proper fix would probably involve rewriting quite a bit of the addon's core and risk breaking a lot of things I'm not overly familiar with (as I'm not the original author). So far I'm not even 100% sure what the exact problem is for some of the reports I've seen.

     

    For that reason, I'm afraid I can't  give any ETA. You'll have to fiddle around with the settings to minimize the impact of the scan, for the time being. Sorry!

  • retrogamer064 posted a comment Oct 10, 2019

    Thanks for the update

  • betchfromhel posted a comment Feb 1, 2020

    Lechatron's post to'hide items not in zone' in the options worked for me!! Thank you!!

  • Cakechart posted a comment Feb 27, 2020

    I've looked into this problem (again...), and it appears I can only reproduce the delay on showing the tooltip with a lot of items enabled (LibQTip/script ran too long errors etc.).

     

    Can anyone provide me with a debug log of the freezes that apparently occur when logging in? I don't seem to have any, but I'm not sure if they're the same issue or caused by something else entirely.

  • celithe posted a comment May 5, 2020

    I can confirm that collapsing other groups like battle pets, will resolve the issue since someone i know installed the addon and is experiencing issues. comparing settings i ONLY have mounts expanded, the other groups are collapsed. If i want to use those i expand only that group, i am able to use the addon without issues.

  • Cakechart posted a comment May 14, 2020

    Having too many uncollected/displayed items definitely causes problems, but I'm not sure if it's the ONLY problem. So far the workaround still is to minimize the amount of items being displayed, which isn't ideal but cannot currently be helped.

  • mspykez posted a comment Dec 16, 2020

    Is this been fixed?

  • Cakechart closed issue Jul 18, 2021
  • Cakechart posted a comment Jul 18, 2021

     

    Half of this problem should be fixed in the latest release. The other half is due to some limitations of the WOW UI and we're looking into workarounds to the problem. However, it should be much more usable now in virtually all scenarios.

     

    If you're still experiencing significant a performance drops after updating, please open a new issue.


To post a comment, please login or register a new account.