WowAce

Addon version: r680-release

I've tried out this addon because I started farming Skyshards, and I noticed that it does not seem to consider the Guo Lai Halls zone as part of the items farming zone. I can confirm that it counts as one, as I dropped a shard there just today.

The item from the build-in database seems not to be editable, and I was also not able to add a custom tracking for an item already in the database, so I could not add the zone manually.

Thanks! The Battle for Azeroth prepatch has drastically changed how Blizzard's World Map works, and as a result I suspect some subzones aren't detected correctly because their IDs are different from the actual zone and haven't been added to the database when I translated the old format semi-automatically.

Unfortunately, I can't reasonably find all of them myself, but I will add this particular one in the next version. Let me know if there are any others!

You can't edit the default entries via the graphical interface because they're hardcoded in the item database. Until I've fixed it in the release version you could edit your local copy of Options_Default.lua and add the correct subzone ID to the entry for "Skyshard".

Alright! Thanks for the response, I'll be awaiting a new release and modify the database on my own for now. Keep up the good work! :D

Edit:

Not sure how easy your code architecture would allow this, but would it be possible to add the ability to override build-in databse entries with custom entries, so that you can fix temporary issues like this on your own? That is, instead of changing the build-in database, just ignore an entry if you redefined it in the custom section.

Yes, that would be possible. I think the benefit of overriding invalid entries more conveniently is far smaller than the drawback of users "accidentally" overriding updated entries without noticing, however.

For that reason, I probably won't be implementing any such feature, as it is virtually guaranteed to create unnecessary bug reports if someone forgets they set an entry manually that is now outdated. If there's a more compelling argument to be made, I might reconsider, but as it is I'd rather err on the side of caution.

---

The subzone ID should be added in the latest release. I'm therefore closing this as resolved, though you are free to create a separate issue for the suggestion you added if you believe it warrants further discussion.