[Waiting on localization] Glimmering Falanaar Treasure Chest #232


  • Enhancement
Closed
  • Urtgard created this issue May 30, 2017
    Contributor

     

    The Glimmering Falanaar Treasure Chest at the end of  Withered Army Training contains some toys and one item to start a quest for a mount.

     

    0.5% drop:

     

    3% drops:

     

    In the course of this week I'll update this ticket with the data.

  • Urtgard added a tag Enhancement May 30, 2017
  • Urtgard edited description May 30, 2017
  • Urtgard posted a comment Jun 6, 2017
    --Mount
    ["Torn Invitation"] = { cat = LEGION, type = MOUNT, method = USE, name = L["Torn Invitation"], spellId = 171850, itemId = 140495, items = { 252452 }, chance = 200, questId = 43943,  sourceText = "The quest starter item for  Reins of the Llothien Prowler" },
    
    --Toys
    ["Arcano-Shower"] = { cat = LEGION, type = ITEM, isToy = true, method = USE, name = L["Arcano-Shower"], itemId = 141297, items = { 252452 }, chance = 33, questId = 43943 },
    ["Displacer Meditation Stone"] = { cat = LEGION, type = ITEM, isToy = true, method = USE, name = L["Displacer Meditation Stone"], itemId = 141298, items = { 252452 }, chance = 33, questId = 43943 },
    ["Kaldorei Light Globe"] = { cat = LEGION, type = ITEM, isToy = true, method = USE, name = L["Kaldorei Light Globe"], itemId = 141299, items = { 252452 }, chance = 33, questId = 43943 },
    ["Unstable Powder Box"] = { cat = LEGION, type = ITEM, isToy = true, method = USE, name = L["Unstable Powder Box"], itemId = 141301, items = { 252452 }, chance = 33, questId = 43943 },
    ["Wisp in a Bottle"] = { cat = LEGION, type = ITEM, isToy = true, method = USE, name = L["Wisp in a Bottle"], itemId = 141306, items = { 252452 }, chance = 33, questId = 43943 },
    ["Ley Spider Eggs"] = { cat = LEGION, type = ITEM, isToy = true, method = USE, name = L["Ley Spider Eggs"], itemId = 140786, items = { 252452 }, chance = 33, questId = 43943 },

     

  • AllaraStarmist posted a comment Jun 6, 2017

    Thanks! I'll get those in.

  • Urtgard posted a comment Jun 16, 2017

    I opened 2 chests but Rarity didn't count my attempts.

     

    Are 7 items from one source too much? I thought only the progressbar can handle only a limited amount of items.

     

    Or have I messed up something with the data?

     

    Though I got one toy and Rarity shows the correct notification. At least something works.

  • AllaraStarmist posted a comment Jun 16, 2017

    Is it a world object? You have to add tooltip scanning manually to the code and all translations. Rarity can't support world object detection any other way because the client only reports it in mouse over tooltips. Look in the code for where we handle chests in Timeless Isle. 

     

    7 items from one source is fine but the progress bars will only show two of them essentially at random.

  • Urtgard posted a comment Jun 17, 2017

    Ah, didn't know that about world objects. I thougut it would work just like container in your bags.

     

    I'll look at the Timeless Isle data.

  • Urtgard posted a comment Jun 20, 2017

    Wow, every chest is called "Glimmering Treasure Chest". The big, medium and small reward chest, the chests you can get only one time and chests all over the Broken Isles.

     

    We need to check whether we are in the scenario or not. Easy with the mapID from GetInstanceInfo().

     

    The big chest we need to track always rewards 100 Ancient Mana. 

    What would be the best way to check this? With GetLootInfo()?

  • AllaraStarmist posted a comment Jun 20, 2017

    Yeah, I guess you'd have to put special code in loot detection. As you know, I'm no longer subscribed. And (this next sentence is going to sound angry but it's directed at Blizzard and not you): even if I was subscribed, you could never get me to set foot in Withered Training. In fact it is one of many reasons I finally quit the game!

     

    Haha. All that to say that you're on your own on this one! If you can get it working really well, I'll do a code review and add it. Just be aware that world objects require localizations before they work in non-English languages.

     

    And yes, with world objects I always put in a check for the map, though you can probably just do a generic map test and not need GetInstanceInfo(), assuming Withered Training gets its own map (maybe it doesn't).

     

    Are we sure this one is worth tracking? This sounds a little bit outside what I'm usually comfortable with.

  • Urtgard posted a comment Jun 20, 2017

    That's what I came up with: https://pastebin.com/THrG4Dm5
    Could test it only once, but it seems to work like it should.

     

    Was easier than expected. Or did I miss something?

     

    Data for OptionsDefaults.lua: https://pastebin.com/TyKfLE1E

     

    If you add it to Rarity I'll add the translations through the wowace localization tool.

  • AllaraStarmist posted a comment Jun 21, 2017

    This looks good to me without testing. I'll get it in and the others soon.

  • AllaraStarmist edited title Jun 27, 2017
  • AllaraStarmist posted a comment Jun 27, 2017

    Waiting on localization for Glimmering Treasure Chest.

     

    Also just a quick note: the syntax for mapID was wrong, it should be: 

    coords = {{m=1033}}

     

    You had left out the m=

  • AllaraStarmist posted a comment Jun 27, 2017

    Looks like localization needed for Ancient Mana as well

  • Urtgard posted a comment Jun 27, 2017

    Added all but Korean and Chinese localizations for both (Chest and Mana). Wowhead doesn't have localizations for them. I need to get them from the game.

    And Latin American Spanish localization for Glimmering Treasure Chest is missing.

  • AllaraStarmist closed issue Jul 17, 2017

To post a comment, please login or register a new account.