Timewalking mount. #167


  • Fixed
Closed
Assigned to Allara
  • Urtgard created this issue Nov 16, 2015
    Contributor

    Known bugs:

    • Does not count attempts for Ozumat
    • Siamat is missing (44819)
    • Lockmaw (43614) is not needed

    ————————
    Original ticket:
    The Reins of the Infinite Timereaver can drop from any Timewalking boss.
    Can you just check if you looted a timewalking boss or do you need all the npc ids?

  • Urtgard added the tags New Enhancment Nov 16, 2015
  • Allara posted a comment Nov 16, 2015

    I need all the NPC IDs and I need to add support for Timewalking itself, which I hope is just another instance type.

  • Urtgard posted a comment Nov 16, 2015

    Yes, timewalking is just another difficulty (24). Propably not new to you: http://wowprogramming.com/docs/api/GetInstanceInfo

    I'll make the ID list tomorrow.

  • Allara posted a comment Nov 16, 2015

    Yup that's what Rarity already uses, just need to add 24 to the list. Thanks!

  • Urtgard posted a comment Nov 17, 2015

    I hope I didn't overlooked a boss:

    {24723, 24744, 24560, 24664, 17941, 17991, 17942, 16807, 20923, 16809, 16808, 18341, 18343, 18344, 22930, 17879, 17880, 17881, 20870, 20885, 20886, 20912, 36494, 36476, 36658, 26668, 26687, 26693, 26861, 26731, 26763, 26794, 26723, 26796, 26798, 28586, 28587, 28546, 28923, 29304, 29573, 29305, 29306, 29932, 29309, 29308, 29310, 29311, 30258, 40586, 40765, 40788, 44566, 43878, 43873, 43875, 43438, 43214, 42188, 42333, 44577, 43612, 43614, 49045, 39625, 40177, 40319, 40484}
    

    Only problem I noticed: Ozumats loot is in a chest and not in his body. (The big octopus in Throne of the Tides)

  • Allara posted a comment Nov 17, 2015

    That's ok. Did you include Ozumat's NPC ID? Rarity will watch for the boss to be killed nearby and count the attempt when that happens.

  • Allara removed a tag New Nov 17, 2015
  • Allara added a tag Fixed Nov 17, 2015
  • Allara closed issue Nov 17, 2015
  • Urtgard posted a comment Nov 17, 2015

    Yes. I included his ID.

  • Urtgard posted a comment Nov 18, 2015

    I missed the End Time bosses: {54431, 5445, 54123, 54544, 54432}

  • Urtgard posted a comment Nov 18, 2015

    I run a few dungeons myself and found some bugs:

    • Does not count attempts for Ozumat
    • Siamat is missing (44819)
    • Lockmaw (43614) is not needed. Augh is the "real" boss which provides the loot. His ID is already in the list.

    Edited Nov 18, 2015
  • Allara posted a comment Nov 18, 2015

    Is Ozumat the only one so far that isn't counting? Are any others working? Is he in the list? Can you kill him again with debug mode on and post the results?

  • Allara removed a tag Fixed Nov 18, 2015
  • Allara added a tag Accepted Nov 18, 2015
  • Allara reopened issue Nov 18, 2015
  • Urtgard posted a comment Nov 18, 2015

    Everything else I did works fine. It is in the list. Can't say anyting about End Time. I'll post the debug, if I get him again.

    You use COMBAT_LOG_EVENT_UNFILTERED and UNIT_DIED to detect these kills? Ozumat doesn't really die, he just flee. Maybe UNIT_DIED doesn't fire.

  • Allara posted a comment Nov 18, 2015

    Yeah I use UNIT_DIED. That's a problem, then, hmm. I wonder if anything else unique dies once during that fight or at the end. I can't use the statistic because it doesn't differentiate Timewalking.

  • Urtgard posted a comment Nov 18, 2015

    There is some npc and Ozumat takes him. Maybe he fires some interesting event. I didn't noticed an unique enemy.

    Sadly ENCOUNTER_END seems to only work in raids according to http://wowprogramming.com/. I guess an easy way would be the objective tracker or something lika a DUNGEON_COMPLETED event.

  • don_Sefer posted a comment Nov 19, 2015

    The Boss list is wrong for "Lost City of the Tol'vir". You are using the IDs 43614 (Lockmaw) and 49045 (Augh) so it is counted twice.

    You actually loot 49045 (Augh) and you can loot him only!

  • Urtgard edited description Nov 19, 2015
  • Urtgard posted a comment Nov 19, 2015

    Update so people don't need to read all the comments.

    What do you plan about Ozumat. A little hack or allow different ways of collecting for one Item? I guess for now a little hack would be easier.


    Edited Nov 19, 2015
  • Allara posted a comment Nov 19, 2015

    FYI I'm out of town for a couple weeks and won't be able to address anything until I get back. I won't be able to write custom code for this, so if we can't figure out a single unique NPC that dies in the Ozumat encounter, we just won't be able to detect that fight for now.

  • Urtgard posted a comment Nov 19, 2015

    Jaina ID is wrong. 54445 not 5445.

  • Urtgard posted a comment Nov 19, 2015

    So, this sould now be the correct npc list:

    { 24723, 24744, 24560, 24664, 17941, 17991, 17942, 16807, 20923, 16809, 16808, 18341, 18343, 18344, 22930, 17879, 17880, 17881, 20870, 20885, 20886, 20912, 36494, 36476, 36658, 26668, 26687, 26693, 26861, 26731, 26763, 26794, 26723, 26796, 26798, 28586, 28587, 28546, 28923, 29304, 29573, 29305, 29306, 29932, 29309, 29308, 29310, 29311, 30258, 40586, 40765, 40788, 44566, 43878, 43873, 43875, 43438, 43214, 42188, 42333, 44577, 43612, 44819, 49045, 39625, 40177, 40319, 40484, 54431, 54445, 54123, 54544, 54432, }
    

    And I found an easy way to count Ozumat and Murozond (same problem like Ozumat). The event CRITERIA_COMPLETE fires when you kill a timewalking boss. It returns a id. For Ozumat 24801 and for Murozond 24803.
    What I'll use till you're back :D

    function TimereaverFix(self, event, id)
    	--Ozumat: 24801, Murozond: 24803
    	_,_,difficulty = GetInstanceInfo()
    	if difficulty == 24 and (id == 24801 or id == 24803) then
    		local v = R.db.profile.groups.mounts["Reins of the Infinite Timereaver"]
    		if v and type(v) == "table" and v.enabled ~= false then
    	    	if v.attempts == nil then v.attempts = 1 else v.attempts = v.attempts + 1 end
    	    	R:OutputAttempts(v)
    		end
    	end
    end
    
    local TimereaverFix_Frame = CreateFrame("Frame")
    TimereaverFix_Frame:RegisterEvent("CRITERIA_COMPLETE")
    TimereaverFix_Frame:SetScript("OnEvent", TimereaverFix)
    

    Edited Nov 23, 2015
  • don_Sefer posted a comment Nov 21, 2015

    @Urtgard: Go

    Do I add the timereaverfix to the end of Core.lua?

    EDIT: Finally a dungeon with a chest xD Yep, working


    Edited Nov 21, 2015
  • Allara posted a comment Nov 24, 2015

    I'm back for one day, then gone again for a week. I'll be putting in the fixes here and leaving the ticket open. Note that I'll continue to include Ozumat and Murozond in the NPC ID list in order to enable tooltips for them.

    Thanks so much for everyone's assistance with this!


    Edited Nov 24, 2015
  • Allara removed a tag Accepted Apr 19, 2016
  • Allara added a tag Fixed Apr 19, 2016
  • Allara closed issue Apr 19, 2016

To post a comment, please login or register a new account.