nQuestLog
Questing minion
---
August 20, 2009: I have started the tear-down/rebuild of this addon and will keep this description updated as I go. My path will be:
1) DONE - Thanks Fyrye. Update the libraries so we can get it working without yelling at you, albeit with a bit of tweaking
2) Update the code to work with the new questlog api
3) Recode and reduction of external library dependancy
nQuestlogEvents.lua
* GetDiffcultyColor -> GetQuestDifficultyColor
modules/Coloring/Coloring.lua
* QuestDifficultyColor -> QuestDifficultyColors
* GetDiffcultyColor -> GetQuestDifficultyColor
modules/DetailsFrame/DetailsFrame.lua
* GetDiffcultyColor -> GetQuestDifficultyColor
Looking at the code, the author said he pulled it from FuBar_QuestsFU, that addon had the same error so the fix is:
* QUESTS_DISPLAYED -> #QuestLogScrollFrame.buttons
Seemed to work for me.
In total, changes made were :
nQuestLog\modules\Coloring\Coloring.lua
GetDifficultyColor -to- GetQuestDifficultyColor 3 times
QuestDifficultyColor -to- QuestDifficultyColors 6 times {do not do auto find and replace if you use notepad, you'll overwrite the 3 "GetQuestDifficultyColor" above}
nQuestLog\modules\Comments\Comments.lua
GetDifficultyColor -to- GetQuestDifficultyColor 4 times
nQuestLog\modules\DetailsFrame\DetailsFrame.lua
GetDifficultyColor -to- GetQuestDifficultyColor 2 times
nQuestLog\nQuestLogEvents.lua
GetDifficultyColor -to- GetQuestDifficultyColor 1 time
nQuestLog\modules\BlizzardFrames\BlizzardFrames.lua
QUESTS_DISPLAYED -to- #QuestLogScrollFrame.buttons
Thank you all for doing this so the coding inept like myself can still use this mod. Milk and cookies for you all!
You also must change QuestDifficultyColor as well, so in all.
nQuestlogEvents.lua
modules/Coloring/Coloring.lua
modules/DetailsFrame/DetailsFrame.lua
I found a fix for nQuestlog
in nQuestlogEvents.lua and Modules/Coloring/Coloring.lua, do a search and replace
GetDiffcultyColor -> GetQuestDifficultyColor.
I am not a coder. Just read a changelog of another addon that guided me to this hotfix.
Any ETA when this great addon will be updated for 3.2? or is it no longer being supported. If no longer supported. What might be a good replacement? really like the ease of this one.
Any chance when you update this you can add LDB support please?
[2009/06/21 15:30:56-5-x4]: nQuestLog-1.0 r%d.235\nQuestLogCore.lua:295: attempt to perform arithmetic on local 'iGot' (a nil value)
nQuestLog-1.0 r%d.235\nQuestLogFuBar.lua:164: in function <Interface\AddOns\nQuestLog\nQuestLogFuBar.lua:163>
(tail call): ?:
FuBarPlugin-2.0-90009:991: in function <...oft\AloftFu\Libs\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:989>
FuBar-3.0.90012\FuBar.lua:1213: in function <Interface\AddOns\FuBar\FuBar.lua:1207>
Tablet-2.0-90216 (FuBar):2556: in function <...nterface\AddOns\FuBar\libs\Tablet-2.0\Tablet-2.0.lua:2554>
I'm unable to view any settings in the FuBar plugin and I can't even expand the zones in the minion to view what quests I have.
Hi, is it possible to add the Archivment-tracker into your Questlog tracker?
it would be nice !
btw, i love your QuestAddon! Keep up the good work
Thanks
Drago!
it would be nice !
btw, i love your QuestAddon! Keep up the good work
Thanks
Drago!
Wouldn't an easier fix be to handle the notification check through OnQuest_Objective_Update and OnQuest_Complete, removing the localized string check for "and ( message:match(L["blizzProgressPattern"])"? I guess it depends on what order the functions are fired vs the UIErrorsFrame_OnEvent, not very familiar with Quixote events. But I believe that would free up some of the resources being used by nQuestLog as well, not having to check the UIErrorFrame message each time one was thrown.
I guess another alternative would be a regex pattern match that excluded slain or other variables in the quest objective match
the duplicate progression is much more involved than would 1st appear:
pre 3.0 example - blizzard message "bone scout 1/10" nquestlog would also generate "bone scout 1/10". now nquestlog would string match that to what is being pushed through UIErrorsFrame and block it if the 2 strings matched.
post 3.1 (same example) blizzard message "bone scout slain: 1/10", nquestlog still only gives "bone scout 1/10" so the problem now is nquestlog fails to produce a match between the 2 strings thus doesn't block the blizz message.
Heres the problem - the word "slain" doesnt always appear in the progress messages eg blizz 3.1 example "..plank collected: 3/12" nquestlog would generate "..plank collected 3/10", its easy to fix the missing ":" but not easy to dynamically insert/remove "slain".
at present the nQL string is passed as a finished article to the UIErrorsFrame hook in notifications, this message either needs to be split back down or passed as component parts such that a reduced accuracy check can be done, the problem then arises when you have multiple quests that involve the same thing such as the champion kill scourge quest AND the valiant kill scourge quest, both would update progress but its not easy to guess how a reduced accrucacy string match would function here, would both the blizz messages be blocked or would only the 1st or the 2nd message be blocked
See the bottom lines of #27565
any chance to kill the quest progression on blizzard error frame?
There's at least one outdated library causing issues, and the amount of code used is too much for me to just pick it up. I'll rewrite it from scratch, keeping existing functionality and layout of the addon. For now you can apply the fixes posted in here to keep it working.