In reply to Ketho17: Thank you. I noticed a small issue I wanted to let you know about. I use Baganator, but with the built in "Dark" theme. Your fix works with the "Blizzard" theme, but doesn't work with the "Dark" theme because it changes the frame names (replaces blizzard with dark in the frame names). Simply copying/pasting your two if statement Baganator fixes and changing blizzard to dark (so there are 4 if statements in total) works to fix the issue.
to fix the "attempt to index global 'AccountBankPanel' (a nil value)" error, I did this and it seems to be working fine.
in LargerMacroIconSelection.lua, change line 37 from
self:Initialize(AccountBankPanel.TabSettingsMenu)
to
self:Initialize(BankPanel.TabSettingsMenu)
There were numerous changes to the bank in 11.2, i.e. No more bank bags or Reagent bank or Void storage. When doing this, they changed the names of some functions and globals.
Is it just me, or is this addon just kaput? I tried to install it for the first time ever 5 weeks ago after finding out about it, but then when I logged in and tried to make a new macro, everything was just in vanilla form, as if the addon wasn't installed at all.
2. go to the addon path (..\World of Warcraft\_retail_\Interface\AddOns\LargerMacroIconSelectionData) and replace the file IconFileNames.lua with the new file you downloaded.
3. restart WoW and you should also see the latest patch 11.1 icons.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Added support for the bank when using Baganator in v1.10.1
In reply to Ketho17: Thank you. I noticed a small issue I wanted to let you know about. I use Baganator, but with the built in "Dark" theme. Your fix works with the "Blizzard" theme, but doesn't work with the "Dark" theme because it changes the frame names (replaces blizzard with dark in the frame names). Simply copying/pasting your two if statement Baganator fixes and changing blizzard to dark (so there are 4 if statements in total) works to fix the issue.
Thanks again for the PR
Yay it's updated for patch 11.2.0 sorry that it had to wait and enjoy looking for icons
In reply to Ketho17: Thanks for the fix. It's surprising just how handy your addon is, especially when you play a lot of alts.
Hi, I'm in the process on updating the addon right now 🫡
and sorry for the few days delay, I needed to work on my wow vscode extension first
Thanks!
Change AccountBankPanel to just BankPanel in line 37 in LargerMacroIconSelection.lua.
This will let the addon load and add the search line to the new Bank panel
I found the problem. It doesn't work when using Baganator.
Yeah it looks like it won't show the search box when Baganator is enabled, I will have to look into it further
how to fix:
open LargerMacroIconSelection.lua
remove line 37: self:Initialize(AccountBankPanel.TabSettingsMenu)
save
HF
Actually in addition to the error message below, 11.2 seems to have totally broken the search function: the search text input is just gone
Error message for 11.2:
...argerMacroIconSelection/LargerMacroIconSelection.lua:37: attempt to index global 'AccountBankPanel' (a nil value)
[Interface/AddOns/LargerMacroIconSelection/LargerMacroIconSelection.lua]:37: in function <...argerMacroIconSelection/LargerMacroIconSelection.lua:31>
self = Frame {
searchIcons = <table> {
}
isMainline = true
isCata = false
loadedFrames = <table> {
}
isVanilla = false
}
event = "ADDON_LOADED"
addon = "LargerMacroIconSelection"
(*temporary) = Frame {
searchIcons = <table> {
}
isMainline = true
isCata = false
loadedFrames = <table> {
}
isVanilla = false
}
(*temporary) = nil
(*temporary) = "attempt to index global 'AccountBankPanel' (a nil value)"
Thanks for your work on this addon, it is *really* helpful
Please update for 11.2! The character banks now have tabs similar to the Warband Bank.
to fix the "attempt to index global 'AccountBankPanel' (a nil value)" error, I did this and it seems to be working fine.
in LargerMacroIconSelection.lua, change line 37 from
self:Initialize(AccountBankPanel.TabSettingsMenu)
to
self:Initialize(BankPanel.TabSettingsMenu)
There were numerous changes to the bank in 11.2, i.e. No more bank bags or Reagent bank or Void storage. When doing this, they changed the names of some functions and globals.
Error on 11.2 PTR hopefully there will be an update not long after the Patch.
1x ...argerMacroIconSelection/LargerMacroIconSelection.lua:37: attempt to index global 'AccountBankPanel' (a nil value)
[LargerMacroIconSelection/LargerMacroIconSelection.lua]:37: in function <...argerMacroIconSelection/LargerMacroIconSelection.lua:31>
Locals:
self = Frame {
searchIcons = <table> {
}
isMainline = true
isCata = false
loadedFrames = <table> {
}
isVanilla = false
}
event = "ADDON_LOADED"
addon = "LargerMacroIconSelection"
(*temporary) = Frame {
searchIcons = <table> {
}
isMainline = true
isCata = false
loadedFrames = <table> {
}
isVanilla = false
}
(*temporary) = nil
(*temporary) = "attempt to index global 'AccountBankPanel' (a nil value)"
Thanks for the heads up I didn't know it was broken on 11.2.0
You're welcome. I'd rather not have to set up the new bank tabs coming in 11.2 without LargerMacroIconSelection.
Is it just me, or is this addon just kaput? I tried to install it for the first time ever 5 weeks ago after finding out about it, but then when I logged in and tried to make a new macro, everything was just in vanilla form, as if the addon wasn't installed at all.
Quick Guide: How to update the Icons on the latest Patch (11.1)
1. download the latest file from the mentioned page: https://www.townlong-yak.com/addons/iconfilenames/release/1.0 (currently it is version 1.0-59347)
2. go to the addon path (..\World of Warcraft\_retail_\Interface\AddOns\LargerMacroIconSelectionData) and replace the file IconFileNames.lua with the new file you downloaded.
3. restart WoW and you should also see the latest patch 11.1 icons.