Thanks for the error log. I discovered it will no longer be possible to increase the amount of icons in the icon selector for the guild bank because Blizzard rewrote it.
People would probably care more about the search bar which should still be fixable. I would need to resub to get access to a guild bank but I'm not planning to pay to maintain my addons.
Please add my battletag (<snip>, I'm on EU if they don't support cross-region friends yet) or join my discordso I can create a guild on the PTR and test the guild bank 😊
In 9.1.5 this still works, but it gives an error, "Message: ...argerMacroIconSelection\LargerMacroIconSelection.lua:209: attempt to index local 'sf' (a nil value)"
It works fine for me in 9.1.5. How do I reproduce the error? Was it at the guild bank? Do you have the error log? You don't have to include the addon list, just the stack trace.
You're doing god's work with this addon. I can't believe Blizzard didn't have this feature. I've been annoyed for years that they have 1 billion icons in the macro selection and no search box.
Lua Error when opening the gbank added in TBCC today:
1x ...argerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua:209: attempt to index local 'sf' (a nil value) [string "@LargerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua"]:209: in function `Initialize' [string "@LargerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua"]:201: in function <...argerMacroIconSelection\LargerMacroIconSelection.lua:175> [string "=[C]"]: in function `LoadAddOn' [string "@Interface_TBC\FrameXML\UIParent.lua"]:364: in function `UIParentLoadAddOn' [string "@Interface_TBC\FrameXML\UIParent.lua"]:399: in function `GuildBankFrame_LoadUI' [string "@Interface_TBC\FrameXML\UIParent.lua"]:1212: in function <Interface_TBC\FrameXML\UIParent.lua:666>
Locals: self = <unnamed> { 0 = <userdata> UpdateButtons = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:370 Initialize = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:208 UpdateTextures = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:434 OnEvent = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:175 } sf = nil (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = "attempt to index local 'sf' (a nil value)" activeFrame = <table> { } LoadFileData = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:84 InitSearch = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:131 frames = <table> { MacroPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:42 GearManagerDialogPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:55 GuildBankPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:68 } origSize = <table> { } origNum = <table> { } _G = <table> { ERR_OUT_OF_CHI = "Not enough chi" DH_HAVOC_CORE_ABILITY_2 = "Strong melee attack that consumes Fury. If it critical strikes, some Fury is refunded." BT4Button85Shine14 = BT4Button85Shine14 { } GetTrainerServiceTypeFilter = <function> defined =[C]:-1 UNIT_NAMES_COMBATLOG_TOOLTIP = "Color unit names." SetTrainerServiceTypeFilter = <function> defined =[C]:-1 LE_GAME_ERR_CHAT_RAID_RESTRICTED_TRIAL = 776 SPELL_FAILED_CUSTOM_ERROR_71 = "This partygoer wants to dance with you." LE_GAME_ERR_PET_SPELL_TARGETS_DEAD = 399 Atr_StackPriceCopperMiddle = Atr_StackPriceCopperMiddle { } CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture = CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture { } TitanPanelSocialButton_Update = <function> defined @TitanSocial\TitanSocial.lua:1233 PawnItemComparer = <function> defined @Pawn\Pawn.lua:3923 MultiBarLeftButton7 = MultiBarLeftButton7 { } AudioOptionsVoicePanelOutputDeviceDropdownButtonHighlightTexture = AudioOptionsVoicePanelOutputDeviceDropdownButtonHighlightTexture { } LE_GAME_ERR_INVALID_FOLLOW_PVP_COMBAT = 353 MerchantItem4AltCurrencyFrameItem1Text = MerchantItem4AltCurrencyFrameItem1Text { } BINDING_NAME_NAMEPLATES = "Show Enemy Name Plates" CHAT_HEADER_SUFFIX = ": " MultiBarBottomRightButton8Shine5 = MultiBarBottomRightButton8Shine5 { } IsReferAFriendLinked = <function> defined =[C]:-1 UnitFrameManaBar_UnregisterDefaultEvents = <function> defined @Interface_TBC\FrameXML\UnitFrame.lua:600 TitanPanelAutoCombatLoggerButtonRightClickMenuLeft = TitanPanelAutoCombatLoggerButtonRightClickMenuLeft { } WhatsTrainingFrameRow3Spell = WhatsTrainingFrameRow3Spell { } CALENDAR_RAID_RESET_DESCRIPTION = "%1$s resets at %2$s." CraftExpandTabLeft = CraftExpandTabLeft { } Questie_ItemButton18Shine14 = Questie_ItemButton18Shine14 { } BOOST2_WARRIOR_COLOSSUSSMASH = "Use |cFFFFFFFFColossus Smash|r.
Thanks for the report, I disabled support for 2.5.2 TBC guild banks for now.
Since the error popped up regardless of being a guild master, there are probably a small amount of guild masters and it's not a trivial fix since Blizzard reworked the guild bank UI
We use the icon file names for searching instead of any localized spell names, so not currently no. Although it's possible to add this as a feature, but it might be only restricted to spells of your current class instead of for every class or for all spell names in the game unless we hardcode a list of spells... so not sure how I would go about it
I love that when you click the image to look at it it takes you to a porn site. The gif itself isn't porn but the site it is on is a porn site. Maybe use imgur or tenor :)
I'd be glad to use this addon together with Outfitter addon - where we should choose icon for an outfit. But I can't find the way to connect these two addons.
Even standalone version of LMIS would help (where I could watch icons without entering the Blizzard menu of macros), but how to do this - I also don't know.
Well i want to create a macro and bugsack put me out a error with your addon:
4x [ADDON_ACTION_BLOCKED] AddOn 'LargerMacroIconSelection' hat versucht die geschützte Funktion 'UNKNOWN()' aufzurufen. [string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519> [string "=[C]"]: ? [string "=[C]"]: in function `CreateMacro' [string "@Blizzard_MacroUI\Blizzard_MacroUI.lua"]:492: in function `okayFunction' [string "@SharedXML\SecureUIPanelTemplates.lua"]:463: in function <SharedXML\SecureUIPanelTemplates.lua:459>
For organizing my macros I use an addon called Mega Macro. When I run both addons together LargerMacroIconSelection affects the macro selection dialog as expected but the search bar has disappeared. I am unsure if this is a bug with your addon or theirs but if you could look into it that would be great.
BE AWARE ... installation of Mega Macro will affect your macros. Best to backup your WTF directory, test/figure out the bug, and then, after you uninstall Mega Macro, restore your backup to get your macros back the way you want.
Thanks in advance!
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
Send Message
Posted Nov 4, 2021In reply to epigramx:
Thanks for that. That's gotten rid of the error but we seem to have lost the search in the patch.
-
View User Profile
-
Send Message
Posted Nov 4, 2021In reply to ZalidTheBur:
Thanks for the error log. I discovered it will no longer be possible to increase the amount of icons in the icon selector for the guild bank because Blizzard rewrote it.
People would probably care more about the search bar which should still be fixable. I would need to resub to get access to a guild bank but I'm not planning to pay to maintain my addons.
Please add my battletag (<snip>, I'm on EU if they don't support cross-region friends yet) or join my discord so I can create a guild on the PTR and test the guild bank 😊-
View User Profile
-
Send Message
Posted Jan 7, 2022In reply to ZalidTheBur:
The guild bank search bar should be fixed again in v1.7.0 🙂
-
View User Profile
-
Send Message
Posted Nov 3, 2021In 9.1.5 this still works, but it gives an error, "Message: ...argerMacroIconSelection\LargerMacroIconSelection.lua:209: attempt to index local 'sf' (a nil value)"
-
View User Profile
-
Send Message
Posted Nov 3, 2021In reply to epigramx:
It works fine for me in 9.1.5. How do I reproduce the error? Was it at the guild bank? Do you have the error log? You don't have to include the addon list, just the stack trace.
-
View User Profile
-
Send Message
Posted Nov 4, 2021In reply to Ketho17:
Popped up for me at the guild bank.
Date: 2021-11-04 15:18:08
ID: 1
Error occured in: Global
Count: 1
Message: ...argerMacroIconSelection\LargerMacroIconSelection.lua line 209:
attempt to index local 'sf' (a nil value)
Debug:
[string "=[C]"]: ?
[string "@LargerMacroIconSelection\LargerMacroIconSelection.lua"]:209: Initialize()
[string "@LargerMacroIconSelection\LargerMacroIconSelection.lua"]:201:
...argerMacroIconSelection\LargerMacroIconSelection.lua:174
[string "=[C]"]: LoadAddOn()
[string "@..\FrameXML\UIParent.lua"]:509: UIParentLoadAddOn()
[string "@..\FrameXML\UIParent.lua"]:564: GuildBankFrame_LoadUI()
[string "@..\FrameXML\UIParent.lua"]:2001:
..\FrameXML\UIParent.lua:1287
-
View User Profile
-
Send Message
Posted Oct 9, 2021You're doing god's work with this addon. I can't believe Blizzard didn't have this feature. I've been annoyed for years that they have 1 billion icons in the macro selection and no search box.
-
View User Profile
-
Send Message
Posted Sep 1, 2021Lua Error when opening the gbank added in TBCC today:
1x ...argerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua:209: attempt to index local 'sf' (a nil value)
[string "@LargerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua"]:209: in function `Initialize'
[string "@LargerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua"]:201: in function <...argerMacroIconSelection\LargerMacroIconSelection.lua:175>
[string "=[C]"]: in function `LoadAddOn'
[string "@Interface_TBC\FrameXML\UIParent.lua"]:364: in function `UIParentLoadAddOn'
[string "@Interface_TBC\FrameXML\UIParent.lua"]:399: in function `GuildBankFrame_LoadUI'
[string "@Interface_TBC\FrameXML\UIParent.lua"]:1212: in function <Interface_TBC\FrameXML\UIParent.lua:666>
Locals:
self = <unnamed> {
0 = <userdata>
UpdateButtons = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:370
Initialize = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:208
UpdateTextures = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:434
OnEvent = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:175
}
sf = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'sf' (a nil value)"
activeFrame = <table> {
}
LoadFileData = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:84
InitSearch = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:131
frames = <table> {
MacroPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:42
GearManagerDialogPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:55
GuildBankPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:68
}
origSize = <table> {
}
origNum = <table> {
}
_G = <table> {
ERR_OUT_OF_CHI = "Not enough chi"
DH_HAVOC_CORE_ABILITY_2 = "Strong melee attack that consumes Fury. If it critical strikes, some Fury is refunded."
BT4Button85Shine14 = BT4Button85Shine14 {
}
GetTrainerServiceTypeFilter = <function> defined =[C]:-1
UNIT_NAMES_COMBATLOG_TOOLTIP = "Color unit names."
SetTrainerServiceTypeFilter = <function> defined =[C]:-1
LE_GAME_ERR_CHAT_RAID_RESTRICTED_TRIAL = 776
SPELL_FAILED_CUSTOM_ERROR_71 = "This partygoer wants to dance with you."
LE_GAME_ERR_PET_SPELL_TARGETS_DEAD = 399
Atr_StackPriceCopperMiddle = Atr_StackPriceCopperMiddle {
}
CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture = CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture {
}
TitanPanelSocialButton_Update = <function> defined @TitanSocial\TitanSocial.lua:1233
PawnItemComparer = <function> defined @Pawn\Pawn.lua:3923
MultiBarLeftButton7 = MultiBarLeftButton7 {
}
AudioOptionsVoicePanelOutputDeviceDropdownButtonHighlightTexture = AudioOptionsVoicePanelOutputDeviceDropdownButtonHighlightTexture {
}
LE_GAME_ERR_INVALID_FOLLOW_PVP_COMBAT = 353
MerchantItem4AltCurrencyFrameItem1Text = MerchantItem4AltCurrencyFrameItem1Text {
}
BINDING_NAME_NAMEPLATES = "Show Enemy Name Plates"
CHAT_HEADER_SUFFIX = ": "
MultiBarBottomRightButton8Shine5 = MultiBarBottomRightButton8Shine5 {
}
IsReferAFriendLinked = <function> defined =[C]:-1
UnitFrameManaBar_UnregisterDefaultEvents = <function> defined @Interface_TBC\FrameXML\UnitFrame.lua:600
TitanPanelAutoCombatLoggerButtonRightClickMenuLeft = TitanPanelAutoCombatLoggerButtonRightClickMenuLeft {
}
WhatsTrainingFrameRow3Spell = WhatsTrainingFrameRow3Spell {
}
CALENDAR_RAID_RESET_DESCRIPTION = "%1$s resets at %2$s."
CraftExpandTabLeft = CraftExpandTabLeft {
}
Questie_ItemButton18Shine14 = Questie_ItemButton18Shine14 {
}
BOOST2_WARRIOR_COLOSSUSSMASH = "Use |cFFFFFFFFColossus Smash|r.
|cFFFFFFFFColossus Smash|r increases your damage."
CinematicFrameRaidBossEmoteFrame = CinematicFrameRaidBossEmoteFrame {
}
ScrollTable3Row12col13text = ScrollTable3Row12col13text {
}
CompactRaidFrameManagerDisplayFrameHiddenModeToggleTopRight = CompactRaidFrameManagerDisplayFrameHiddenModeToggleTopRight {
}
LE_GAME_ERR_ONLY_ONE_QUIVER = 32
GetMonitorAspectRatio = <function> defined =[C]:-1
TrinketMenu_Trinket1Shine13 = TrinketMenu_Trinket1Shine13 {
}
LOSS_OF_CONTROL_DISPLAY_FEAR = "Feared"
Graphics_QualityText = Graphics_QualityText {
}
LibDBIcon10_BugSack = LibDBIcon10_BugSack {
}
CompactUnitFrameProfilesSaveButton = CompactUnitFrameProfilesSaveButton {
}
RaidGraphics_EnvironmentalDetailSlider = RaidGraphics_EnvironmentalDetailSlider {
}
Is64BitClient = <
-
View User Profile
-
Send Message
Posted Sep 2, 2021In reply to SunfyreBlazing:
Thanks for the report, I disabled support for 2.5.2 TBC guild banks for now.
Since the error popped up regardless of being a guild master, there are probably a small amount of guild masters and it's not a trivial fix since Blizzard reworked the guild bank UI
-
View User Profile
-
Send Message
Posted May 26, 2021will it be possible to change the search like weak aura? With weak aura you can search in different languages your icon.
-
View User Profile
-
Send Message
Posted May 26, 2021In reply to Sekorhex:
We use the icon file names for searching instead of any localized spell names, so not currently no. Although it's possible to add this as a feature, but it might be only restricted to spells of your current class instead of for every class or for all spell names in the game unless we hardcode a list of spells... so not sure how I would go about it
-
View User Profile
-
Send Message
Posted Apr 26, 2021I love that when you click the image to look at it it takes you to a porn site. The gif itself isn't porn but the site it is on is a porn site. Maybe use imgur or tenor :)
-
View User Profile
-
Send Message
Posted Apr 26, 2021In reply to MimPlays:
wow damn, gfycat turned into a porn site. or they marked the gif as nsfw. Thanks for the heads-up I changed it to https://streamable.com/pxsf98
-
View User Profile
-
Send Message
Posted Nov 15, 2020I'd be glad to use this addon together with Outfitter addon - where we should choose icon for an outfit. But I can't find the way to connect these two addons.
Even standalone version of LMIS would help (where I could watch icons without entering the Blizzard menu of macros), but how to do this - I also don't know.
-
View User Profile
-
Send Message
Posted Nov 15, 2020In reply to AlexL1118:
This is the most requested feature, there is LibAdvancedIconSelector-1.0 which does exactly that. Someone just has to find the time to update it
-
View User Profile
-
Send Message
Posted May 4, 2021In reply to AlexL1118:
As a workaround. Go to Bliz equipment manager and change the icon there and Outfitter icon will update automatically.
-
View User Profile
-
Send Message
Posted Nov 8, 2020Well i want to create a macro and bugsack put me out a error with your addon:
4x [ADDON_ACTION_BLOCKED] AddOn 'LargerMacroIconSelection' hat versucht die geschützte Funktion 'UNKNOWN()' aufzurufen.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: ?
[string "=[C]"]: in function `CreateMacro'
[string "@Blizzard_MacroUI\Blizzard_MacroUI.lua"]:492: in function `okayFunction'
[string "@SharedXML\SecureUIPanelTemplates.lua"]:463: in function <SharedXML\SecureUIPanelTemplates.lua:459>
-
View User Profile
-
Send Message
Posted Nov 8, 2020In reply to Forge_User_55245620:
Were you in combat? It's possible to create macros in combat but not when this addon is loaded and modifies the macro UI...
This seems a side effect of not letting addons and the like create macros in combat
-
View User Profile
-
Send Message
Posted Nov 9, 2020In reply to Ketho17:
It can be possible, because i tried my macros with the dummys in orgrimmar.
-
View User Profile
-
Send Message
Posted Oct 18, 2020Hi there,
Love your addon but I've run into a bug.
For organizing my macros I use an addon called Mega Macro. When I run both addons together LargerMacroIconSelection affects the macro selection dialog as expected but the search bar has disappeared. I am unsure if this is a bug with your addon or theirs but if you could look into it that would be great.
BE AWARE ... installation of Mega Macro will affect your macros. Best to backup your WTF directory, test/figure out the bug, and then, after you uninstall Mega Macro, restore your backup to get your macros back the way you want.
Thanks in advance!