GridStatusRaidDebuff causes variable taint that conflicts with default Blizzard interface #30


  • New
  • Defect
  • Replied
Open
Assigned to stassart
  • Antonz created this issue Sep 1, 2012

    What steps will reproduce the problem?
    1. Enable Grid and GridStatusRaidDebuff.
    2. Go to Symbols tab in Talents interface and try to change symbol.
    3. Message popups telling that addon tries to do protected operation reserved for Blizzard UI (I have a russian version of WoW so cannot reproduce it here exactly but we all know how it looks). It not always points to GridStatusRaidDebuff but can report other addon (maybe they also have similar problem, not checked it).

    What version of GridStatusRaidDebuff? (Please do not say "latest")
    r301

    What version of Grid? (Please do not say "latest")
    5.0.4.1520

    Are you running GridStatusRD_Cata and if so, what version?  (Please do not say "latest")
    yes, r29

    What language (localization/region) are you running?
    ru_RU

    Do you have an error log of what happened?

    Yes, when I enable taints reporting, I have following in Logs/taint.log :

    9/1 15:55:48.673  Global variable _ tainted by GridStatusRaidDebuff - Interface\AddOns\GridStatusRaidDebuff\Core.lua:464 DebuffLocale()
    9/1 15:55:48.673      Interface\AddOns\GridStatusRaidDebuff\Core.lua:498 Debuff()
    9/1 15:55:48.673  Execution tainted by GridStatusRaidDebuff while reading _ - Interface\AddOns\Blizzard_GlyphUI\Blizzard_GlyphUI.lua:174 GlyphFrame_Update()
    9/1 15:55:48.673      Interface\AddOns\Blizzard_GlyphUI\Blizzard_GlyphUI.lua:91
    9/1 15:55:48.673      CastGlyph()
    9/1 15:55:48.673      Interface\AddOns\Blizzard_GlyphUI\Blizzard_GlyphUI.lua:527 GlyphFrameSpell_OnClick()
    9/1 15:55:48.673      GlyphFrameScrollFrameButton5:OnClick()
    9/1 15:55:48.673  An action was blocked because of taint from GridStatusRaidDebuff - CastGlyph()
    9/1 15:55:48.673      Interface\AddOns\Blizzard_GlyphUI\Blizzard_GlyphUI.lua:527 GlyphFrameSpell_OnClick()
    9/1 15:55:48.673      GlyphFrameScrollFrameButton5:OnClick()

    Please provide any additional information below.

    Seems that problem caused by setting global variable named _ that is used as a placeholder for receiving unused data from some functions. It seems that Blizzard's own interface also uses it as a global variable (which is bad but we cannot address it). My proposal is to declare this variable local, this effectively fixes bug. I'll attach patch file ...

  • Antonz added the tags New Defect Sep 1, 2012
  • Antonz added an attachment Core.lua.diff Sep 1, 2012

    Core.lua.diff

    <p>Diff file with proposed patch</p>

  • Antonz added an attachment Core.lua Sep 1, 2012

    Core.lua

    <p>Just patched file.</p>

  • Antonz edited description Sep 1, 2012
  • stassart posted a comment Sep 1, 2012

    I assume this is for MoP, have you tried using the MoP version of this addon:

    http://wow.curseforge.com/addons/gridstatusraiddebuff-mop/

  • stassart unassigned issue from azelkeeber Sep 1, 2012
  • stassart self-assigned this issue Sep 1, 2012
  • Antonz posted a comment Sep 1, 2012

    I haven't tried it yet, but from analyzing code of MoP addon I see that it doesn't have this issue, thanks. But why to create separate addon for MoP? Will it be merged with previous, or put on Curse? Because now for users using old addon and waiting for updates this is confusing.

  • stassart posted a comment Sep 1, 2012

    The "manager" of this addon, azelkeeber, hasn't responded at least since June, 2011 probably longer (that's as far back as my curse messages go).

    I do not have access to make some of the changes I had wanted to make to the addon for a while now. Like I have moved the new MoP version to using the Curseforge localization system. There are other items I do not have access to also.

    I am considering dropping libbabble and localizing what is required for the addon so I no longer require libbabble updates for this addon to work, but I haven't taken a hard stance on that yet.

    I can't easilly update this version as the new version builds using the Curse localization system, so if I uploaded the updates to the MoP version to this project, it wouldn't work. I would have to manually upload .zip files for this addon and that doesn't work well.

    I understand that it inconveniences users and I apologize, but I believe it will be better in the long run.

  • Antonz posted a comment Sep 1, 2012

    Thanks for clarification. I thought there was some procedure for taking over dead and abandoned addons, I have seen it for some other addons. Maybe Curse mods can help?

  • stassart posted a comment Sep 1, 2012

    I have tried requesting it before and been denied. I just submitted another one. If this ticket gets denied again I will mark all files on this addon as "alpha" so that they don't show up on the Curse site, that might make it clearer to users that they need to switch addons.

  • stassart removed a tag Invalid Sep 1, 2012
  • stassart added a tag Waiting Sep 1, 2012
  • stassart reopened issue Sep 1, 2012
  • stassart posted a comment Sep 2, 2012

    I had another idea to deal with this issue. I uploaded a small addon to this project that all it does is put up a pop-up on log in to tell the user to swap to GridStatusRaidDebuff MoP.

    That should help notify users about the swap if they download this addon without reading the Curse page.

  • stassart removed a tag Waiting Sep 2, 2012
  • stassart added a tag Replied Sep 2, 2012

To post a comment, please login or register a new account.