Tracking herbs without herbalism fails #208

  • Defect
Closed
  • View Forge_User_97973999's Profile
    Forge_User_97973999 created this issue Oct 4, 2019

    [German client, GatherMate2-1.45.5-classic]

     

    Trying to track a herb position without actually knowing herbalism fails.

     

    I've debugged the cause and it's quite simple, in Collector.lua:18 a gsub is performed (for reasons beyond my knowledge) that removes special characters (like german ä) from the string, thus the strfind in line 199 fails, and nothing is tracked.

     

    As a temporary solution I've removed the gsub. No problems so far, but it probably had been added for a reason ;)

  • View Forge_User_97973999's Profile
    Forge_User_97973999     added a tag Defect Oct 4, 2019
  • View nevcairiel's Profile
    nevcairiel     closed issue Oct 6, 2019
  • View nevcairiel's Profile
    nevcairiel posted a comment Oct 6, 2019

    GetSpellInfo(9134) returns  "+5 Herbalism" on retail, which is what the gsub is meant to remove. On Classic, its only "Herbalism", which makes it work.

     

    I've added a condition to make it work on both.

To post a comment, please login or register a new account.