Jittering of node pins in 8.1 #179


Closed
  • Forge_User_19174901 created this issue Dec 12, 2018

    Hey, I'm writing regarding some problems I've had with Gathermate2 but also other addons like Routes which both draw textures on the minimap. Ever since 8.1 went live both these addons look really bad on the Minimap.

    I tried fixing it myself but I cannot at all figure out what actually causes this. Is it the pin positions not updating fast enough, is it something to do with the math used in updating the pin locations, is it something to do with the HereBeDragons lib, is it a change in the Frame/Textures API? I looked everywhere and couldn't find a way to fix it. Blizzard deffo changed something in their API and is causing not only this addon but others to behave like this when drawing to the minimap.

     

    I beg you if you have the time to look into this. I've only recently started to get into modifying/creating simple addons so I'm not that accustomed to the game's api but I can assist you guys with more information about this bug if needed.

     

    I know it's not a gamebreaking bug but I spend a lot of time farming and this jittering really makes my head hurt a bit

  • nevcairiel posted a comment Dec 14, 2018

    A tiny bit of wobbling has always existed because of sub-pixel accuracy problems, but not to that extend.

    That said, I cannot reproduce such problems on Live right now. Does it happen in all zones? Perhaps just some?

  • nevcairiel posted a comment Dec 14, 2018

    I've gotten some feedback from other authors that this might be a game issue right now, as other animated icons don't move smoothly either, ie. here:

     

    I'm trying to reach out to a Blizzard developer on the issue.

  • Forge_User_19174901 posted a comment Dec 14, 2018

    It happens everywhere and it's the same issue with the Routes addon. I managed however to force Routes to update 40 time/s no matter what and it looks way smoother. Also I don't know if it's just a feeling or if it's how my eyes perceive it but the more zoomed in the minimap is the less the pins/lines jitter. The movement of the gathermate pins does seem more erratic however while the lines drawn with Routes just seem to not redraw in sync with the movement.

     

     

  • Forge_User_19174901 posted a comment Dec 14, 2018

     

     

     

    - In the first gif I replaced this line using the lib function 

    local _x, _y, currentZoneID = self.Dragons:GetPlayerZonePosition(true)

    with

    function palyerPosFix()
    local MapID = C_Map.GetBestMapForUnit("player")
    if not MapID then return end
    local x, y = C_Map.GetPlayerMapPosition(MapID, "player"):GetXY()
    if not x or not y then return end

    return x, y, MapID
    end

    as the values were a bit off compared to my function starting at the 3rd or 4th decimal

     

    - in the 2nd gif I reverted to using HereBeDragons

     

    - in the 3rd gif I restored this line that I commented out to force 40 draws/s no matter what; commenting this out was the most noticeable improvement even if it requires more resources

     

    if (not forceUpdate) and facing == last_facing and (last_X-cx)^2 + (last_Y-cy)^2 < defaults.update_distance^2 then if (not forceUpdate) and facing == last_facing and (last_X-cx)^2 + (last_Y-cy)^2 < defaults.update_distance^2 then -- no update! return end

     

  • nevcairiel posted a comment Jan 22, 2019

    I commited a fix to GatherMate2 that should help. I'll update Routes and  HandyNote as well in the coming days if it  proves to resolve it.

  • nevcairiel closed issue Jan 22, 2019

To post a comment, please login or register a new account.