WowAce

Will this be updated for 5.2?

For some reason the addon is not announcing when i cast portals...

Minor display issue.  Every time you open the menu from Titan Bar the width of the drop down expands by one pixel.

I am using the latest release and somehow I still don't see the Old Dalaran teleport + portal in the drop down window.

Any ETA on Old Dalaran Teleport + Portal and Gold Challenge Dungeons Teleports ?

i also like to up the vote on adding:

Ancient Tome of Teleport: Dalaran and Ancient Tome of Portal: Dalaran

These bring you to the crater of old Dalaran.

+1 to that !

Your latest alpha push R171 broke the addon.

Also, please add the new Ancient Teleport: Dalaran and Ancient Portal: Dalaran.

Yes, please add the new portal spells

Awesome addon, I have been using it for years with my mage.

Could you please take a look and add the two new mage portal spells to Vale of Eternal Blossoms as well as Wormhole Generator : Pandaria to the drop down window? 

Great addon, can only recommend it even if you don't play a mage.

Your mod (as of v1.8.27) generates a bug for lower level mages because of how GetBookItemName works now (it no longer return nil if a spell does not exist or is not learned yet, it will throw an invalid spell slot exception instead).

You may want to change your UpdateSpells() function to use IsPlayerSpell before calling findSpell to check if the player does have the spell.

Use something like:

local function UpdateSpells()
         if not portals then
               SetupSpells()
          end

           if portals then
                  for _,unTransSpell in ipairs(portals) do

                           local spell, _, spellIcon = GetSpellInfo(unTransSpell[1])
                           local spellid = nil
                           if(IsPlayerSpell(unTransSpell[1])) then
                                   spellid = findSpell(spell)
                           end

                           if spellid then
                                    methods[spell] = {
                                            spellid = spellid,
                                            text = spell,
                                           spellIcon = spellIcon,
                                            isPortal = unTransSpell[2] == 'P_RUNE',
                                            secure = {
                                               type = 'spell',
                                              spell = spell
                                           }
                                    }
                           end
                 end
         end
end

PS: WTB identation preserving on copy-paste operations.

Logged in last night with a lvl35 mage and got the following error, guessing that's the one you're referring to.

["message"] = "Interface\\AddOns\\Broker_Portals\\portals.lua:121: GetSpellBookItemName(): Invalid spell slot",

Yea that's the one. As I said, it's because they changed the behaviour of GetSpellBookItemName(index,type) from returning nil to throwing an exception if there's noting at that index. Using IsPlayerSpell(spellid)  before calling findSpell(spellid) fixes that problem (and would also probably fix anny spell removal problems in the future).

PS: in this post, spellid is the global identification of a spell and not the spellbook's index of that spell

Here is a zip file that will work for 5.0.0.4.   I'm just providing it to hold off on more comments while the author has time to do an official release.

http://filepost.com/files/6966d591/Broker_Portals.zip/

A problem with your version. Everytime I click the minimap button for broker_portals, the frame keeps expanding.

Ah, I have to admit I don't use the minimap button, I use the broker button.  I didn't even realize this addon had a minimap button..lol.  Figure that's the whole point of having broker_ addons:  less minimap buttons.

Quote from Aelorean »

Ah, I have to admit I don't use the minimap button, I use the broker button.  I didn't even realize this addon had a minimap button..lol.  Figure that's the whole point of having broker_ addons:  less minimap buttons.

I also run it from Bazooka LDB display and its the same. Try right click the broker button continuously and watch the portal frame expanding for each click.