WowAce

Thank you for uploading your file Bormes11. I don't know if it is because I'm tired or what, but I just couldn't get the edits to work. You fixed one of my most cherished addons.

This is working for for 7.2 with this patch:

Baggins-filtering.lua line 305, first and last line added by me:

if speciesID ~= nil and speciesID ~= '' then
local name, icon, petType, creatureID, sourceText, description, isWild, canBattle, tradable, unique= C_PetJournal.GetPetInfoBySpeciesID( speciesID )
itemid = - tonumber(petid) -- use negative itemid values for battle-pets
if itemid == 0 then
itemid = - tonumber(speciesID)
end
iteminfo = PET_CAGE_ITEM_ID .. " " .. 1 .. " " .. name
end

TY MEN

Any chance that the addon will get an update with this fix?

I love this addon, I have been using it for like forever,  and have a zillion sections and rules, it has now given up on me :(

I am not comfortable with changing the code myself, or even have a clue on how to start with it, so please please make a new version!!

In reply to bruj0:

In reply to c_ba11:

I was confused as well. Not very well explained, but was easy enough to figure out after some mild head scratching.

Basically find the second line of code he pasted above in Baggins-filtering.lua (should be line 305), ie:

local name, icon, petType, creatureID, sourceText, description, isWild, canBattle, tradable, unique= C_PetJournal.GetPetInfoBySpeciesID( speciesID )

And above it paste the first line he added:

if speciesID ~= nil and speciesID ~= '' then

Then go down to below the last line he pasted:

iteminfo = PET_CAGE_ITEM_ID .. " " .. 1 .. " " .. name

And below that line add one more "end":

end

If for some reason that doesn't work. I uploaded my baggins-filtering.lua file here: https://ufile.io/8f7981

Replace your old Baggins-filtering.lua file with that and you should be good till we get an update, though make sure to change the file name back to Baggins-filtering.lua as that site will add some numbers to the beginning of the file name when you download it.

In reply to Bormes11:

 After that fix it doesn't show free slots. Instead it shows free slots on one of the items. 

In reply to Drejjmit:

In reply to bruj0:

 local link = GetContainerItemLink(bag, slot)
 local realId = GetContainerItemID(bag, slot)
 local itemCount = select(2, GetContainerItemInfo(bag, slot))
 local itemid
 if link then
     if realId == 138019 then -- It's a mythic Keystone
         itemid = 138019
     else
         itemid = link:match("item:(%d+)")
     end
     if itemid then -- it's not a battle pet

If you compare these lines to what is there you should be able to see what is actually different (and I added a comment on what my comparison is doing). I would recommend this over what bruj0 has.

Or in the smallest amount of change, on line 299, replace

link:match("item:(%d+)")

link:match("H[^b]%l+:(%d+)")

7.2 changed keystones from using Hitem type links to using Hkeystone type links, since the baggins filtering assumes every non Hitem link is an Hbattlepet link type, it chokes. The above should be somewhat future proof if blizz adds more link types for items.

If you want to filter keystones by item id, you will also have to update line 820 using the same replacement as 299

And I don't think this is an issue, but the same code appears for PeriodicTable Sets on line 1435, but since those don't have keystones in them (that I know of), it shouldn't be an issue, update it as needed

In reply to eLQ:

In reply to Bormes11:

In reply to kthreewow:

gsub(link, "\124", "\124\124");

or

link:gsub("\124", "\124\124");

will keep the chatbox from turning it into a link

\124 is a pipe, and || is the escape for pipes

Any chance this is getting updated?  for me 7.2 finally broke it and I don't like any other options available.  This addon is the beesknees, I need it in my life!

I second that.  I absolute LOVE this addon.  Best inventory management addon ever made.  I truly hope someone can update this for 7.2.

Please Please Please update this addon for 7.2!  I've had it since 2009 and I can't function without it!

Think this addon is dead, which is a shame because as stated below many times it was one of the most intelligent and customisable bag addons available AFAIK nothing else even comes close.

Sure it had/has it's issues:

No support for item indicators (quest, new, upgrade etc.)

Limited compatibility with other addons that display info on the icons (whether recipes are already know, names of sets the items are part of, displaying of item levels etc.)

Bank/New sorting goes haywire all the time, especially on first logging in/accessing bank, or after a reload.

Missing out on these while undesirable is bearable because of all the other functionality provided.

But the thing that has finally become the nail in it's coffin is the lag whenever you leave combat, which gets longer and longer as your play session goes on (eventually requiring a reload, which in turn breaks the new sorting) this makes things like BG's and/or any form of PVP pretty much unbearable.

When is a new version of this addon coming out?

Getting this Error if a pet is in the inventory: