282 - Guildmate names not class colored since 5.4.2
What steps will reproduce the problem?
1. Update WoW to 5.4.2
2. Login
3. Have a guildmate talk in /g
What is the expected output? What do you see instead?
Expected to see the names in the appropriate class colors. Names are grey instead.
What version of the product are you using?
1.4.4-2-g4fbe5e5
Do you have an error log of what happened?
No.
Please provide any additional information below.
I was able to fix this with a few lines of code. It may not be the prettiest hack, but it seems to work and might be a start for you guys.
\Modules\PlayerNames.lua - Insert after line 311 (realm.names table initialization):
local randomPointerName = string.find(name, "-")
if randomPointerName ~= nil then
local name = string.sub(name, 1, randomPointerName-1)
end
It seems guild names are reported to the addon as Name-Server, so this just strips the "-Server" when the name is seen for the first time. It has worked in local testing. There might be a better place in the code for this (or a better method overall), but since pretty much every other function calls AddPlayer, it seemed best to put it there.
- 3 comments
- 3 comments
Facts
- Last updated
- Jan 11, 2015
- Reported
- Dec 11, 2013
- Status
- New - Issue has not had initial review yet.
- Type
- Defect - A shortcoming, fault, or imperfection
- Priority
- Medium - Normal priority.
- Votes
- 4
- Reply
- #3
Tanoh Feb 19, 2014 at 22:14 UTC - 0 likesI got it to work with adding the following line at line 514 of Chatter/Modules/PlayerNames.lua (make it the first line in changeName)
Not sure if it's the ideal fix though as I know too little of Chatter's internal workings.
- Reply
- #2
OttoDeFe Jan 02, 2014 at 03:53 UTC - 0 likesCilraaz - when I put your patch after line 311 I produce an error:
My line 311 is the end statement for the realm.names table initialization function - what line of code should it be inserted after?
- Reply
- #1
Cilraaz Dec 23, 2013 at 02:13 UTC - 0 likesI've shortened up the above code a bit:
if string.find(name, "-") ~= nil then
name, _ = string.split("-", name)
end