Yeah, wasn't sure if it had all the icons as of 8.2.0 release or not - I actually found the way to add everything from wowtools site you linked in one of your data file [FileData.lua]. Added in more icons that weren't in your release. (all textures under Interface/Icons/)
Your original file had 21,030 macro icons; mine is up to 21,089; added 59 more icons to the list.
Ketho, do you plan any update for classic? My take is it should work fine on Classic since it use the latest "core build" of the game and the macro system as well.
I haven't tested it yet on classic but it might not work with the removal of the equipment sets UI, and there are a lot of icons removed in classic so I'll have to see
When I disable your addon this error goes away (running 1.4.1-nolib):
Message: ...AddOns\Blizzard_GuildBankUI\Blizzard_GuildBankUI.lua:853: bad argument #1 to 'strupper' (string expected, got nil)
Time: Tue Apr 23 23:18:19 2019
Count: 1
Stack: ...AddOns\Blizzard_GuildBankUI\Blizzard_GuildBankUI.lua:853: bad argument #1 to 'strupper' (string expected, got nil)
...ce\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:583: in function <...ce\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:543>
[C]: ?
[C]: in function `strupper'
...AddOns\Blizzard_GuildBankUI\Blizzard_GuildBankUI.lua:853: in function <...AddOns\Blizzard_GuildBankUI\Blizzard_GuildBankUI.lua:846>
[C]: in function `?'
...argerMacroIconSelection\LargerMacroIconSelection.lua:383: in function <...argerMacroIconSelection\LargerMacroIconSelection.lua:228>
[C]: ?
[C]: in function `Show'
...ce\AddOns\ElvUI\Modules\skins\Blizzard\GuildBank.lua:103: in function <...ce\AddOns\ElvUI\Modules\skins\Blizzard\GuildBank.lua:11>
[C]: ?
...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:29: in function <...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:64: in function `Fire'
...
[C]: ?
[C]: in function `Initialize'
Interface\AddOns\ElvUI\Modules\skins\Skins.lua:1388: in function <Interface\AddOns\ElvUI\Modules\skins\Skins.lua:1387>
...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:129: in function <...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:129>
[C]: ?
...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:29: in function <...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
...ies\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:64: in function `Fire'
Interface\AddOns\ElvUI\Core\Core.lua:1658: in function `InitializeModules'
Interface\AddOns\ElvUI\Core\Core.lua:1948: in function `Initialize'
Interface\AddOns\ElvUI\init.lua:213: in function <Interface\AddOns\ElvUI\init.lua:212>
Locals: errMsg = "...AddOns\Blizzard_GuildBankUI\Blizzard_GuildBankUI.lua:853: bad argument #1 to 'strupper' (string expected, got nil)"
tsmErrMsg = nil
oldModule = nil
private = <table> {
AddonBlockedEvent = <function> defined @Interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:335
num = 0
ErrorHandler = <function> defined @Interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:116
hitInternalError = false
errorFrame = <unnamed> {
}
origErrorHandler = <function> defined @Interface\SharedXML\SharedBasicControls.lua:295
FormatErrorMessageSection = <function> defined @Interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:350
SanitizeString = <function> defined @Interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:343
errorReports = <table> {
}
IsTSMAddon = <function> defined @Interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:310
localLinesTemp = <table> {
}
GetStackInfo = <function> defined @Interface\AddOns\TradeSkillMaster\Core\Lib\ErrorHandler.lua:278
}
MAX_STACK_DEPTH = 50
TSM = <table> {
}
Looks like something to do when opening the guild bank. But I can't test it at the moment since starter edition accounts don't have access to the guild bank. I tried to test it on a guild on the PTR but ElvUI is currently broken there.
Does the error still happen with all other addons disabled? It helps to know if it's conflicting with another addon.
Does this still work fine for WoW Retail v8.2.0?
In reply to JDM12983:
For retail it should still work, yes
In reply to Ketho17:
Yeah, wasn't sure if it had all the icons as of 8.2.0 release or not - I actually found the way to add everything from wowtools site you linked in one of your data file [FileData.lua]. Added in more icons that weren't in your release. (all textures under Interface/Icons/)
Your original file had 21,030 macro icons; mine is up to 21,089; added 59 more icons to the list.
In reply to JDM12983:
Yeah I've been lazy with adding icons ._.
I'll try to update it once 8.2.5 hits next tuesday/wednesday
Ketho, do you plan any update for classic? My take is it should work fine on Classic since it use the latest "core build" of the game and the macro system as well.
In reply to Karazaskull:
I haven't tested it yet on classic but it might not work with the removal of the equipment sets UI, and there are a lot of icons removed in classic so I'll have to see
But yes there will be a classic update soon(tm)
In reply to Ketho17:
I see, alright then. Thank you and GL with the coding ;)
In reply to Karazaskull:
If you're still reading this, I'm sorry for not updating soon(tm). I've been very busy this month
In reply to Ketho17:
Ok, no worries :)
I finally updated it for classic :)
In reply to Ketho17:
Awesome! Thank you.
Both LargerMacroIconSelection and ArkInventory seem to work for me on the PTR https://i.imgur.com/rltbHil.jpg
First off, this is an amazing addon.
Any plans to update this? It's throwing an error in patch 8.1.5.
Thank you.
In reply to BaturalNoobs62219:
Yeah sure, I will update it tomorrow
In reply to Ketho:
Awesome - thank you!!!
In reply to BaturalNoobs62219:
Hey uhhh, about that error. Can u post it? I updated but did not find any errors
In reply to Ketho:
When I disable your addon this error goes away (running 1.4.1-nolib):
In reply to BaturalNoobs62219:
Looks like something to do when opening the guild bank. But I can't test it at the moment since starter edition accounts don't have access to the guild bank. I tried to test it on a guild on the PTR but ElvUI is currently broken there.
Does the error still happen with all other addons disabled? It helps to know if it's conflicting with another addon.
In reply to Ketho:
I was trying to sort out which Addon conflicts with your Addon Ketho. It was "Arkinventory".
If only your addon is enabled: no error.
Hope it helps somehow.
please add ability to use with equipment manager sets