I'm very happy to hear you are on the mend. I went through Covid myself, although it was extremely mild, like a mild cold, without even a fever, although I tested positive. I'm thinking it is probably because I was vaccinated and boosted perhaps. Remember, your health comes first. People that enjoy your addon, which I am one, can definitely wait!
I'm very happy to hear you are on the mend. I went through that myself, although it was extremely mild, like a mild cold, without even a fever, although I tested positive. I'm thinking it is probably because I was vaccinated and boosted perhaps. Remember, your health comes first. People that enjoy your addon, of which I am one, can definitely wait!
3x ...argerMacroIconSelection\LargerMacroIconSelection-v1.7.0.lua:253: bad argument #3 to 'format' (string expected, got boolean) [string "=[C]"]: in function `format' [string "@LargerMacroIconSelection\LargerMacroIconSelection-v1.7.0.lua"]:253: in function <...argerMacroIconSelection\LargerMacroIconSelection.lua:249>
Workaround for the "sf is nil" error. Add "if not sf then return end" under line 208. I suspect the addon still works but early in the game before macros come up: whatever sf is; is still nil.
Thanks for the error log. I discovered it will no longer be possible to increase the amount of icons in the icon selector for the guild bank because Blizzard rewrote it.
People would probably care more about the search bar which should still be fixable. I would need to resub to get access to a guild bank but I'm not planning to pay to maintain my addons.
Please add my battletag (<snip>, I'm on EU if they don't support cross-region friends yet) or join my discordso I can create a guild on the PTR and test the guild bank 😊
In 9.1.5 this still works, but it gives an error, "Message: ...argerMacroIconSelection\LargerMacroIconSelection.lua:209: attempt to index local 'sf' (a nil value)"
It works fine for me in 9.1.5. How do I reproduce the error? Was it at the guild bank? Do you have the error log? You don't have to include the addon list, just the stack trace.
You're doing god's work with this addon. I can't believe Blizzard didn't have this feature. I've been annoyed for years that they have 1 billion icons in the macro selection and no search box.
Lua Error when opening the gbank added in TBCC today:
1x ...argerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua:209: attempt to index local 'sf' (a nil value) [string "@LargerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua"]:209: in function `Initialize' [string "@LargerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua"]:201: in function <...argerMacroIconSelection\LargerMacroIconSelection.lua:175> [string "=[C]"]: in function `LoadAddOn' [string "@Interface_TBC\FrameXML\UIParent.lua"]:364: in function `UIParentLoadAddOn' [string "@Interface_TBC\FrameXML\UIParent.lua"]:399: in function `GuildBankFrame_LoadUI' [string "@Interface_TBC\FrameXML\UIParent.lua"]:1212: in function <Interface_TBC\FrameXML\UIParent.lua:666>
Locals: self = <unnamed> { 0 = <userdata> UpdateButtons = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:370 Initialize = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:208 UpdateTextures = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:434 OnEvent = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:175 } sf = nil (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = "attempt to index local 'sf' (a nil value)" activeFrame = <table> { } LoadFileData = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:84 InitSearch = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:131 frames = <table> { MacroPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:42 GearManagerDialogPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:55 GuildBankPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:68 } origSize = <table> { } origNum = <table> { } _G = <table> { ERR_OUT_OF_CHI = "Not enough chi" DH_HAVOC_CORE_ABILITY_2 = "Strong melee attack that consumes Fury. If it critical strikes, some Fury is refunded." BT4Button85Shine14 = BT4Button85Shine14 { } GetTrainerServiceTypeFilter = <function> defined =[C]:-1 UNIT_NAMES_COMBATLOG_TOOLTIP = "Color unit names." SetTrainerServiceTypeFilter = <function> defined =[C]:-1 LE_GAME_ERR_CHAT_RAID_RESTRICTED_TRIAL = 776 SPELL_FAILED_CUSTOM_ERROR_71 = "This partygoer wants to dance with you." LE_GAME_ERR_PET_SPELL_TARGETS_DEAD = 399 Atr_StackPriceCopperMiddle = Atr_StackPriceCopperMiddle { } CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture = CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture { } TitanPanelSocialButton_Update = <function> defined @TitanSocial\TitanSocial.lua:1233 PawnItemComparer = <function> defined @Pawn\Pawn.lua:3923 MultiBarLeftButton7 = MultiBarLeftButton7 { } AudioOptionsVoicePanelOutputDeviceDropdownButtonHighlightTexture = AudioOptionsVoicePanelOutputDeviceDropdownButtonHighlightTexture { } LE_GAME_ERR_INVALID_FOLLOW_PVP_COMBAT = 353 MerchantItem4AltCurrencyFrameItem1Text = MerchantItem4AltCurrencyFrameItem1Text { } BINDING_NAME_NAMEPLATES = "Show Enemy Name Plates" CHAT_HEADER_SUFFIX = ": " MultiBarBottomRightButton8Shine5 = MultiBarBottomRightButton8Shine5 { } IsReferAFriendLinked = <function> defined =[C]:-1 UnitFrameManaBar_UnregisterDefaultEvents = <function> defined @Interface_TBC\FrameXML\UnitFrame.lua:600 TitanPanelAutoCombatLoggerButtonRightClickMenuLeft = TitanPanelAutoCombatLoggerButtonRightClickMenuLeft { } WhatsTrainingFrameRow3Spell = WhatsTrainingFrameRow3Spell { } CALENDAR_RAID_RESET_DESCRIPTION = "%1$s resets at %2$s." CraftExpandTabLeft = CraftExpandTabLeft { } Questie_ItemButton18Shine14 = Questie_ItemButton18Shine14 { } BOOST2_WARRIOR_COLOSSUSSMASH = "Use |cFFFFFFFFColossus Smash|r.
Thanks for the report, I disabled support for 2.5.2 TBC guild banks for now.
Since the error popped up regardless of being a guild master, there are probably a small amount of guild masters and it's not a trivial fix since Blizzard reworked the guild bank UI
In reply to Ketho17:
I'm very happy to hear you are on the mend. I went through Covid myself, although it was extremely mild, like a mild cold, without even a fever, although I tested positive. I'm thinking it is probably because I was vaccinated and boosted perhaps. Remember, your health comes first. People that enjoy your addon, which I am one, can definitely wait!
In reply to Ketho17:
I'm very happy to hear you are on the mend. I went through that myself, although it was extremely mild, like a mild cold, without even a fever, although I tested positive. I'm thinking it is probably because I was vaccinated and boosted perhaps. Remember, your health comes first. People that enjoy your addon, of which I am one, can definitely wait!
Also looking for a wrath update, thanks.
Can you update for WOTLK Classic please? Would be awesome, thanks a lot!
Got this error today. Patch 9.2
3x ...argerMacroIconSelection\LargerMacroIconSelection-v1.7.0.lua:253: bad argument #3 to 'format' (string expected, got boolean)
[string "=[C]"]: in function `format'
[string "@LargerMacroIconSelection\LargerMacroIconSelection-v1.7.0.lua"]:253: in function <...argerMacroIconSelection\LargerMacroIconSelection.lua:249>
Locals:
(*temporary) = "%s |cff71D5FF%s|r"
(*temporary) = "90"
(*temporary) = false
(*temporary) = "string expected, got boolean"
In reply to NILLX__:
Were you using the macro window, equipment manager or guild bank when this error happened? I need that information to better fix the error, thanks
In reply to Ketho17:
It happened when i was making a macro
In reply to NILLme:
Thanks, this error should be fixed in v1.7.1
In reply to Ketho17:
Thanks
Workaround for the "sf is nil" error. Add "if not sf then return end" under line 208. I suspect the addon still works but early in the game before macros come up: whatever sf is; is still nil.
In reply to epigramx:
Thanks for that. That's gotten rid of the error but we seem to have lost the search in the patch.
In reply to ZalidTheBur:
Thanks for the error log. I discovered it will no longer be possible to increase the amount of icons in the icon selector for the guild bank because Blizzard rewrote it.
People would probably care more about the search bar which should still be fixable. I would need to resub to get access to a guild bank but I'm not planning to pay to maintain my addons.
Please add my battletag (<snip>, I'm on EU if they don't support cross-region friends yet) or join my discord so I can create a guild on the PTR and test the guild bank 😊In reply to ZalidTheBur:
The guild bank search bar should be fixed again in v1.7.0 🙂
In 9.1.5 this still works, but it gives an error, "Message: ...argerMacroIconSelection\LargerMacroIconSelection.lua:209: attempt to index local 'sf' (a nil value)"
In reply to epigramx:
It works fine for me in 9.1.5. How do I reproduce the error? Was it at the guild bank? Do you have the error log? You don't have to include the addon list, just the stack trace.
In reply to Ketho17:
Popped up for me at the guild bank.
Date: 2021-11-04 15:18:08
ID: 1
Error occured in: Global
Count: 1
Message: ...argerMacroIconSelection\LargerMacroIconSelection.lua line 209:
attempt to index local 'sf' (a nil value)
Debug:
[string "=[C]"]: ?
[string "@LargerMacroIconSelection\LargerMacroIconSelection.lua"]:209: Initialize()
[string "@LargerMacroIconSelection\LargerMacroIconSelection.lua"]:201:
...argerMacroIconSelection\LargerMacroIconSelection.lua:174
[string "=[C]"]: LoadAddOn()
[string "@..\FrameXML\UIParent.lua"]:509: UIParentLoadAddOn()
[string "@..\FrameXML\UIParent.lua"]:564: GuildBankFrame_LoadUI()
[string "@..\FrameXML\UIParent.lua"]:2001:
..\FrameXML\UIParent.lua:1287
You're doing god's work with this addon. I can't believe Blizzard didn't have this feature. I've been annoyed for years that they have 1 billion icons in the macro selection and no search box.
Lua Error when opening the gbank added in TBCC today:
1x ...argerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua:209: attempt to index local 'sf' (a nil value)
[string "@LargerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua"]:209: in function `Initialize'
[string "@LargerMacroIconSelection\LargerMacroIconSelection-v1.6.1.lua"]:201: in function <...argerMacroIconSelection\LargerMacroIconSelection.lua:175>
[string "=[C]"]: in function `LoadAddOn'
[string "@Interface_TBC\FrameXML\UIParent.lua"]:364: in function `UIParentLoadAddOn'
[string "@Interface_TBC\FrameXML\UIParent.lua"]:399: in function `GuildBankFrame_LoadUI'
[string "@Interface_TBC\FrameXML\UIParent.lua"]:1212: in function <Interface_TBC\FrameXML\UIParent.lua:666>
Locals:
self = <unnamed> {
0 = <userdata>
UpdateButtons = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:370
Initialize = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:208
UpdateTextures = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:434
OnEvent = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:175
}
sf = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'sf' (a nil value)"
activeFrame = <table> {
}
LoadFileData = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:84
InitSearch = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:131
frames = <table> {
MacroPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:42
GearManagerDialogPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:55
GuildBankPopupScrollFrame = <function> defined @LargerMacroIconSelection\LargerMacroIconSelection.lua:68
}
origSize = <table> {
}
origNum = <table> {
}
_G = <table> {
ERR_OUT_OF_CHI = "Not enough chi"
DH_HAVOC_CORE_ABILITY_2 = "Strong melee attack that consumes Fury. If it critical strikes, some Fury is refunded."
BT4Button85Shine14 = BT4Button85Shine14 {
}
GetTrainerServiceTypeFilter = <function> defined =[C]:-1
UNIT_NAMES_COMBATLOG_TOOLTIP = "Color unit names."
SetTrainerServiceTypeFilter = <function> defined =[C]:-1
LE_GAME_ERR_CHAT_RAID_RESTRICTED_TRIAL = 776
SPELL_FAILED_CUSTOM_ERROR_71 = "This partygoer wants to dance with you."
LE_GAME_ERR_PET_SPELL_TARGETS_DEAD = 399
Atr_StackPriceCopperMiddle = Atr_StackPriceCopperMiddle {
}
CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture = CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture {
}
TitanPanelSocialButton_Update = <function> defined @TitanSocial\TitanSocial.lua:1233
PawnItemComparer = <function> defined @Pawn\Pawn.lua:3923
MultiBarLeftButton7 = MultiBarLeftButton7 {
}
AudioOptionsVoicePanelOutputDeviceDropdownButtonHighlightTexture = AudioOptionsVoicePanelOutputDeviceDropdownButtonHighlightTexture {
}
LE_GAME_ERR_INVALID_FOLLOW_PVP_COMBAT = 353
MerchantItem4AltCurrencyFrameItem1Text = MerchantItem4AltCurrencyFrameItem1Text {
}
BINDING_NAME_NAMEPLATES = "Show Enemy Name Plates"
CHAT_HEADER_SUFFIX = ": "
MultiBarBottomRightButton8Shine5 = MultiBarBottomRightButton8Shine5 {
}
IsReferAFriendLinked = <function> defined =[C]:-1
UnitFrameManaBar_UnregisterDefaultEvents = <function> defined @Interface_TBC\FrameXML\UnitFrame.lua:600
TitanPanelAutoCombatLoggerButtonRightClickMenuLeft = TitanPanelAutoCombatLoggerButtonRightClickMenuLeft {
}
WhatsTrainingFrameRow3Spell = WhatsTrainingFrameRow3Spell {
}
CALENDAR_RAID_RESET_DESCRIPTION = "%1$s resets at %2$s."
CraftExpandTabLeft = CraftExpandTabLeft {
}
Questie_ItemButton18Shine14 = Questie_ItemButton18Shine14 {
}
BOOST2_WARRIOR_COLOSSUSSMASH = "Use |cFFFFFFFFColossus Smash|r.
|cFFFFFFFFColossus Smash|r increases your damage."
CinematicFrameRaidBossEmoteFrame = CinematicFrameRaidBossEmoteFrame {
}
ScrollTable3Row12col13text = ScrollTable3Row12col13text {
}
CompactRaidFrameManagerDisplayFrameHiddenModeToggleTopRight = CompactRaidFrameManagerDisplayFrameHiddenModeToggleTopRight {
}
LE_GAME_ERR_ONLY_ONE_QUIVER = 32
GetMonitorAspectRatio = <function> defined =[C]:-1
TrinketMenu_Trinket1Shine13 = TrinketMenu_Trinket1Shine13 {
}
LOSS_OF_CONTROL_DISPLAY_FEAR = "Feared"
Graphics_QualityText = Graphics_QualityText {
}
LibDBIcon10_BugSack = LibDBIcon10_BugSack {
}
CompactUnitFrameProfilesSaveButton = CompactUnitFrameProfilesSaveButton {
}
RaidGraphics_EnvironmentalDetailSlider = RaidGraphics_EnvironmentalDetailSlider {
}
Is64BitClient = <
In reply to SunfyreBlazing:
Thanks for the report, I disabled support for 2.5.2 TBC guild banks for now.
Since the error popped up regardless of being a guild master, there are probably a small amount of guild masters and it's not a trivial fix since Blizzard reworked the guild bank UI
will it be possible to change the search like weak aura? With weak aura you can search in different languages your icon.