ZOMGBuffs

206 - 5.0.4 Patch

What does the provided patch do?
fix most errors in ZOMG itself as an easy start to realy fix zomg :))

Name Description Size MD5
504-v2.patch Extended Patch 15.2 KiB 54bc3598cfa1...
rogue.patch rogue patch 956 B 5626a82d38dc...
hunter_pet.patch &emdash; 849 B 4f7ce4670dcf...
User When Change
Netrox Sep 06, 2012 at 17:14 UTC

Added attachment hunter_pet.patch

Netrox Sep 06, 2012 at 14:47 UTC

Added attachment rogue.patch

thelibrarian Sep 06, 2012 at 14:12 UTC Changed assigned to from Zeksie to thelibrarian
thelibrarian Sep 06, 2012 at 14:12 UTC
Netrox Sep 06, 2012 at 13:24 UTC

Deleted attachment 504.patch: deprecated patch

Netrox Sep 06, 2012 at 13:22 UTC

Added attachment 504-v2.patch

Netrox Sep 05, 2012 at 17:31 UTC

Added attachment 504.patch

Netrox Sep 05, 2012 at 17:31 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of davenroth davenroth Sep 07, 2012 at 01:09 UTC - 0 likes

    I believe the most important paladin reminder buff is Sacred Shield. For a prot paladin, it comprises around 3k-5k of self healing, and probably moreso for holy. The moveable icon was indispensable. I installed the alpha version & I did not see an option for it.

    Of course the earthshield tracker for resto shaman was insanely useful as well.

  • Avatar of zeroglitch zeroglitch Sep 06, 2012 at 23:44 UTC - 0 likes

    Dark Intent isn't depreciated, the spell ID has changed though. It is now 109773. Updating the id in line 978 to 109773 in the ZOMGBuffs_BuffTehRaid.lua fixes the issue some are having with it not showing.

  • Avatar of Netrox Netrox Sep 06, 2012 at 17:13 UTC - 0 likes

    found another little bug for hunter.

  • Avatar of thelibrarian thelibrarian Sep 06, 2012 at 15:40 UTC - 0 likes

    Well, that's easy enough. BuffTheRaid really doesn't need LibGroupTalents anymore then.

  • Avatar of Netrox Netrox Sep 06, 2012 at 15:32 UTC - 0 likes

    it seems that Improved Earth Shield is gone and Earth Shield now has always 9 Stacks (http://www.wowhead.com/spell=974) so you could remove the check in the bufftheraid module.

    no idea what about inner fire.

    Last edited Sep 06, 2012 by Netrox
  • Avatar of thelibrarian thelibrarian Sep 06, 2012 at 15:25 UTC - 0 likes

    Fixed them - forgot to do a recursive search. Unfortunately that breaks Improved Earth Shield (if it even still exists, haven't really kept up with all the class changes), and possibly Inner Fire.

    Bumped the TOCs too.

    Last edited Sep 06, 2012 by thelibrarian
  • Avatar of Netrox Netrox Sep 06, 2012 at 15:15 UTC - 0 likes

    LGT is still being used in bufftheraid and selfbuff

  • Avatar of Netrox Netrox Sep 06, 2012 at 15:06 UTC - 0 likes

    Nice, i'm happy to help :)

    just want to mention: these fixes are some kind of "remove old stuff to kill errors" if there are some new spells/buffs (e.g. Monk) they're not handled. so maybe someday someone who knows the code better than me should take a look :)

    EDIT: The module TOCs are not yet updated :)

    Last edited Sep 06, 2012 by Netrox
  • Avatar of thelibrarian thelibrarian Sep 06, 2012 at 14:58 UTC - 0 likes

    Thanks, applied it.

    For now I've just disabled the LibGroupTalents interface entirely. You'll lose the automatic role detection, but it should still show the icons for if the roles are set using the Blizzard interface (I *THINK*).

  • Avatar of Netrox Netrox Sep 06, 2012 at 14:48 UTC - 0 likes

    Hi thelibrarian,

    thanks for commiting my changes.

    i attached a patch for rogue. dk seems to work.

    LibGroupTalents-1.0 is still buggy. i posted a patch there too. hope they'll apply it (http://www.wowace.com/addons/libgrouptalents-1-0/tickets/17-5-0-4-patch/)

Facts

Last updated
Sep 06, 2012
Reported
Sep 05, 2012
Status
Started - Work on this issue has begun.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees