You must login to post a comment. Don't have an account? Register to get one!

• 

  • #6

  rismisner Wed, 07 Oct 2009 07:38:02

  giving this a low priority given the flexibility and power of the work-around and uncertainty about the full extent of pronoun issues.

• 

  • #5

  rismisner Wed, 07 Oct 2009 07:36:32

  Note there is a functioning work-around for this in 3.2.2.10

  Disable the [ ] Whisper Target feature

  write the speech with 2 lines:

  I put a shield on <Target>| /t <target> I put a shield on YOU!

• 

  • #4

  rismisner Wed, 07 Oct 2009 07:24:16

  I like the idea of redefining the nature of <third person|me> as a more general <third person|pronoun> ... just calling that and renaming some variables would make the code/logic more sensible than having variables called "me"

• 

  • #3

  rismisner Wed, 07 Oct 2009 07:22:30

  I am hesitant about whether this is really an isolated special case, or part of an even bigger issue... Are there other cases where you want to use a pronoun other than:

  A) first person pronouns: already supported in 3.2.2.10 to avoid naming yourself in the third person, for any possible substitution using <target|me>

  B) gender pronouns: already supported in 3.2.2.10 for any substitution who's gender can be determined, using <target*him*her>

  C) second person pronouns: the topic of this ticket

  This applies to "[X] Whisper <target>"

  If you write"/t <target> I cast a spell on you" then you don't need parsing logic to substitute the pronoun for you in an automated "smart" way

  Channel = Reply is another whisper feature (see ticket 64) but then you know your targets are whispers, so again you don't need support for smart parsing/substitution forms in "Thanks for the buff, <caster|you>" You can just say "/t <caster> thank YOU!"

  I'm not seeing other cases, so i guess we can start with a simplistic solution that treats this as a special case, just for <target> in a "whisper target" scenario, and build on it later. But if ideas come to light related to this before I start on it, that may help plan the implementation for growth.

  Last edited on 07 Oct 2009 by rismisner
• 

  • #2

  rismisner Wed, 07 Oct 2009 07:15:55

  The nature of the parse is going to want to treat <target|you> as a third-person or "me" check if using the same character, but I wonder if that's OK from the sense of string parsing, and we could do this in the implementation of whether or not we select the pronoun ... i.e. treat it as an expansion of <third person|me> to <third person|pronoun> and enhance the logic to be more general about detecting when the pronoun should be used.

  Currently in 3.2.2.10, the logic simply decides that if the substitution value for ANY <subtitution> == UnitName("player") then use the pronoun.

  The target of a whisper appears to be a special case which could accept fairly simple additional handling to detect if you are performing the "[X] Whisper <target>" function then go back and replace <target> with the pronoun.

• 

  • #1

  rismisner Wed, 07 Oct 2009 07:11:12

  I misnamed this feature but I don't know what else to call it... Technically using the name is third person, and you is second person, and the "|" is read "or" from programming languages, so it's really a third person or second person toggle that should be called <third person|you> but that's also a bad name for this idea because technically the parser treats that exactly the same as <third person|me> so... whatever, not important... LOL