Rarity

72 - Plundered Treasure counts as loot attempt for Skyshard

What steps will reproduce the problem?

1. Use a Potion of Luck and kill baddies
2. Open a Plundered Treasure in the Vale
3. Profit!

What is the expected output? What do you see instead?

Rarity counts opening a Plundered Treasure as a loot attempt for a Skyshard, but from what I can find, there is no chance for a Skyshard to drop from a Plundered Treasure.

http://www.wowhead.com/item=87391
http://www.wowhead.com/item=86547

What version of the product are you using?

r237

Thanks for the great addon! :)

User When Change
Allara Mar 05, 2014 at 21:41 UTC Changed status from Replied to Fixed
Urtgard Mar 05, 2014 at 21:38 UTC Changed status from Waiting to Replied
Allara Mar 05, 2014 at 18:42 UTC Changed status from Replied to Waiting
Urtgard Mar 04, 2014 at 21:45 UTC Changed status from Waiting to Replied
Allara Mar 04, 2014 at 19:57 UTC Changed status from Replied to Waiting
Allara Mar 04, 2014 at 19:38 UTC Changed status from Waiting to Replied
Allara Mar 04, 2014 at 18:50 UTC Changed status from Replied to Waiting
Urtgard Mar 04, 2014 at 14:15 UTC Changed status from Waiting to Replied
Allara Feb 16, 2014 at 23:09 UTC Changed status from New to Waiting
nmb3000 Feb 16, 2014 at 22:33 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 10 comments
  • Avatar of Urtgard Urtgard Mar 05, 2014 at 21:38 UTC - 1 like

    I tested no target, target alive, unlooted target and looted target.

    Neither the containers from your bag (Plundered Treasure and Treasures of the Vale tested) nor the world objects (Ancient Guo-Lai Cache tested) cause a failure.

    The debug info looks like this for every try:

  • Avatar of Allara Allara Mar 05, 2014 at 18:42 UTC - 0 likes

    Hmm, I think what might be happening is Blizzard started sending NPC IDs when you loot items from containers or world objects. I'm pretty sure it didn't do this earlier. To Rarity, if this happens when you are also targeting a dead NPC, it thinks you're looting the NPC you targeted.

    Luckily there actually is a way to detect this. I've just put up r240. This build should only detect attempts when you loot NPCs.

    I've tested this a bit, including with Treasures of the Vale. I haven't tested with a world object (i.e. a chest) yet. Can you test more and see if it works as expected?

  • Avatar of Urtgard Urtgard Mar 04, 2014 at 22:06 UTC - 0 likes

    It won't make a difference whether the target is looted or not.

  • Avatar of Allara Allara Mar 04, 2014 at 21:50 UTC - 0 likes

    Dead *unlooted* target is what should trigger it. A dead target that you already looted shouldn't. Is that the case?

  • Avatar of Urtgard Urtgard Mar 04, 2014 at 21:45 UTC - 0 likes

    You are right.

    Dead target:

    http://abload.de/img/dead3ok4r.jpg

    Living target:

    http://abload.de/img/aliveock0z.jpg

    No target:

    http://abload.de/img/nor5ka0.jpg

  • Avatar of Urtgard Urtgard Mar 04, 2014 at 19:52 UTC - 0 likes

    Fortunately I still got the complete screenshots. http://abload.de/img/wowscrnshot_030414_14zekd9.jpg http://abload.de/img/wowscrnshot_030414_14zrjqe.jpg

    I think your presumption is perfectly possible.

    I will try it with the new alpha.

  • Avatar of Allara Allara Mar 04, 2014 at 19:38 UTC - 0 likes

    Looking at the code, the only way I can see this happening is if you loot a container from your bag while you are targeting a dead NPC that you haven't looted yet. If this is the case, I don't think there's anything Rarity can do about it. It thinks you're looting the corpse you targeted, and WoW doesn't tell it otherwise.

    I've just pushed out a new alpha, r239. Can you get that update and run this test again. I adjusted the debug output to be more helpful in this situation.

    Last edited Mar 04, 2014 by Allara
  • Avatar of Allara Allara Mar 04, 2014 at 18:49 UTC - 0 likes

    Are you targeting a dead mob when you loot the bag and Rarity detects that as an attempt?

    And the inverse: when Rarity does not detect an attempt, are you looting the bag without targeting a mob?

    Last edited Mar 04, 2014 by Allara
  • Avatar of Urtgard Urtgard Mar 04, 2014 at 14:15 UTC - 0 likes

    I started to farm the skyshards by myself and i noticed a few things:

    • When Rarity fires false attempts, it is for every kind of treasure.
    • The wrong detection turns up while you farm the mobs only. But not every time you farm the mobs.
    • I never got this problem after /reload ui or a relog.

    Output when Rarity fires false attempts:

    wrong

    The expected output:

    right

    I hope this helps. Maybe you can fix it before I get my mount^^

  • Avatar of Allara Allara Feb 16, 2014 at 23:09 UTC - 0 likes

    Rarity isn't explicitly detecting loot from Plundered Treasure (or Treasures of the Vale or Ancient Guo-Lai Cache). I'm not sure why it's firing an attempt for this. I need your help to investigate.

    Turn on Debug mode (it's toward the bottom of the main Rarity options screen).

    Then, when you loot a Plundered Treasure, copy everything that Rarity prints into your chat log and paste it here as a comment on this ticket.

    Thanks!

  • 10 comments

Facts

Last updated
Mar 05, 2014
Reported
Feb 16, 2014
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees