WowAce

lightweight tag 2bd72e513b796036ed236a91ce5f49e6f074e57a v2.1.8-beta
Author:    Cory Koehn <[email protected]>
Date:    Thu Jul 2 02:48:20 2026 -0500

commit 2bd72e513b796036ed236a91ce5f49e6f074e57a
Author: Cory Koehn <[email protected]>
Date:   Thu Jul 2 02:48:20 2026 -0500

    Performance/memory optimizations, entrance audit fixes, city-dungeon zone pins (2.1.8 beta)

    Performance (no behavior change):
    - AreaLabelPostHook: early-exit before the per-frame C_Map queries and gsub
      string work when map/label/cursor inputs are unchanged; cache static map
      names and the last StripColors result.
    - GetPins: one-entry result cache keyed on (map, level, faction, pin toggles);
      builds that hit an unresolved instance name (login warm-up) are not cached.
      The OnShow/Maximize refresh hooks keep their exact timing - rebuilds are
      just cheap now.
    - GetProfessionDetails: build via table.concat instead of repeated
      concatenation. Professions deliberately stay uncached (SKILL_LINES_CHANGED
      does not fire on rank-ups; a cache would show stale skill numbers).

    Memory/load:
    - Gate base Classic-keyed zones off MoP/Cata clients (they use the retail-ID
      block; zero key overlap) and Outland/TBC instance/raid/herb/node tables off
      Era/SoD (~700 and ~450 lines of dead table constructors respectively).
    - Drop AceHook-3.0 entirely (embedded but never used) from NewAddon, all five
      .toc files, .pkgmeta, and the fetch-libs scripts.
    - Remove dead code: dbg() helper, never-read defaults (showSkinning,
      zoneTextLocation, profTextLocation), the write-only continent field on 298
      data entries plus its feeder locals, and trim the profs match table to the
      three displayed professions (locale keys removed to match).

    Entrance coordinate audit (all 166 pins verified per client against
    HandyNotes_DungeonLocations and Wowhead/guide data):
    - Gate of the Setting Sun: Vale-map coords were used on the Dread Wastes map
      (pin in the ocean); now pinned at the gate/rope approach (75.0, 21.0).
    - Trial of the Champion: moved from the Dalaran city map to Icecrown (it is at
      the Argent Tournament); clusters with Trial of the Crusader.
    - Blackrock Caverns: moved from Twilight Highlands to the Burning Steppes
      Blackrock Mountain cluster (29.0, 37.0).
    - The Stockade / Ragefire Chasm: classic city coords landed wrong on the
      redrawn Cata+ city maps; patched to (50.4, 66.4) / (52.4, 58.0) in the
      MoP/Cata block, classic clients unchanged.
    - Karazhan Crypts (SoD): corrected to the Morgan's Plot crypt (41.2, 78.9).

    City dungeons now also shown on their containing zones via instanceCoords
    overrides, with positions projected through Blizzard's UiMapAssignment map
    bounds: Stockade on Elwynn (classic and Cata maps), Ragefire Chasm on Durotar
    (clamped onto the visible city footprint; Orgrimmar is cropped at the map's
    top edge), and The Violet Hold on Crystalsong Forest at Dalaran's position.

    Version 2.1.8 across all five .toc files.

    Co-Authored-By: Claude Fable 5 <[email protected]>
    Claude-Session: https://claude.ai/code/session_013Z2zdhJS1SKhkvSYXCFoRo