Talent change taint #67

  • Defect
  • Replied
Assigned to xuerian
  • _ForgeUser3490487 created this issue Jan 6, 2013

    What steps will reproduce the problem?
    1. attempt to change talents

    What version of the product are you using?

    Do you have an error log of what happened?
    Date: 2013-01-05 22:17:08
    ID: 7
    Error occured in: AddOn: XLoot_Master
    Count: 1
    Message: Error: AddOn XLoot_Master attempted to call a forbidden function (RemoveTalent()) from a tainted execution path.
       [C]: RemoveTalent()
       ...rface\AddOns\Blizzard_TalentUI\Blizzard_TalentUI.lua:10: OnAccept()
       ..\FrameXML\StaticPopup.lua:3897: StaticPopup_OnClick()
       [string "*:OnClick"]:1:
          [string "*:OnClick"]:1
      InspectFix, v4.2.1
      Swatter, v4.1.0 (<%codename%>)
      NPCScan, v5.0.0.5
      Ace3, v
      ACP, v3.4.1
      ActionBarSaver, v
      AdiBags, vv1.6.2
      Altoholic, v5.1.001
      AtlasLootLoader, vv7.04.01
      Auctionator, v3.1.0
      BadBoy, v11.431
      Bartender4, v4.5.8
      BigBrother, v3.8.0 beta 1
      BloodShieldTracker, v0.23
      CensusPlus, v6.0.0
      ColorPickerPlus, v
      DataStore, v5.1.001
      DataStoreAchievements, v5.1.001
      DataStoreAgenda, v5.1.001
      DataStoreAuctions, v5.1.001
      DataStoreCharacters, v5.1.001
      DataStoreContainers, v5.1.001
      DataStoreCrafts, v5.1.001
      DataStoreCurrencies, v5.1.001
      DataStoreInventory, v5.1.001
      DataStoreMails, v5.1.001
      DataStorePets, v5.1.001
      DataStoreQuests, v5.1.001
      DataStoreReputations, v5.1.001
      DataStoreSpells, v5.1.001
      DataStoreStats, v5.1.001
      DataStoreTalents, v5.1.001
      DBMCore, v
      DBMHeartofFear, v
      DBMMogushanVaults, v
      DBMSpellTimers, v
      DocsDebugRunes, v1.2
      Factionizer, v05.01.00 12.11.28
      Fatality, v2.3b
      GnomishVendorShrinker, v5.0.1.15
      GoblinVendorFilter, vv1.0.9-1-g31156a3
      Grid, v5.1.0.1553
      GridManaBars, v1.04
      GTFO, v4.18.1
      LibBabbleFaction30, v
      MikScrollingBattleText, v5.7.125
      MogIt, v3.0.6
      Niggles, v2.05
      Omen, v3.1.8
      OmniCC, v5.1.3
      Overachiever, v0.70
      PetJournalEnhanced, v2.6.1
      PetKnown, v
      PokemonTrainer, v1.0.1
      Postal, v3.5.1
      PowerAuras, v4.23.11
      Prat30, v3.5.3
      Prat30Libraries, v
      Quartz, v3.1.1
      RaidAchievement, v1.111
      RaidAchievementAchieveReminder, v
      RaidAchievementPandaRaids, v
      RatingBuster, vr395
      RSA, v2.853
      RSADeathKnight, v
      Scrap, v11.7
      ScrapMerchant, v
      ScrapSpotlight, v
      SexyMap, v2.4
      ShadowedUnitFrames, vv3.7.4
      ShinyBuffs, v1.0.2
      Skada, v1.4-8
      SkadaCC, v1.0
      SkadaDamage, v1.0
      SkadaDamageTaken, v1.0
      SkadaDeaths, v1.0
      SkadaDebuffs, v1.0
      SkadaDispels, v1.0
      SkadaEnemies, v1.0
      SkadaHealing, v1.0
      SkadaPower, v1.0
      SkadaThreat, v1.0
      SlideBar, v4.1.0 (<%codename%>)
      SpamageMeters, v1.6.6b1
      TidyPlates, v6.8.2 (R559)
      TidyPlatesNeon, v
      TidyPlatesHub, v
      TidyPlatesWidgets, v
      TipTac, v12.10.30
      TipTacItemRef, v12.08.30
      TipTacTalents, v12.09.05
      XLoot, vz4-alpha-28-g60662c2
      XLootFrame, vz4-alpha-28-g60662c2
      XLootMaster, vz4-alpha-28-g60662c2
      BlizRuntimeLib_enUS v5.1.0.50100 <us>

  • _ForgeUser3490487 added the tags New Defect Jan 6, 2013
  • Xuerian removed a tag New Jan 6, 2013
  • Xuerian added a tag Waiting Jan 6, 2013
  • Xuerian posted a comment Jan 6, 2013

    As I replied to your other ticket, this is not a XLoot issue. This is a Blizzard issue. Blizzard's InterfaceOptionsFrame taints whenever a addon adds itself to the Interface options/Addon menu. It doesn't matter what addon - XLoot just gets blamed because it touched it last. Try disabling it, you'll get the error on another addon so long as they add a option panel.

  • Xuerian removed a tag Waiting Jan 6, 2013
  • Xuerian added a tag Replied Jan 6, 2013
  • _ForgeUser3490487 posted a comment Jan 6, 2013

    hurf, silly blizzard. Oh well, thanks

    edit: wow i really did file more than one ticket! i wonder what caused that brain fart

    Edited Jan 6, 2013
  • Xuerian posted a comment Jan 6, 2013

    Only suggestion is to /reload before trying to do that. Which is annoying in combat.

  • _ForgeUser405586 posted a comment Feb 6, 2013

    Actually, given the taint stack it's more likely this is caused by Xloot_Master's use of StaticPopupDialogs, which taints at least one of the 4 entries each time it confirms a loot assignment. Then later when the talent UI uses that same entry to reset talents it dies.
    Xloot_Master does use preferredIndex = 3, but that just makes the problem less likely, not impossible.

    Given the frequency of prompts issued by Xloot_Master, it should probably be using a taint-free replacement like http://www.wowace.com/addons/libdialog-1-0/ instead of reliably tainting StaticPopupDialogs.

    Alternatively, xloot could use the unmodified StaticPopupDialogs["CONFIRM_LOOT_DISTRIBUTION"] from the default FrameXML and securehook the OnAccept function to add the xloot announcement.

To post a comment, please login or register a new account.