Master loot announce error after group disband #115


  • Defect
  • Accepted
Open
Assigned to mrfixlt
  • Lombra created this issue Jan 8, 2014

    What steps will reproduce the problem?
    1. Be in a group.
    2. Use master loot.
    3. Have a master looted item drop.
    4. Disband group.
    5. Try to award someone the loot.

    SendChatMessage(): Unknown chat type
    
    [C]: ?
    [C]: ?
    [C]: in function `SendChatMessage'
    Interface\\AddOns\\XLoot_Master\\Master.lua:109: in function `AnnounceAward'
    Interface\\AddOns\\XLoot_Master\\Master.lua:134: in function `func'
    Interface\\FrameXML\\UIDropDownMenu.lua:730: in function `UIDropDownMenuButton_OnClick'
    [string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>
    
  • Lombra added the tags New Defect Jan 8, 2014
  • Xuerian posted a comment Jan 8, 2014

    Thanks for the excellent report. I'll assign Dridzt and look in to it myself when I get a chance, should be as simple as verifying chat target and falling back to say.

  • Xuerian removed their assignment Jan 8, 2014
  • Xuerian assigned issue to _ForgeUser422445 Jan 8, 2014
  • Xuerian removed a tag New Jan 8, 2014
  • Xuerian added a tag Accepted Jan 8, 2014
  • MrFIXlT posted a comment Jan 11, 2014

    What is the output user setting?

    I'm inclined to only consider this a bug if it happens when "AUTO" is selected.
    If the user has picked a group channel to announce into and then tries to award while out of group that would fall under user error imho :P

    With that said I'll add the instance chat to options / auto output since with the inclusion of Flex it is now possible to have x-realm masterlooted groups and also make the auto functionality such that it goes to widest audience available.

    So: Raid Warning > Instance Chat > Raid/Party > Say.


    Edited Jan 11, 2014
  • _ForgeUser405586 posted a comment Jan 11, 2014

    I'd argue a lua error is *always* a flaw in the addon and not the user. If the user specifies something that doesn't make sense, the addon should either choose some sane backup behavior or as a last resort give an explanatory error message - a lua crash does not qualify...


    Edited Jan 11, 2014
  • Lombra posted a comment Jan 12, 2014

    Default channel is set to "Highest available". Guild echo unchecked. (but I'm in a guild anyway)

    Didn't get the update yet, but as far as I can tell it used "AUTO" for chat type in you're not in any group.


    Edited Jan 12, 2014

To post a comment, please login or register a new account.