Guardian Druid Mastery #50


  • New
  • Defect
Open
Assigned to whitetooth3
  • _ForgeUser306695 created this issue Sep 17, 2012
    <s>On my Guardian Druid, Agility and Dodge are both calculated at over 54,700 NEGATIVE TankPoints per one stat point.</s>
    Edit: Dodge is fixed & looks accurate so far!

    Also, Mastery's armor bonus isn't calculated.
  • _ForgeUser306695 added the tags New Defect Sep 17, 2012
  • _ForgeUser545770 posted a comment Sep 24, 2012

    I have been having the same issue the majority of the numbers are designed for plate armor instead of factoring in the stats for guardian and armor bonuses. So all leather is close to -35k+... Please fix this for druids...

  • _ForgeUser581183 posted a comment Sep 25, 2012

    Can you post the results when you hover over your Total Reduction % in TankPoints calculator:

    screenshot

    e.g.

    DamageTaken: 15.7323% = 
          Avoidance: 50.6844% *
          Block: 90.9220% *
          Crit: 100.00% *
          Armor: 40.1633% *
          Damage Taken Modifier: 85.0000%
    

    so we can see which number is out of whack.


    Edited Sep 25, 2012
  • _ForgeUser306695 posted a comment Sep 25, 2012

    Damage Taken: 32.8087% =
    Avoidance: 78.5934% *
    Block: 100% *
    Crit: 100% *
    Armor: 41.7448% *
    Damage Taken Modifier: 100.0000%

    In the calculator, raising either agility or dodge by 1 point immediately lowers the Dodge(%) in the Combat Table section from 17.01 to 4.16. Past that first point, though, additional points in either only result in the usual small positive gains in dodge %.


    Edited Sep 25, 2012
  • _ForgeUser581183 posted a comment Sep 26, 2012

    Ok, time to pull out the data analysis.

    TankPoints has been secretly recording all your stats. Every time your stats change (including changing equipped items, getting buffs), it records a snapshot of all your stats.

    You'll find them in your:

    D:\Games\World of Warcraft\WTF\Account\MIDNIGHTLYNX\SavedVariables\TankPoints.lua

    (of course you use your path to WoW, and your account name)

    Can you run through every possible combination of armor, e.g.:

    • equipping each item in each slot
    • equipping one item, then two items, then three items, then four...
    • equipping in order of head, neck, shoulders, back, ...
    • equipping in order of trinket 2, trinket 1, ring 2, ring 1, feet, legs, ...
    • unequipping everything on the left first, then the right
    • unequipping everything on the right first, then the left

    In other words can you come up with as many possible combinations

    • Dodge Rating
    • Agility
    • and any other stat that might affect druid's dodge.

    We'll have to update LibStatLogic so we can calculate the druid's

    • base Dodge Chance
    • Dodge Cap constant (Cd)
    • diminishing returns constant (k)
    • Agility-to-Dodge conversion ratio (Qd) - which we assume is fixed at 10,000 Agility -> 1% Dodge Chance (before diminishing returns)

    Post the PlayerStats variable from your TankPoints.lua file, e.g.:

    PlayerStats = {
        ["85,PALADIN,Human,2,76671,4320,164,101,97,12954,289,111,106,5065,19.107559204102,21.298873901367,2636,9.9442300796509,30.681768417358,84,0.46854072809219,10.47864151001,0,0,33.612854003906,2360,13.163763046265,21.163763046265,92,0.89803636074066,0.89803636074066,92,0.89803636074066,3.0747984647751"] = true,
        ["85,PALADIN,Human,3,76672,5915,172,101,97,7629,276,111,106,978,3.6894752979279,6.9291338920593,1636,6.171760559082,33.112697601318,2077,11.585227012634,16.595325469971,0,0,3,2018,11.256133079529,19.256134033203,606,5.9153265953064,5.9153265953064,606,5.9153265953064,11.049751758575"] = true,
        ["85,PALADIN,Human,3,76672,5656,172,101,97,7629,276,111,106,978,3.6894752979279,6.9291338920593,1636,6.171760559082,32.188003540039,2077,11.585227012634,16.595325469971,0,0,3,2018,11.256133079529,19.256134033203,606,5.9153265953064,5.9153265953064,606,5.9153265953064,11.049751758575"] = true,
        ["85,PALADIN,Human,2,76671,4115,164,97,97,11777,289,106,106,4004,15.104969024658,18.58217048645,2636,9.9442300796509,29.933305740356,84,0.46854072809219,15.478240966797,0,0,29.283988952637,1467,8.182728767395,16.182727813721,92,0.89803636074066,0.89803636074066,92,0.89803636074066,3.0747984647751"] = true,
        ["85,PALADIN,Human,2,76671,4707,164,97,97,9536,289,106,106,978,3.6894752979279,8.9287338256836,1636,6.171760559082,28.728338241577,2077,11.585227012634,16.594926834106,0,0,31.990718841553,2018,11.256133079529,19.256134033203,606,5.9153265953064,5.9153265953064,606,5.9153265953064,11.049751758575"] = true,
        ["85,PALADIN,Human,2,76671,4115,164,97,97,11777,289,106,106,3761,14.188258171082,17.918195724487,2636,9.9442300796509,29.933305740356,84,0.46854072809219,5.4782404899597,0,0,29.283988952637,1467,8.182728767395,16.182727813721,92,0.89803636074066,0.89803636074066,92,0.89803636074066,3.0747984647751"] = true,
        ["85,PALADIN,Human,2,76671,4115,164,97,97,12954,289,106,106,4113,15.516167640686,18.874694824219,2636,9.9442300796509,29.933305740356,84,0.46854072809219,10.478240013123,0,0,33.612854003906,2360,13.163763046265,21.163763046265,92,0.89803636074066,0.89803636074066,92,0.89803636074066,3.0747984647751"] = true,
        ["85,PALADIN,Human,3,76672,4923,172,97,97,7238,276,106,106,978,3.6894752979279,6.9287343025208,1636,6.171760559082,29.525831222534,1836,10.240961074829,15.250660896301,0,0,3,989,5.5165090560913,13.516509056091,414,4.041163444519,4.041163444519,414,4.041163444519,10.175588607788"] = true,
        ["85,PALADIN,Human,2,76671,4115,164,97,97,12954,289,106,106,4289,16.180122375488,19.340269088745,2636,9.9442300796509,29.933305740356,84,0.46854072809219,10.478240013123,0,0,33.612854003906,2360,13.163763046265,21.163763046265,92,0.89803636074066,0.89803636074066,92,0.89803636074066,3.0747984647751"] = true,
        ["85,PALADIN,Human,3,76672,6071,172,101,97,7629,276,111,106,978,3.6894752979279,6.9291338920593,1636,6.171760559082,33.665706634521,2077,11.585227012634,16.595325469971,0,0,3,2018,11.256133079529,19.256134033203,606,5.9153265953064,5.9153265953064,606,5.9153265953064,11.049751758575"] = true,
        ["85,PALADIN,Human,3,76672,5828,172,97,97,7114,276,106,106,978,3.6894752979279,6.9287343025208,1636,6.171760559082,32.802997589111,738,4.1164646148682,9.1261644363403,0,0,3,788,4.3953580856323,12.395358085632,606,5.9153265953064,5.9153265953064,606,5.9153265953064,12.049751758575"] = true,
    

    Ideally you would also strip off the leading [" and trailing "] = true,, so it's pure CSV:

    85,PALADIN,Human,2,76671,4320,164,101,97,12954,289,111,106,5065,19.107559204102,21.298873901367,2636,9.9442300796509,30.681768417358,84,0.46854072809219,10.47864151001,0,0,33.612854003906,2360,13.163763046265,21.163763046265,92,0.89803636074066,0.89803636074066,92,0.89803636074066,3.0747984647751
    85,PALADIN,Human,3,76672,5915,172,101,97,7629,276,111,106,978,3.6894752979279,6.9291338920593,1636,6.171760559082,33.112697601318,2077,11.585227012634,16.595325469971,0,0,3,2018,11.256133079529,19.256134033203,606,5.9153265953064,5.9153265953064,606,5.9153265953064,11.049751758575
    85,PALADIN,Human,3,76672,5656,172,101,97,7629,276,111,106,978,3.6894752979279,6.9291338920593,1636,6.171760559082,32.188003540039,2077,11.585227012634,16.595325469971,0,0,3,2018,11.256133079529,19.256134033203,606,5.9153265953064,5.9153265953064,606,5.9153265953064,11.049751758575
    85,PALADIN,Human,2,76671,4115,164,97,97,11777,289,106,106,4004,15.104969024658,18.58217048645,2636,9.9442300796509,29.933305740356,84,0.46854072809219,15.478240966797,0,0,29.283988952637,1467,8.182728767395,16.182727813721,92,0.89803636074066,0.89803636074066,92,0.89803636074066,3.0747984647751
    85,PALADIN,Human,2,76671,4707,164,97,97,9536,289,106,106,978,3.6894752979279,8.9287338256836,1636,6.171760559082,28.728338241577,2077,11.585227012634,16.594926834106,0,0,31.990718841553,2018,11.256133079529,19.256134033203,606,5.9153265953064,5.9153265953064,606,5.9153265953064,11.049751758575
    

    Ideally would you also save it as a CSV, open it in Excel, and then paste them into a new tab on my existing Google Document Spreadsheet, so i can see the values and begin graphing and performing linear regressions on them.

    At the very least it will let you understand the pain i'm going through, with absolutely no value to myself.


    Edited Sep 26, 2012
  • _ForgeUser306695 posted a comment Sep 26, 2012

    I managed *almost* all of that, but the Google Doc was giving me a hard time pasting it in. So here's my results in its own doc.


    Edited Sep 26, 2012
  • _ForgeUser306695 posted a comment Sep 26, 2012

    Okay, I did all that. Though your Google Doc didn't like me trying to paste huge amounts of characters in, so I trimmed it to just the columns relevant to Dodge chance.

    I didn't go through *EVERY* possible variation of gear. That would have been 70 million different permutations. But I went through a fair variety within the range I had the stats for.


    Edited Sep 26, 2012
  • _ForgeUser306695 posted a comment Sep 26, 2012

    If it would help, I can also remove my reforges in to dodge, to look at just Agility's contribution to dodge chance.

  • _ForgeUser306695 posted a comment Sep 26, 2012

    Or, conversely, reforge more to dodge if that's what you need to look at in more detail.

  • _ForgeUser581183 posted a comment Sep 26, 2012

    Ideally we want large ranges of everything.

    • from zero (bonus) Agility, and
    • zero Dodge Rating
    • to highest possible Agility, and
    • highest possible Dodge Rating

    i updated LibStatLogic about an hour ago with new druid numbers; hopefully they give reasonable numbers.

    i just updated TankPoints to that it would trigger the new LibStatLogic.


    Druids seem to have a huge benefit from Agility to dodge. For Paladin's and Warriors it's 10,000 Agility gives you +1% Dodge Chance.

    For Bears it looks like 243.6 Agility gives you +1% Dodge Chance.

    The fact there's such a different, i wonder if there's any other druid passive, spell, set bonus, buff, food, that "increases your dodge from agility by x".

    But for now i hope you'll have numbers that give reasonable results; even if they aren't theoretically perfect.

  • _ForgeUser306695 posted a comment Sep 27, 2012

    Much better. But the predicted Dodge % in TP Calculator is consistently 0.60 lower than what's actually on the character sheet, regardless of how much or how little gear I have on, or how much of that is from dodge rating VS from agility. Am I missing something? Like, do mobs have a native Expertise that negates .6% dodge?

    Also having some weirdness with it suggesting Ricket's Magnetic Fireball is 401 Tankpoints higher than Brawler's Trophy. (Ignoring special effects, obviously.)
    With neither of them equipped in the second trinket slot, my dodge is 18.69% (882 dodge, 4359 Agility).
    Mouseover predicts the Fireball's 340 agility will raise dodge +0.76% over an empty slot, which would mean 19.45%, but equipping it raises dodge to 19.60%, or +0.91%
    Mouseover for the Trophy predicts 340 dodge will result in +0.85% dodge chance over an empty slot, or 19.54% total. Actual result is 19.53%.

    I'll get you another stats log with a larger range of Dodge values probably in the morning.

    Any ETA on getting the Guardian druid's Mastery bonus included in Tankpoint values?


    Edited Sep 27, 2012
  • _ForgeUser581183 posted a comment Sep 27, 2012

    <<reply 976103="">>

    the predicted Dodge % in TP Calculator is consistently 0.60 lower than what's actually on the character sheet,

    Make sure the "mob level" on the calculator is "+0", i.e. your own level. Otherwise it calculates values for a level 88 "boss" (if you are still level 85). The character sheet always shows against a mob your own level (i.e. 85).

    i'll look into those trinkets later.

    And i completely forgot about mastery; i was distracted by dodge. i'm in quite a bit of pain right now and can't really think too much on it right now.

  • _ForgeUser306695 posted a comment Sep 27, 2012

    Ah. Yeah, my calculator's set for level 88 mobs. I'll have to check that when I get on next.

    Anything I can do to help with the Mastery part? It should be pretty straightforward, since it's a flat armor multiplier now instead of the weird savage defense shield mechanic.

    Thank you for all your hard work. Take care, and whatever's causing you pain, I hope it gets better soon.

  • _ForgeUser581183 posted a comment Sep 27, 2012

    <<reply 976160="">>

    Anything I can do to help with the Mastery part? It should be pretty straightforward, since it's a flat armor multiplier now instead of the weird savage defense shield mechanic.

    Yes! The damn thing makes no sense.

    Wowhead:

    Mastery: Nature's Guardian
    Requires Bear Form
    Increases your armor by 0 (+ 125% of SpellPower)%.
    

    Sounds like it increases your armor as a fraction of your Spell Power; if so, then what does Mastery do?

    Wowpedia

    Increases your armor by X%.
    

    Sounds like it increases your armor by the exact same amount as your Mastery %.

    So what does Mastery really do for Guardian specialization?

  • _ForgeUser581183 posted a comment Sep 27, 2012

    i'm just putting this is a clearer version. Where are you seeing this +0.91% increase from? TankPoints doesn't show the percentage a stat will go up by. RatingBuster might, but not TankPoints.


    Inventory:

    Ricket's Magnetic Fireball
    +340 Agility
    +401 Tankpoints (+0.76%)
    

    Equipped

    Brawler's Trophy
    Equip: Increases your dodge rating by 340
    

    With neither of them equipped in the second trinket slot.

    • Dodge Rating: 882
    • Agility: 4,359
    • Dodge Chance: 18.69%

    Equipping Ricket's Magnetic Fireball:

    • Dodge Rating: ?
    • Agility: ?
    • Dodge Chance: 19.60%

    Equipping Brawler's Trophy:

    • Dodge Rating: ?
    • Agility: ?
    • Dodge Chance: 19.53%

    Edited Sep 27, 2012
  • _ForgeUser306695 posted a comment Sep 27, 2012

    Herpderp. It was RatingBuster. Tankpoints calculator shows the same gain as actual.

    Okay, what Guardian mastery actually does:

    Passive
    Requires Bear Form
    Increases your armor by (mastery %).

    Mastery % has a base value of 10% before gear.
    In other words, I have 897 Mastery, which says it gives me 6.25% mastery. Mastery on my character sheet says 16.25%, and hovering over it says it increases my armor by 16%.

  • _ForgeUser581183 posted a comment Sep 27, 2012

    <<reply 977016="">>

    Mastery on my character sheet says 16.25%, and hovering over it says it increases my armor by 16%

    Can you update the spreadsheet with more numbers

    • Mastery Rating
    • Mastery Rating Bonus
    • Mastery
    • Armor

    Using my psychic powers i think the problems you were having before with pasting values into google spreadsheet is that it would only let you paste 50k at a time.

    If you paste multiple individual columns (painful, i know, believe me - i know), you can probably paste all the data in.

    Or at least your MasteryRating, MasteryRatingBonus, Mastery, Armor


    Edit: Awww crap. My stat recording in TankPoints doesn't record armor. (le sigh). i'll update TankPoints again to include that later tonight.

    Then could you post updated data.


    Edited Sep 27, 2012
  • _ForgeUser306695 posted a comment Sep 27, 2012

    @JackTripper: Go

    Quote:

    Awww crap. My stat recording in TankPoints doesn't record armor. (le sigh).

    Heh, I noticed that, or I already would have sent you some. As soon as I see the new version I'll log you some data. Can it record armor values both before and after any bonus multipliers, or just the final total?

  • _ForgeUser581183 posted a comment Sep 27, 2012

    <<reply 977584="">>

    Can it record armor values both before and after any bonus multipliers, or just the final total?

    Just the totals. i call only Blizzard's functions, returning their "pristine" values - so we can reverse engineer them.


    i just updated, but haven't tested TP. i hope it doesn't crash, and i hope it records what it should

  • _ForgeUser306695 posted a comment Sep 28, 2012

    Alright. I posted a Mastery & Armor log on a new tab. There'll be a clump of them that doesn't fit in, because I accidentally started gear switching in flight form instead of bear.

    Oddly, what it says in the 2nd and 3rd columns don't reflect what's shown on my character sheet.

  • _ForgeUser306695 posted a comment Sep 28, 2012

    Would it help if I cut down on the variables by giving you a good range of Mastery values, but with the same base item armor?

  • _ForgeUser581183 posted a comment Sep 28, 2012

    <<reply 978578="">>

    i updated TankPoints, to now output your shapeshift.

    Can you run through the items again.

    And check "Mastery" in the original file, there should be deciml points that did not make it into the google spreadsheet.

  • _ForgeUser306695 posted a comment Sep 28, 2012

    It threw me two new error messages, and won't log my stats. I just posted them as other tickets.


    Edited Sep 28, 2012
  • _ForgeUser581183 posted a comment Sep 28, 2012

    There, try that. (untested)

    That's what i get for making changes blind from work, while sick.

    and what you get for testing alpha software :)

  • _ForgeUser306695 posted a comment Sep 28, 2012

    Okay, got a log added. I put it on a new tab. Something odd happened, though. Your stat logs now record final % values for things like dodge, parry, mastery, etc. rounded to whole numbers. Yes, it's really like that in the LUA file.

    I would imagine that will make reverse engineering the numbers problematic.

  • _ForgeUser581183 posted a comment Sep 28, 2012

    <<reply 979011="">>

    Now that i'm home i'm gonna test it in game.

    Either you're full of shit, or i'm a moron.


    Edit: i'm a moron. Fixed.


    Edited Sep 28, 2012
  • _ForgeUser306695 posted a comment Sep 28, 2012

    Okay, new data on the spreadsheet, for this, and for the problem on my DK I made a ticket about.

    The MasteryRatingBonus and Mastery columns still don't match what my character sheet says.

  • _ForgeUser306695 posted a comment Sep 29, 2012

    What triggers it to collect your stats? Cuz I can go through and reforge every piece, and only have a log with 2 or 3 lines of stats recorded.
    Do I have to close & reopen the character panel between each one to catch the change?

  • _ForgeUser581183 posted a comment Sep 29, 2012

    <<reply 980670="">>

    The main even that does it is changing equipment. The other one is "unit aura".

    i'm in the process of adding a bunch more triggers:

    • unit level
    • unit stats (str, sta, agi, int, spi)
    • LEARNED_SPELL_IN_TAB
    • CHARACTER_POINTS_CHANGED
    • ACTIVE_TALENT_GROUP_CHANGED
    • PLAYER_DAMAGE_DONE_MODS (e.g. spell healing)
    • SPELL_POWER_CHANGED

    But for how equipping or unequipping something is the main trigger

  • _ForgeUser306695 posted a comment Oct 1, 2012

    Another batch of same armor/different mastery data points is up.

  • _ForgeUser581183 posted a comment Oct 1, 2012

    <<reply 984840="">>

    Thanks. i've not forgotten you, your armor, and your mastery.

    i've just been distracted by other things. Such as being sick for 3 days. Work. And my own character's Dodge and Parry being wrong!

    Soon.


    Edit: It's actually slightly more complicated. Because there is no way to get your "base armor" (i.e. armor without mastery), in order to figure out how much armor you'll gain we have to:

    • un-calculate how much you got from Effective Mastery
    • add the new Mastery Rating
    • calculate the new Mastery
    • calculate the new Effective Mastery

    It gets even worse if you are equipping an item that grants Armor and Mastery at the same time.


    Edited Oct 1, 2012
  • _ForgeUser306695 posted a comment Oct 2, 2012

    No worries, real life comes first. I just want to make sure you have good data to work with whenever you can get around to it.

    I saw the DK numbers have changed. Their dodge looks good now, though I haven't tested it really. Parry's off in the other direction now, but I haven't had time to gather specifics for you.

  • _ForgeUser581183 posted a comment Oct 3, 2012

    Okay,

    i took a crack at it.

    Mastery now understand that there's a "Mastery Factor", and if Mastery changes then it should increase your armor....

    ...your armor by.....

    well...let's just hope it works.

  • _ForgeUser306695 posted a comment Oct 4, 2012

    Mastery's effects aren't showing in the calculator.
    They're not showing on my DK, either, and I swear they used to.

  • _ForgeUser306695 edited description Oct 6, 2012

To post a comment, please login or register a new account.