<city> substitution for mage portals #91


  • Accepted
Open
  • rismisner created this issue Dec 5, 2009
    Owner

    What is the enhancement in mind? How should it look and feel?

    to facilitate shared lists from /ss macro (or /ss group) it would be nice to have a <city> substitution

    this would require parsing the spell name

  • rismisner added the tags Accepted Enhancment Dec 5, 2009
  • rismisner posted a comment Nov 25, 2010

    a similar request came in to get the name of your <pet> from the spell.  WoW patch 4.0.1 changed the name of the Hunter spell, "Call Pet", to "Call Lady" or "Call Name" to include the name of the pet in the spell name.

    Parsing the name of either the city or the pet from the name of the spell is a very similar issue.

    (SS 4.0.3.01) <pet> is already supported as the value of UnitName("pet") which never worked before during Call Pet because the pet hasn't spawned yet.  Parsing it from the spell name would fix that, but we need to keep in mind a couple of things:

    A) If you already have a pet out, and you're summoning a different one... Prior to 4.0.1 this would fail to summon the new pet, and use your old pet's name.  I don't know what it does now.  It should use the new pet's name, and trigger on successfully cast.

    B) If you fail because the pet is dead... again, best to trigger it on successful casts only

    C) Spells other than Call Pet where you want to use the name of the pet (i.e. Bestial Wrath) should still use UnitName("pet")... so we should probably check for a certain spell ID (is it always the same spell ID?) and then parse it out of the name for those as an override (already possible in the substitution engine) and then use UnitName("pet") the rest of the time.

    D) Localization... the initial implementation of this would only work in English.  non-English needs to fall back to UnitName("pet") rather than get the wrong value from the simple substring approach (substring of "Call Name" from index 5 to the end).

    Some considerations about the <city> substitution

    A) Same localization issue as above

    B) speeches that are shared between all portals (which may or may not use <city>) vs. speeches that are specific to one city ("tell Jaina I said Hi").  It is now possible to create a redirect like "/ss macro <spellname> <city>" (though not yet possible to use <city>).  Should we do it that way?  Currently it has to trigger off each individual spell, which has its own list of speeches, which each hard-code the city name.  In practice, it calls for a shared speech list vs. a specific one, which gives you two basic options: trigger on the general cast and redirect to the specific speeches... or trigger on the specific cases and redirect to the general shared speech list.

    C) call pet may work the same way as portal spells now, if each "Call Name" spell has a different spell id per pet name.  I need to login to my hunter and find out.

  • rismisner posted a comment Apr 19, 2011

    From the curse comments, another request for this feature today. Copy-pasted.

    amaki80 said Monday, April 18, 2011 10:38:45 PM (14 hours ago)

    Hi. I've been using this addon ever since Witty Druid vanished and I could no longer have shapeshifting messages. I love it. I also used to use Witty Mage, but now that one is being discontinued as well. Based on witty mage, I'd like to make a suggestion. I currently have to make teleporting and portal messages for each and every spell, teleport: Stormwind, Teleport: Orgrimmar, etc. I tried making an /ss macro teleport, and setting it up to where all these spells derive the same messages from one macro. However, there doesn't seem to be a way for me to make it name the target locations. I have to make it neutral at the moment but I'd love it if it could name the destination. For instance at the moment I have messages like, "Here's a portal to god-knows where! <player><R> is not responsible for lost limbs during the portaling process. Have a nice day!" I'd love to be able to have <targetlocation> added so I can have macros like this: "Here we go everyone! Portal to <targetlocation> is now open! That'll be 75 gold please!" Or maybe "All aboard for <targetcity>! Don't know why you'd wanna go there, but oh well!" And not just portaling, but teleporting too, for those solo journeys mages make. "God I love being able to teleport to <targetcity> without having to wait on a hearthstone cooldown. MWahahaha!" "Ummm, I have to go to <targetcity> right away! Something about <guild> and <randomcritter>s getting into the <randomfaction>s underware again! BYE!!" Or how about: "/e channels massive energy to teleport <player*himself*herself> to <targetcity>! /s So long, and thanks for all the fish!"

    Anyway, the idea is that we cast any kind of teleport or portal, and SpeakinSpell can proc a message and automatically know what the target city is.

    "I hope I get this portal right... last time I tried to get to Darnassus and I ended up in the city of Oz!"

    "I'm headin' off to Thunderbluff! Good thing I don't have to wait for my hearthstone to finish cooling down, eh?"

    "Want a port to Stormwind, then? Okay! Be sure to keep your arms and hands inside the portal... last person didn't listen and he lost something... No, it's too dirty, I can't say it..."

    Hope you can implement this in the near future. Thanks =) Keep up the good work

  • rismisner removed their assignment Jan 16, 2013
  • rismisner assigned issue to _ForgeUser228323 Jan 16, 2013
  • rismisner posted a comment Jan 16, 2013

    I'm re-assigning all my tickets to Duerma

  • rismisner unassigned issue from _ForgeUser228323 May 7, 2015
  • rismisner posted a comment May 7, 2015

    Unassigning tickets that are not actively being worked on


To post a comment, please login or register a new account.