NPCs with hyphenated <target> names #191

  • Accepted
  • Defect
Open
  • View rismisner's Profile
    rismisner created this issue May 7, 2015
    Owner

    I noticed that the <target> command isn't working correctly with hyphenated  NPC names; for example the Shao-Tien Dominators. When it fires off the target name it simply says "Shao", ending at the hyphen.

  • View rismisner's Profile
    rismisner     added the tags Accepted Defect May 7, 2015
  • View rismisner's Profile
    rismisner posted a comment May 7, 2015

    This bug was introduced by fixing ticket 183 http://www.wowace.com/addons/speakinspell/tickets/183-player-names-server-names/

    We need to add some logic to detect if the target name is a player or an NPC. For players, the hyphen indicates the separation between Name-Realm, but that's not an issue for NPCs.

    Come to think of it, can player names have another hyphen? If the player's name is "Two-part" (is that allowed?) then the name-realm would include 2 hyphens as "Two-part-realm" and then the logic probably also fails. We may need to adjust the hyphen logic to do a reverse-find working backward from the end of the name instead of the beginning. Need to check the character creation screen to see if it will let me hyphenate a new toon name...

To post a comment, please login or register a new account.