stub.name = L["something"] is bad #107


  • Accepted
  • Other
Open
  • rismisner created this issue Jan 5, 2010
    Owner

    Custom events that are named AND KEYED by SpeakinSpell (instead of named and keyed by their spell names) create a localization problem.  If I change the localized name of that event, then the old data stops working in the new client.

    Writing patch functions to rename events each time the locale files are changed is not acceptable.  A better plan for backward compatibility in this area is needed.

    Possibly these custom events should use the english name as the key (leaving out the L) or an arbitrarily assigned ID number.

    One approach may be to redefine a little bit of the de.name and de.key values.

    de.name = would be always in english, unless it's a spell name already translated by blizzard.  Custom events named by SpeakinSpell would assign this to the English "name", instead of using L["name"]

    de.key = would thus use an english name for those custom events, to prevent the upgrade issue.  Patch functions could still rename these events, but would be able to rely on the event having a specific english name, and liberate the locale files to change without accompanying patch functions.

    <displayname> = would be formed from L[de.name] instead of tostring(de.name) to check for a localized value.  If L[de.name] does not exist, i.e. for untranslated spell names that are already translated by blizzard, L is an AceLocale object that automatically returns "key" for undefined L["key"] so it would return the untranslated de.name as-is, as-is.

  • rismisner added the tags Accepted Other Jan 5, 2010
  • rismisner removed their assignment Jan 16, 2013
  • rismisner assigned issue to _ForgeUser228323 Jan 16, 2013
  • rismisner posted a comment Jan 16, 2013

    I'm re-assigning all my tickets to Duerma

  • rismisner unassigned issue from _ForgeUser228323 May 7, 2015
  • rismisner posted a comment May 7, 2015

    Unassigning tickets that are not actively being worked on

  • rismisner posted a comment Jan 5, 2017

    This is closely related to

    https://www.wowace.com/projects/speakinspell/issues/125

     


    Edited Jan 5, 2017

To post a comment, please login or register a new account.