Lightforged draenei's forge of light #580


  • Defect
  • Fixed
Closed
  • lightscamera created this issue Nov 14, 2019

    Hi, I'd like to suggest 2 enhancements to Skillet.

     

    1) One is the addition of Lightforged draenei's forge of light skill button on blacksmiths window just like thermal anvil button.

     

    Thank you.

  • lightscamera added a tag Enhancement Nov 14, 2019
  • bsmorgan posted a comment Nov 14, 2019

    This should be two issues as there are two separate enhancements. However, Issue #1 may not be an enhancement. The following section of code in SkilletData.lua shows that something is defined, but it may not be working.

     

    Skillet.TradeSkillAdditionalAbilities = {
    	[7411]	=	{13262,"Disenchant"},		-- enchanting = disenchant
    	[2550]	=	{
    				{818,"Basic_Campfire"},		-- cooking = basic campfire
    				{134020,"Chef's_Hat",true},	-- cooking = Chef's Hat (toy)
    				},
    	[45357] =	{51005,"Milling"},			-- inscription = milling
    	[25229] =	{31252,"Prospecting"},		-- jewelcrafting = prospecting
    	[2018]	=	{
    				{126462,"Thermal_Anvil"},	-- blacksmithing = thermal anvil (item:87216)
    				{255650,"Forge of Light",false,true}, -- Lightforged Draenei radical
    				},
    	[4036]	=	{126462,"Thermal_Anvil"},	-- engineering = thermal anvil (item:87216)
    	[2575]	=	{126462,"Thermal_Anvil"},	-- smelting = thermal anvil (item:87216)
    }
    

     See issue #514. I do not have a Lightforged Draenei to test this with.


    Edited Nov 14, 2019
  • bsmorgan posted a comment Nov 14, 2019

    If 255650 doesn't work, try 259930. I'll need someone to test this and report back.


    Edited Nov 14, 2019
  • lightscamera posted a comment Nov 14, 2019

    I tried 259930 but it worked exactly same as 255650.

    Below are what I've tested in case it helps;

     

    {255650,"Forge of Light",false,true} -- 'forge of light' does not appear on all races regardless of professions

    {255650,"Forge of Light"}                  -- 'forge of light' appears on all races but only with professions

    {255650,"Forge of Light",false}         -- 'forge of light' appears on all races but only with professions

    {255650,"Forge of Light",true}         -- 'forge of light' does not appear on all races regardless of professions

    {255650,"Forge of Light",true,false} -- 'forge of light' does not appear on all races regardless of professions

     

    {259930 ,"Forge of Light",false,true} -- 'forge of light' does not appear on all races regardless of professions

    {259930 ,"Forge of Light"}                  -- 'forge of light' appears on all races but only with professions

    {259930 ,"Forge of Light",false}         -- 'forge of light' appears on all races but only with professions

    {259930 ,"Forge of Light",true}         -- 'forge of light' does not appear on all races regardless of professions

    {259930 ,"Forge of Light",true,false} -- 'forge of light' does not appear on all races regardless of professions

  • bsmorgan posted a comment Nov 15, 2019

    Obviously, I need to add a comment describing the entries to that table.

     

    The main index of this table is the profession (tradeID). For each profession, there is one (or more) entries which are (required) the spellID and spellName plus (optional) boolean for Toy (true) or Spell (false), (optional) boolean must also know spell (true)  or must just have this profession (false). Note that missing optional entries are the same as nil which tests the same as false.

     

    For example, in cooking, Basic Campfire is available to everyone that has Cooking. The Chef's Hat is a toy and must be in the Toy Box.

     

    The Forge of Light entry is for Blacksmiths and  should be {SpellID, Name, false, true} indicating that it is a spell and should be present in the Spellbook to be available.

     

    In your experiments, did you test that the Forge of Light button actually worked?


    Edited Nov 15, 2019
  • lightscamera posted a comment Nov 15, 2019

    Yes, it actually worked on Light forged draenai with blacksmithing profession but Not on other races with blacksmithing profession.

  • bsmorgan posted a comment Nov 16, 2019

    Both 255650 and 259930 ?

  • bsmorgan edited title and description Nov 16, 2019
  • lightscamera posted a comment Nov 16, 2019

    Yup I confirm both 255650 and 259930 works. I just tested it again to make sure.


    Edited Nov 16, 2019
  • bsmorgan posted a comment Nov 17, 2019

    Skillet-r789-alpha should fix this problem.

     

    Note: This build is phase 1 of porting Skillet-Classic restructuring and features to Skillet. There may be other problems which should be reported as a separate issue for each.

  • bsmorgan added the tags Defect Fixed Nov 17, 2019
  • bsmorgan removed a tag Enhancement Nov 17, 2019
  • lightscamera posted a comment Nov 17, 2019

    I confirm that 'forge of light' works correctly on lightforged draenai with blacksmithing and appears only on that condition on build r789.

  • bsmorgan posted a comment Nov 17, 2019

    Thanks for verifying the fix.

  • bsmorgan closed issue Nov 17, 2019

To post a comment, please login or register a new account.