Questions about Custom Groups #75


  • Other
Closed
  • bsmorgan created this issue Oct 10, 2019
    Owner

    Skillet-Classic r80-alpha (developer created)

     

    From a comment by Stizzled024: The button to the right of the  group drop-down menu lets you create a new custom Grouping, but what about creating a new group within that custom Grouping? Am I missing something?

     

  • bsmorgan added a tag Other Oct 10, 2019
  • bsmorgan posted a comment Oct 10, 2019

    It may be that I'm the one missing something! I removed (commented out) those right-click options because they would crash Skillet-Classic. When I get the current reduced functionality working as intended, then I'll restore those right-click options and see if they still crash. Issue #74 is a show-stopper and I need to get that fixed first.

     

    You may have hit upon the reason why those right-click options need to be there. Please add your thoughts, examples, designs, etc. to this issue to help me (us) better understand what needs to be done.

  • Stizzled024 posted a comment Oct 10, 2019

    One of the main reasons I want to use Skillet is for the custom grouping, especially for Enchanting. The default Blizzard grouping, or lack thereof, is just terrible.

     

    How it worked before the right-click menu was disabled was fine. I could create sub-groups and copy patterns from the Blizzard grouping and paste them into my custom grouping's sub-groups. I don't really have any suggestions on ways to improve it.

     

    It did have some annoyances, such as not being able to reorder the sub-groups. Naming them could also be a pain. For example, naming a sub-group 'Shield' and then deleting it would cause any future sub-groups named 'Shield' to add a number to the name. Even with no other sub-groups named 'Shield' creating a new sub-group and trying to name it 'Shield' would result in 'Shield 1', and after deleting that 'Shield 2', and so on.

     

    I didn't really get to play with it much. I could create a custom grouping, populate it and that was about it. They would become unusable after logout and throw the error I had posted in a previous issue.

     

  • bsmorgan posted a comment Oct 11, 2019

    I'll try and get those options re-enabled for the next build.

  • bsmorgan posted a comment Oct 11, 2019

    I have re-enabled the options and have custom groups surviving logoff / logon (or /reload) as long as the custom groups don't have subgroups. Subgroups are proving to be tricky.

  • bsmorgan posted a comment Oct 13, 2019

    Hopefully, this will tickle you to respond...

     

    When you were playing with sub-groups, did you ever use "New Group", "Empty Group" or did you always use "New Group", "from Selection"?

     

    The reason I ask is because "Empty Group" creates an empty group, but it doesn't display so you can't add anything to it. I checked Skillet on _retail_ and it behaves the same way, so I'm guessing it never worked. "from Selection" works (as long as there is a non-empty selection). There is code that is supposed to display an empty group, but that code never gets executed as the pre-conditions to get to that code fail. When you have a subGroup with entries, you can delete the entries one at a time but when you delete the last entry, the subGroup disappears. I believe that trying to fix this is a red-herring. What do you think? 

     

    What I have done is remove "New Group" from the right-click menu when you are displaying the locked groups ("Blizzard" and "Flat") because neither entry should work when those groups are displayed (because they are locked), so having the menu choices was confusing to me (and I'm guessing anyone else).

     

    I still can't get the custom groups to survive logoff and logon. I believe I have convinced myself that logoff is saving the data correctly but the login code to recreate the in memory structure(s) for the group isn't putting it back properly. The in memory structure(s) are a tangled mess of tables pointing to tables and they are very difficult to follow because many of the pointers are circular (i.e. tables point to tables which point back).

     

    I am creating a tangled mess when I convert the saved variables to in memory structures, just not the right tangled mess. If the original architect of this code was still around, I think I'd strangle them.


    Edited Oct 13, 2019
  • Stizzled024 posted a comment Oct 14, 2019

    I was creating new Empty Groups. They would display as "New Group (0)" when created. I could then rename them and copy & paste recipes to it from the Blizzard grouping.

     

    I tested this again just now by reinstalling r56-alpha (simply because I still had that one laying around) just to confirm I wasn't remembering incorrectly. New custom grouping, created new empty sub-groups and added a recipe from the Blizzard grouping.

     

    https://imgur.com/a/3gc3mSm

     

    Before I added a recipe to one of the sub-groups the custom grouping survived several /reload and game restarts. But, once I added the recipe the custom grouping starts throwing an LUA error and becomes unusable.

  • bsmorgan posted a comment Oct 14, 2019

    Thanks, that's good information. Perhaps the New Empty groups not displaying is a symptom of my current problem.

  • bsmorgan posted a comment Oct 14, 2019

    Skillet-Classic-r81-alpha is much closer to fully functional. It took a three-way line by line comparison between Skillet (_retail_), r56-alpha, and Skillet-Classic to finally fix the major bugs. Thanks for the r56 pointer! It helped find a bug in Skillet that got copied over to Skillet-Classic.

     

    Please put this through as much testing as you can and report any problems in new issues. I'm going to leave this issue open for questions.

     

    I still need to polish the menus a bit. I got some updates from Skillet that aren't quite working yet. There are also some Ignore entries in the menus you can ignore (for now)!

     

    Thanks again for your help!

  • bsmorgan added an attachment Oct 14, 2019
    Attachment was deleted by bsmorgan Oct 14, 2019
  • bsmorgan posted a comment Oct 14, 2019

    Skillet-Classic-r82-alpha has the menus tweaked (and the Ignore entries are functional).

     

    If you are feeling brave, you can adjust the menus yourself. The title of each menu is the name of the table in MainFrame.lua that creates it. You should be able to figure out the syntax of how each line in the menu is created and add or remove entries until they suit you. When you are satisfied, you can just post your copy of MainFrame.lua and I'll put it in the next build.

     

    If your not so brave, you can, of course, just tell me what changes you would like. The titles will help you communicate which menu you would like to change.

     

    There are three menus for locked groups and three menus for unlocked (custom) groups. The three are mouse over a 1) header/subgroup, 2) line item, 3) not over either one (i.e. empty space).

     

    Have fun!


    Edited Oct 14, 2019
  • bsmorgan closed issue Oct 15, 2019

To post a comment, please login or register a new account.