This site works best with JavaScript enabled. Please enable JavaScript to get the best experience from this site.
Hi. Thank you for maintaining this great addon.
Two issues with SUF:
1) In default UI for shadowpriests or warlocks your guardians like shadow fiend, darkglare or infernal are effectively totems and they're put in totem bar if summoned, you can verify this with addon like moveanything or default /framestack. You can right click them to dismiss like totem seen in the pictures below.
https://imgur.com/0Q5Kuqyhttps://imgur.com/0Q5Kuqyhttps://imgur.com/0Q5KuqyHowever in SUF totem bar simply not working for warlock or shadow priest. For demo warlock there's separate dreadstalkers bar which seems to act as totem bar for shamans and totem bars for shamans has it's own issues: "show icon durations" not working, little "13.0" nubmer below is supposed to be icon of totem according to this setting but it's not:
Would be nice to have warlock and priests abilities to act as totems like in default UI so we can click them off or if this.
2) When you're using SUF you're stripped of sounds targeting/focusing from default interface. I found that this issue was already brought up before
and you stated that SUF has nothing to do with sounds. However I found that because SUF creates it's own frames default sounds are not playing when using targeting or focusing. It seems that author of SUF(sorry if I'm wrong here) - Shadowed103 created addon Damn Unit Sounds to fix that issue, but addon no longer working because Blizzard changed how sound API works, however it's pretty easy to fix that, but addon is under "ALL RIGHTS RESERVED" So it can't be just taken over, I though that maybe you're in contact with Shadowed103 and can include fixed addon inside SUF or can ask for permission to maintain Damn Unit Sound:, below is code of Damn Unit Sound changed to use with new sound API, I haven't changed any code but new API uses sound files IDs instead of soundfiles names that why it's been broken since Legion:
Put your spoiler here.
--[[ Shadow, Mal'Ganis (US)]]
local Sounds = select(2, ...)
-- Focus soundsfunction Sounds:PLAYER_FOCUS_CHANGED() if( UnitExists("focus") ) then if( UnitIsEnemy("focus", "player") ) then PlaySound("873") elseif( UnitIsFriend("player", "focus") ) then PlaySound("867") else PlaySound("871") end else PlaySound("684") endend
-- Target soundsfunction Sounds:PLAYER_TARGET_CHANGED() if( UnitExists("target") ) then if( UnitIsEnemy("target", "player") ) then PlaySound("873") elseif( UnitIsFriend("player", "target") ) then PlaySound("867") else PlaySound("871") end else PlaySound("684") endend
-- PVP flag soundslocal announcedPVPfunction Sounds:UNIT_FACTION(unit, ...) if( unit ~= "player" ) then return end
if( UnitIsPVPFreeForAll("player") or UnitIsPVP("player") ) then if( not announcedPVP ) then announcedPVP = true PlaySound("4574") end else announcedPVP = nil endend
local frame = CreateFrame("Frame")frame:RegisterEvent("PLAYER_FOCUS_CHANGED")frame:RegisterEvent("PLAYER_TARGET_CHANGED")frame:RegisterEvent("UNIT_FACTION")frame:SetScript("OnEvent", function(self, event, ...) Sounds[event](Sounds, ...)end)
To post a comment, please login or register a new account.