WowAce

The PlaySoundKitID global change in 7.3 has broken this addon. (Can't access /sct menu). Correct as follows:

Replace existing lines with the following in sct\sct.LUA:

LINE 210: PlaySound( 850 )

LINE 220: PlaySound( 3081 )

LINE 228: PlaySound( 851 )

Replace existing lines with the following in sct_options\options.LUA:

LINE 548: PlaySound( 841 )

LINE 1010: PlaySound( 856 )

LINE 1079: PlaySound( 856 )

LINE 1099: PlaySound( 856 )

I replaced as per your instructions but it still gives me an error related with PlaySoundKitID AND it won't save preferences.

Any way that someone can pick up this addon and update it? I really, really got used to it and now it feels so weird...

Things get weird if you only put the ID in the call, if you update them to include the full arguments it seems to work fine.

Such as (where applicable):

PlaySound(SOUNDKIT and SOUNDKIT.IG_MAINMENU_OPTION or 'igMainMenuOption')
PlaySound(SOUNDKIT and SOUNDKIT.GS_TITLE_OPTION_EXIT or 'gsTitleOptionExit')

PlaySound(PlaySoundKitID and "igMainMenuOptionCheckBoxOn" or 856)
PlaySound(PlaySoundKitID and "igMainMenuOptionCheckBoxOff" or 857)

I just replaced the appropriate checkbox PlaySound spots and gave everything else the igMainMenuOption sound since it didn't really matter - just wanted functionality. Seems you have to do this in every instance of PlaySound function calls in both sct.lua (in sct folder) and options.lua (in sct_options folder). 

I didn't find any issues just using the specific sound ID. However, there still exists an issue even using the above where SCT options won't save and throw a PlaySound LUA error

You have to make sure to catch 100% of the calls, there were quite a few across even XML files - I can provide my working version of the add-on if you guys prefer. 

I don't see any way to submit a pull request to curse but I guess I can start a new project with the Legion-fixed version. Once I replaced every instance with the new calls/args I pasted above, fully functional options saving.

This should be all of them, if you want to verify against all the ones you've already replaced:

/sct-v7.1/sct/sct.lua:
   ..
  208    local loaded, message = LoadAddOn("sct_options")
  209    if (loaded) then
  210:     PlaySound("igMainMenuOpen")
  211      if not menuloaded then
  212        SCT:MakeBlizzOptions()
  ...
  218      InterfaceOptionsFrame_OpenToCategory("SCT "..SCT.LOCALS.OPTION_MISC21.name)
  219    else
  220:     PlaySound("TellMessage")
  221      SCT:Print(SCT.LOCALS.Load_Error.." "..message)
  222    end
  ...
  226  --Hide the Option Menu
  227  function SCT:HideMenu()
  228:   PlaySound("igMainMenuClose")
  229    HideUIPanel(SCTOptions)
  230  end
  ...

/sct-v7.1/sct_options/options.lua:
  546  function SCT:OptionFrameTabClick(tab)
  547    self:ToggleFrameTab(tab:GetName(),self.OptionFrameFrames[tab:GetName()].frame)
  548:   PlaySound("igCharacterInfoTab")
  549  end
  550  
  ...
 1008      SCT:CustomEventsScrollBar_Update()
 1009      --sound
 1010:     PlaySound("igMainMenuOptionCheckBoxOn")
 1011      --close details
 1012      SCTOptions_CustomEventsDetailsFrame:Hide()
 ....
 1077    SCT:CustomEventsScrollBar_Update()
 1078    --sound
 1079:   PlaySound("igMainMenuOptionCheckBoxOn")
 1080    --close details
 1081    SCTOptions_CustomEventsDetailsFrame:Hide()
 ....
 1097    SCT:CustomEventsScrollBar_Update()
 1098    --sound
 1099:   PlaySound("igMainMenuOptionCheckBoxOn")
 1100    --close details
 1101    SCTOptions_CustomEventsDetailsFrame:Hide()

/sct-v7.1/sct_options/options.xml:
   11       <OnClick>
   12         if ( self:GetChecked() ) then
   13:          PlaySound("igMainMenuOptionCheckBoxOff");
   14         else
   15:          PlaySound("igMainMenuOptionCheckBoxOn");
   16         end
   17         SCT:OptionsCheckButtonOnClick(self);
   ..
   76     <Scripts>
   77       <OnClick>
   78:        PlaySound("igMainMenuOptionCheckBoxOff");
   79         SCT:OptionsRadioButtonOnClick(self, self:GetID(),self:GetParent():GetName());
   80       </OnClick>
   ..
  422     <Scripts>
  423       <OnClick>
  424:        PlaySound("igMainMenuOptionCheckBoxOn");
  425       </OnClick>
  426       <OnEnter>
  ...
  446     <Scripts>
  447       <OnClick>
  448:        PlaySound("igMainMenuOptionCheckBoxOn");
  449       </OnClick>
  450       <OnEnter>
  ...
 1224               <OnClick>
 1225                 if ( self:GetChecked() ) then
 1226:                  PlaySound("igMainMenuOptionCheckBoxOff");
 1227                   SCT:EnableNameplate();
 1228                 else
 1229:                  PlaySound("igMainMenuOptionCheckBoxOn");
 1230                   SCT:DisableNameplate();
 1231                 end
 ....
 1398               <OnClick>
 1399                 if ( self:GetChecked() ) then
 1400:                  PlaySound("igMainMenuOptionCheckBoxOff");
 1401                 else
 1402:                  PlaySound("igMainMenuOptionCheckBoxOn");
 1403                 end
 1404                 SCT:OptionsCheckButtonOnClick(self);

/sct-v7.1/sct/sct.lua:
  208    local loaded, message = LoadAddOn("sct_options")
  209    if (loaded) then
  210:     PlaySound("igMainMenuOpen")
  211      if not menuloaded then
  212        SCT:MakeBlizzOptions()
  ...
  218      InterfaceOptionsFrame_OpenToCategory("SCT "..SCT.LOCALS.OPTION_MISC21.name)
  219    else
  220:     PlaySound("TellMessage")
  221      SCT:Print(SCT.LOCALS.Load_Error.." "..message)
  222    end
  ...
  226  --Hide the Option Menu
  227  function SCT:HideMenu()
  228:   PlaySound("igMainMenuClose")
  229    HideUIPanel(SCTOptions)
  230  end

/sct-v7.1/sct_options/options.lua:
  546  function SCT:OptionFrameTabClick(tab)
  547    self:ToggleFrameTab(tab:GetName(),self.OptionFrameFrames[tab:GetName()].frame)
  548:   PlaySound("igCharacterInfoTab")
  549  end
  550  
  ...
 1008      SCT:CustomEventsScrollBar_Update()
 1009      --sound
 1010:     PlaySound("igMainMenuOptionCheckBoxOn")
 1011      --close details
 1012      SCTOptions_CustomEventsDetailsFrame:Hide()
 ....
 1077    SCT:CustomEventsScrollBar_Update()
 1078    --sound
 1079:   PlaySound("igMainMenuOptionCheckBoxOn")
 1080    --close details
 1081    SCTOptions_CustomEventsDetailsFrame:Hide()
 ....
 1097    SCT:CustomEventsScrollBar_Update()
 1098    --sound
 1099:   PlaySound("igMainMenuOptionCheckBoxOn")
 1100    --close details
 1101    SCTOptions_CustomEventsDetailsFrame:Hide()

/sct-v7.1/sct_options/options.xml:
   11       <OnClick>
   12         if ( self:GetChecked() ) then
   13:          PlaySound("igMainMenuOptionCheckBoxOff");
   14         else
   15:          PlaySound("igMainMenuOptionCheckBoxOn");
   16         end
   17         SCT:OptionsCheckButtonOnClick(self);
   ..
   76     <Scripts>
   77       <OnClick>
   78:        PlaySound("igMainMenuOptionCheckBoxOff");
   79         SCT:OptionsRadioButtonOnClick(self, self:GetID(),self:GetParent():GetName());
   80       </OnClick>
   ..
  422     <Scripts>
  423       <OnClick>
  424:        PlaySound("igMainMenuOptionCheckBoxOn");
  425       </OnClick>
  426       <OnEnter>
  ...
  446     <Scripts>
  447       <OnClick>
  448:        PlaySound("igMainMenuOptionCheckBoxOn");
  449       </OnClick>
  450       <OnEnter>
  ...
 1224               <OnClick>
 1225                 if ( self:GetChecked() ) then
 1226:                  PlaySound("igMainMenuOptionCheckBoxOff");
 1227                   SCT:EnableNameplate();
 1228                 else
 1229:                  PlaySound("igMainMenuOptionCheckBoxOn");
 1230                   SCT:DisableNameplate();
 1231                 end
 ....
 1398               <OnClick>
 1399                 if ( self:GetChecked() ) then
 1400:                  PlaySound("igMainMenuOptionCheckBoxOff");
 1401                 else
 1402:                  PlaySound("igMainMenuOptionCheckBoxOn");
 1403                 end
 1404                 SCT:OptionsCheckButtonOnClick(self);

Nice post - this will make it easy for the author to update if he decides to. 

I had indeed missed the calls in the sct_options\options.xml file. Fixing that solved the remaining errors.

Hey just a heads up - got zero response from Grayhoof so put up a version of the add-on with this issue and others fixed. ScrollingCombatText2

Will keep it updated and debugged as needed throughout releases.

Brilliant Mordist - a lot of folks (including myself) love this addon and have been using is since Vanilla! Great news!

any news on where to get the version of mordist? his link seems dead