Getting AP on bonus roll counts as getting loot #257


  • Defect
  • Patch
Closed
  • Hemar created this issue Jan 17, 2017

    In 7.1.5 you now get AP instead of gold when doing a bonus roll.

    However, SI still counts this as getting loot and resets the bonus roll counter to 0

  • thirdgencubfan posted a comment Mar 27, 2017

    I figured out a hack to get Saved Instances to track bonus rolls correctly after the introduction of Artifact Power rewards from bonus rolls.

     

    In the file SavedInstances.lua, line 4737:

      if rewardType == "money" then
        roll.money = rewardQuantity
      elseif rewardType == "item" then
        roll.item = rewardLink
      end

     

    Change to:

     

      if rewardType == "money" then
        roll.money = rewardQuantity
      elseif rewardType =="artifact_power" then
        roll.money = 25
      elseif rewardType == "item" then
        roll.item = rewardLink
      end

     It's a kludge because it fakes out the artifact power reward as if you got money. I put 25 there since the AP items from bonus rolls vendor for 25 gold.

  • jokeyrhyme added the tags Defect Patch Oct 14, 2017
  • Cakechart posted a comment Feb 3, 2018

    Hey there! :D

     

    Since a lot of time has passed and the project has been undergoing many changes, with different versions being merged and bugs being fixed, I'm closing this issue as potentially no longer relevant.

     

    Feel free to re-open a ticket if there is still a problem with the latest version of the addon available on WowAce/CurseForge and it shall be looked into properly.

  • Cakechart closed issue Feb 3, 2018

To post a comment, please login or register a new account.