Incorrect conversion on commas #288


  • New
  • Defect
Open
Assigned to _ForgeUser31
  • _ForgeUser6327803 created this issue Mar 21, 2013

    Addon Version: r396
    Wow Version: 5.2.0 (16733)
    Locale: Chinese Simplified (zhCN)

    What steps will reproduce the problem?
    1. Viewing any items with stats more than 999.

    What is the expected output? What do you see instead?
    The output in game is as shown below:
    +1,147力量(+147治疗, +0.17%招架)
    It says 1147 strength only increase healing by 147 and parry by 0.17%, which should be the result of 147 strength.

    A possible solution:
    I inspected the locale file "zhCN.lua" in \RatingBuster\locales and found L["separators"] includes a ","(the English half-width comma) , which may mislead the addon to think +1,147 is two effects.
    However, in my experience, Chinese version always uses ","(the full-width comma) as separators, and this comma is already in L["separators"].
    I simply removed "," from that array, and found the display is correct now.
    I am not sure if this will bring any side effects.

  • _ForgeUser6327803 added the tags New Defect Mar 21, 2013
  • mcremor posted a comment Mar 22, 2013

    RatingBuster has an open repository. If you have a fix, please go ahead and check it in.


To post a comment, please login or register a new account.